microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 04:43:37 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

isMinusPrefixUnaryExpression() -> isPrefixUnaryExpression() after code review

Browse Source
This commit is contained in:
arusakov
2016-12-22 00:56:39 +03:00
parent db1fda5e77
commit 23faaff032
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -21865,7 +21865,7 @@ namespace ts {
diagnosticMessage = Diagnostics.Octal_literal_types_must_use_ES2015_syntax_Use_the_syntax_0;
}
if (diagnosticMessage) {
const withMinus = isMinusPrefixUnaryExpression(node.parent);
const withMinus = isPrefixUnaryExpression(node.parent) && node.parent.operator === SyntaxKind.MinusToken;
const literal = `${withMinus ? "-" : ""}0o${node.text}`;
return grammarErrorOnNode(withMinus ? node.parent : node, diagnosticMessage, literal);
}

5
src/compiler/utilities.ts
View File

@@ -742,9 +742,8 @@ namespace ts {
return false;
}
export function isMinusPrefixUnaryExpression(node: Node): boolean {
return node.kind === SyntaxKind.PrefixUnaryExpression &&
(node as PrefixUnaryExpression).operator === SyntaxKind.MinusToken;
export function isPrefixUnaryExpression(node: Node): node is PrefixUnaryExpression {
return node.kind === SyntaxKind.PrefixUnaryExpression;
}
// Warning: This has the same semantics as the forEach family of functions,