microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-05 04:25:39 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(41621): fixUnusedIdentifier - allow deleting prefix/postfix unary operators (#41624)

Browse Source
This commit is contained in:
Oleksandr T
2020-11-30 23:58:47 +02:00
committed by GitHub
parent 1bd8e388ae
commit 23b3eb685f
5 changed files with 62 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/services/codefixes/fixUnusedIdentifier.ts
View File

@@ -225,7 +225,7 @@ namespace ts.codefix {
if (isIdentifier(token)) {
FindAllReferences.Core.eachSymbolReferenceInFile(token, checker, sourceFile, (ref: Node) => {
if (isPropertyAccessExpression(ref.parent) && ref.parent.name === ref) ref = ref.parent;
if (!isFixAll && isBinaryExpression(ref.parent) && isExpressionStatement(ref.parent.parent) && ref.parent.left === ref) {
if (!isFixAll && mayDeleteExpression(ref)) {
changes.delete(sourceFile, ref.parent.parent);
}
});
@@ -332,4 +332,9 @@ namespace ts.codefix {
parameters.slice(index + 1).every(p => isIdentifier(p.name) && !p.symbol.isReferenced) :
index === parameters.length - 1;
}
function mayDeleteExpression(node: Node) {
return ((isBinaryExpression(node.parent) && node.parent.left === node) ||
((isPostfixUnaryExpression(node.parent) || isPrefixUnaryExpression(node.parent)) && node.parent.operand === node)) && isExpressionStatement(node.parent.parent);
}
}

14
tests/cases/fourslash/codeFixUnusedIdentifier_postfix_operator1.ts Normal file
View File

@@ -0,0 +1,14 @@
/// <reference path='fourslash.ts' />
// @noUnusedLocals: true
////function fn() {
//// let x = 1;
//// x++;
////}
verify.codeFix({
description: "Remove unused declaration for: 'x'",
newFileContent:
`function fn() {
}`
});

14
tests/cases/fourslash/codeFixUnusedIdentifier_postfix_operator2.ts Normal file
View File

@@ -0,0 +1,14 @@
/// <reference path='fourslash.ts' />
// @noUnusedLocals: true
////function fn() {
//// let x = 1;
//// x--;
////}
verify.codeFix({
description: "Remove unused declaration for: 'x'",
newFileContent:
`function fn() {
}`
});

14
tests/cases/fourslash/codeFixUnusedIdentifier_prefix_operator1.ts Normal file
View File

@@ -0,0 +1,14 @@
/// <reference path='fourslash.ts' />
// @noUnusedLocals: true
////function fn() {
//// let x = 1;
//// ++x;
////}
verify.codeFix({
description: "Remove unused declaration for: 'x'",
newFileContent:
`function fn() {
}`
});

14
tests/cases/fourslash/codeFixUnusedIdentifier_prefix_operator2.ts Normal file
View File

@@ -0,0 +1,14 @@
/// <reference path='fourslash.ts' />
// @noUnusedLocals: true
////function fn() {
//// let x = 1;
//// --x;
////}
verify.codeFix({
description: "Remove unused declaration for: 'x'",
newFileContent:
`function fn() {
}`
});