microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 18:04:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(59484): Constructor overload still present in emitted JS (#59491)

Browse Source
This commit is contained in:
Oleksandr T.
2024-08-08 19:37:57 +03:00
committed by GitHub
parent 67d0fc13ce
commit 1f54d0a935
5 changed files with 87 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/compiler/factory/nodeFactory.ts
View File

@@ -1985,10 +1985,15 @@ export function createNodeFactory(flags: NodeFactoryFlags, baseFactory: BaseNode
node.parameters = createNodeArray(parameters);
node.body = body;
node.transformFlags = propagateChildrenFlags(node.modifiers) |
propagateChildrenFlags(node.parameters) |
(propagateChildFlags(node.body) & ~TransformFlags.ContainsPossibleTopLevelAwait) |
TransformFlags.ContainsES2015;
if (!node.body) {
node.transformFlags = TransformFlags.ContainsTypeScript;
}
else {
node.transformFlags = propagateChildrenFlags(node.modifiers) |
propagateChildrenFlags(node.parameters) |
(propagateChildFlags(node.body) & ~TransformFlags.ContainsPossibleTopLevelAwait) |
TransformFlags.ContainsES2015;
}
node.typeParameters = undefined; // initialized by parser for grammar errors
node.type = undefined; // initialized by parser for grammar errors

19
tests/baselines/reference/constructorOverloads9.js Normal file
View File

@@ -0,0 +1,19 @@
//// [tests/cases/compiler/constructorOverloads9.ts] ////
//// [constructorOverloads9.ts]
export class C {
a;
constructor();
constructor(x = '') {
this.a = x;
}
}
//// [constructorOverloads9.js]
export class C {
a;
constructor(x = '') {
this.a = x;
}
}

21
tests/baselines/reference/constructorOverloads9.symbols Normal file
View File

@@ -0,0 +1,21 @@
//// [tests/cases/compiler/constructorOverloads9.ts] ////
=== constructorOverloads9.ts ===
export class C {
>C : Symbol(C, Decl(constructorOverloads9.ts, 0, 0))
a;
>a : Symbol(C.a, Decl(constructorOverloads9.ts, 0, 16))
constructor();
constructor(x = '') {
>x : Symbol(x, Decl(constructorOverloads9.ts, 3, 16))
this.a = x;
>this.a : Symbol(C.a, Decl(constructorOverloads9.ts, 0, 16))
>this : Symbol(C, Decl(constructorOverloads9.ts, 0, 0))
>a : Symbol(C.a, Decl(constructorOverloads9.ts, 0, 16))
>x : Symbol(x, Decl(constructorOverloads9.ts, 3, 16))
}
}

30
tests/baselines/reference/constructorOverloads9.types Normal file
View File

@@ -0,0 +1,30 @@
//// [tests/cases/compiler/constructorOverloads9.ts] ////
=== constructorOverloads9.ts ===
export class C {
>C : C
> : ^
a;
>a : any
constructor();
constructor(x = '') {
>x : string
> : ^^^^^^
>'' : ""
> : ^^
this.a = x;
>this.a = x : string
> : ^^^^^^
>this.a : any
>this : this
> : ^^^^
>a : any
> : ^^^
>x : string
> : ^^^^^^
}
}

8
tests/cases/compiler/constructorOverloads9.ts Normal file
View File

@@ -0,0 +1,8 @@
// @target: esnext
export class C {
a;
constructor();
constructor(x = '') {
this.a = x;
}
}