microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-07-02 14:48:32 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Uncomment tests fixed with #23631 (#26700)

Browse Source
This commit is contained in:
Andy
2018-08-28 10:25:00 -07:00
committed by GitHub
parent 1b1ca9ebf0
commit 1b5de9d16e
6 changed files with 10 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/cases/fourslash/genericFunctionReturnType.ts
View File

@@ -8,8 +8,7 @@
////var /*2*/r = foo(/*1*/1, "");
////var /*4*/r2 = r(/*3*/"");
// TODO: GH##23631
// verify.signatureHelp({ marker: "1", text: "foo(x: number, y: string): (a: string) => number" });
verify.signatureHelp({ marker: "1", text: "foo(x: number, y: string): (a: string) => number" });
verify.quickInfoAt("2", "var r: (a: string) => number");

9
tests/cases/fourslash/genericFunctionSignatureHelp3.ts
View File

@@ -18,17 +18,14 @@
verify.signatureHelp(
{ marker: "1", text: "foo1(x: number, callback: (y1: {}) => number): void" },
// TODO: GH#23631
// { marker: "2", text: "foo2(x: number, callback: (y2: {}) => number): void" },
{ marker: "2", text: "foo2(x: number, callback: (y2: {}) => number): void" },
{ marker: "3", text: "callback(y3: {}): number" },
// TODO: GH#23631
// { marker: "4", text: "foo4(x: number, callback: (y4: string) => number): void" },
{ marker: "4", text: "foo4(x: number, callback: (y4: string) => number): void" },
{ marker: "5", text: "callback(y5: string): number" },
);
goTo.marker('6');
// TODO: GH#23631
// verify.signatureHelp({ text: "foo6(x: number, callback: (y6: {}) => number): void" });
verify.signatureHelp({ text: "foo6(x: number, callback: (y6: {}) => number): void" });
edit.insert('string>(null,null);'); // need to make this line parse so we can get reasonable LS answers to later tests
verify.signatureHelp({ marker: "7", text: "foo7(x: number, callback: (y7: {}) => number): void" });

3
tests/cases/fourslash/genericParameterHelp.ts
View File

@@ -14,8 +14,6 @@
////testFunction<, ,/*5*/>(null, null, null);
verify.signatureHelp(
// TODO: GH#23631
/*
{
marker: "1",
text: "testFunction<T extends IFoo, U, M extends IFoo>(a: T, b: U, c: M): M",
@@ -24,7 +22,6 @@ verify.signatureHelp(
parameterSpan: "T extends IFoo",
},
{ marker: "2", parameterName: "U", parameterSpan: "U" },
*/
{ marker: "3", parameterName: "a", parameterSpan: "a: any" },
{ marker: "4", parameterName: "M", parameterSpan: "M extends IFoo" },
{ marker: "5", parameterName: "M", parameterSpan: "M extends IFoo" },

9
tests/cases/fourslash/genericParameterHelpConstructorCalls.ts
View File

@@ -14,8 +14,6 @@
////new testClass<IFoo,/*constructor5*/IFoo,IFoo>(null, null, null)
verify.signatureHelp(
// TODO: GH#23631
/*
{
marker: "constructor1",
text: "testClass<T extends IFoo, U, M extends IFoo>(a: T, b: U, c: M): testClass<T, U, M>",
@@ -27,8 +25,7 @@ verify.signatureHelp(
parameterName: "U",
parameterSpan: "U",
},
*/
{ marker: "constructor3", parameterName: "T", parameterSpan: "T extends IFoo" },
{ marker: "constructor4", parameterName: "M", parameterSpan: "M extends IFoo" },
{ marker: "constructor5", parameterName: "U", parameterSpan: "U" },
{ marker: "constructor3", parameterName: "T", parameterSpan: "T extends IFoo" },
{ marker: "constructor4", parameterName: "M", parameterSpan: "M extends IFoo" },
{ marker: "constructor5", parameterName: "U", parameterSpan: "U" },
);

2
tests/cases/fourslash/genericParameterHelpTypeReferences.ts
View File

@@ -12,7 +12,7 @@
////class Bar<T> extends testClass</*type3*/
////var x : testClass<,, /*type4*/any>;
// TODO: GH#23631
// TODO: GH#26699
if (false) {
verify.signatureHelp(

7
tests/cases/fourslash/staticGenericOverloads1.ts
View File

@@ -13,11 +13,8 @@
verify.signatureHelp({ marker: "", overloadsCount: 2 });
edit.insert('a');
verify.signatureHelp({ overloadsCount: 2 });
// TODO: GH#23631
// verify.signatureHelp({ text: "B(v: A<number>): A<number>" });
verify.signatureHelp({ overloadsCount: 2, text: "B(v: A<number>): A<number>" });
edit.insert('); A.B(');
verify.signatureHelp({ overloadsCount: 2, text: "B(v: A<{}>): A<{}>" });
edit.insert('a');
// TODO: GH#23631
// verify.signatureHelp({ text: "B(v: A<number>): A<number>" });
verify.signatureHelp({ overloadsCount: 2, text: "B(v: A<number>): A<number>" });