microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-06 02:33:53 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(47788): forbid convertToMappedObjectType QF in invalid index signatures (#47798)

Browse Source
This commit is contained in:
Oleksandr T 2022-02-08 21:36:45 +02:00 committed by GitHub
parent 460908a478
commit 17b97ccc43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/services/codefixes/convertToMappedObjectType.ts
View File

@ -25,9 +25,12 @@ namespace ts.codefix {
interface Info { readonly indexSignature: IndexSignatureDeclaration; readonly container: FixableDeclaration; }
function getInfo(sourceFile: SourceFile, pos: number): Info | undefined {
const token = getTokenAtPosition(sourceFile, pos);
const indexSignature = cast(token.parent.parent, isIndexSignatureDeclaration);
if (isClassDeclaration(indexSignature.parent)) return undefined;
const container = isInterfaceDeclaration(indexSignature.parent) ? indexSignature.parent : cast(indexSignature.parent.parent, isTypeAliasDeclaration);
const indexSignature = tryCast(token.parent.parent, isIndexSignatureDeclaration);
if (!indexSignature) return undefined;
const container = isInterfaceDeclaration(indexSignature.parent) ? indexSignature.parent : tryCast(indexSignature.parent.parent, isTypeAliasDeclaration);
if (!container) return undefined;
return { indexSignature, container };
}

7
tests/cases/fourslash/codeFixConvertToMappedObjectType13.ts Normal file
View File

@ -0,0 +1,7 @@
/// <reference path='fourslash.ts' />
////let x: {
//// [p: ""]: string;
////}
verify.not.codeFixAvailable("fixConvertToMappedObjectType");