microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-14 16:56:06 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fixed widening errors locations in union-normalized object literal types (#58157)

Browse Source
This commit is contained in:
Mateusz Burzyński
2024-06-14 22:20:17 +02:00
committed by GitHub
parent 61ffce078b
commit 0ca1973d8f
5 changed files with 207 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/compiler/checker.ts
View File

@@ -25281,27 +25281,28 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
else {
for (const t of (type as UnionType).types) {
if (reportWideningErrorsInType(t)) {
errorReported = true;
}
errorReported ||= reportWideningErrorsInType(t);
}
}
}
if (isArrayOrTupleType(type)) {
else if (isArrayOrTupleType(type)) {
for (const t of getTypeArguments(type)) {
if (reportWideningErrorsInType(t)) {
errorReported = true;
}
errorReported ||= reportWideningErrorsInType(t);
}
}
if (isObjectLiteralType(type)) {
else if (isObjectLiteralType(type)) {
for (const p of getPropertiesOfObjectType(type)) {
const t = getTypeOfSymbol(p);
if (getObjectFlags(t) & ObjectFlags.ContainsWideningType) {
if (!reportWideningErrorsInType(t)) {
error(p.valueDeclaration, Diagnostics.Object_literal_s_property_0_implicitly_has_an_1_type, symbolToString(p), typeToString(getWidenedType(t)));
errorReported = reportWideningErrorsInType(t);
if (!errorReported) {
// we need to account for property types coming from object literal type normalization in unions
const valueDeclaration = p.declarations?.find(d => d.symbol.valueDeclaration?.parent === type.symbol.valueDeclaration);
if (valueDeclaration) {
error(valueDeclaration, Diagnostics.Object_literal_s_property_0_implicitly_has_an_1_type, symbolToString(p), typeToString(getWidenedType(t)));
errorReported = true;
}
}
errorReported = true;
}
}
}