microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-12-12 11:50:54 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fixed widening errors locations in union-normalized object literal types (#58157)

Browse Source
This commit is contained in:
Mateusz Burzyński 2024-06-14 22:20:17 +02:00 committed by GitHub
parent 61ffce078b
commit 0ca1973d8f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 207 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/compiler/checker.ts
View File

@ -25281,27 +25281,28 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
else {
for (const t of (type as UnionType).types) {
if (reportWideningErrorsInType(t)) {
errorReported = true;
}
errorReported ||= reportWideningErrorsInType(t);
}
}
}
if (isArrayOrTupleType(type)) {
else if (isArrayOrTupleType(type)) {
for (const t of getTypeArguments(type)) {
if (reportWideningErrorsInType(t)) {
errorReported = true;
}
errorReported ||= reportWideningErrorsInType(t);
}
}
if (isObjectLiteralType(type)) {
else if (isObjectLiteralType(type)) {
for (const p of getPropertiesOfObjectType(type)) {
const t = getTypeOfSymbol(p);
if (getObjectFlags(t) & ObjectFlags.ContainsWideningType) {
if (!reportWideningErrorsInType(t)) {
error(p.valueDeclaration, Diagnostics.Object_literal_s_property_0_implicitly_has_an_1_type, symbolToString(p), typeToString(getWidenedType(t)));
errorReported = reportWideningErrorsInType(t);
if (!errorReported) {
// we need to account for property types coming from object literal type normalization in unions
const valueDeclaration = p.declarations?.find(d => d.symbol.valueDeclaration?.parent === type.symbol.valueDeclaration);
if (valueDeclaration) {
error(valueDeclaration, Diagnostics.Object_literal_s_property_0_implicitly_has_an_1_type, symbolToString(p), typeToString(getWidenedType(t)));
errorReported = true;
}
}
errorReported = true;
}
}
}

32
tests/baselines/reference/noImplicitAnyUnionNormalizedObjectLiteral1.errors.txt Normal file
View File

@ -0,0 +1,32 @@
noImplicitAnyUnionNormalizedObjectLiteral1.ts(16,3): error TS7018: Object literal's property 'p' implicitly has an 'any' type.
noImplicitAnyUnionNormalizedObjectLiteral1.ts(17,3): error TS7018: Object literal's property 's' implicitly has an 'any' type.
==== noImplicitAnyUnionNormalizedObjectLiteral1.ts (2 errors) ====
// https://github.com/microsoft/TypeScript/issues/58150
function doSthWithParams(params: unknown) {
if (typeof params !== "object") {
return {};
}
return {
c: "foo",
p: "bar",
s: "baz",
};
}
const bar = {
p: null,
~~~~~~~
!!! error TS7018: Object literal's property 'p' implicitly has an 'any' type.
s: null,
~~~~~~~
!!! error TS7018: Object literal's property 's' implicitly has an 'any' type.
...doSthWithParams({
p: "hello",
s: "world",
}),
};

49
tests/baselines/reference/noImplicitAnyUnionNormalizedObjectLiteral1.symbols Normal file
View File

@ -0,0 +1,49 @@
//// [tests/cases/compiler/noImplicitAnyUnionNormalizedObjectLiteral1.ts] ////
=== noImplicitAnyUnionNormalizedObjectLiteral1.ts ===
// https://github.com/microsoft/TypeScript/issues/58150
function doSthWithParams(params: unknown) {
>doSthWithParams : Symbol(doSthWithParams, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 0, 0))
>params : Symbol(params, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 2, 25))
if (typeof params !== "object") {
>params : Symbol(params, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 2, 25))
return {};
}
return {
c: "foo",
>c : Symbol(c, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 7, 10))
p: "bar",
>p : Symbol(p, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 8, 13))
s: "baz",
>s : Symbol(s, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 9, 13))
};
}
const bar = {
>bar : Symbol(bar, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 14, 5))
p: null,
>p : Symbol(p, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 14, 13))
s: null,
>s : Symbol(s, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 15, 10))
...doSthWithParams({
>doSthWithParams : Symbol(doSthWithParams, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 0, 0))
p: "hello",
>p : Symbol(p, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 17, 22))
s: "world",
>s : Symbol(s, Decl(noImplicitAnyUnionNormalizedObjectLiteral1.ts, 18, 15))
}),
};

88
tests/baselines/reference/noImplicitAnyUnionNormalizedObjectLiteral1.types Normal file
View File

@ -0,0 +1,88 @@
//// [tests/cases/compiler/noImplicitAnyUnionNormalizedObjectLiteral1.ts] ////
=== noImplicitAnyUnionNormalizedObjectLiteral1.ts ===
// https://github.com/microsoft/TypeScript/issues/58150
function doSthWithParams(params: unknown) {
>doSthWithParams : (params: unknown) => { c?: undefined; p?: undefined; s?: undefined; } | { c: string; p: string; s: string; }
> : ^ ^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>params : unknown
> : ^^^^^^^
if (typeof params !== "object") {
>typeof params !== "object" : boolean
> : ^^^^^^^
>typeof params : "string" | "number" | "bigint" | "boolean" | "symbol" | "undefined" | "object" | "function"
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>params : unknown
> : ^^^^^^^
>"object" : "object"
> : ^^^^^^^^
return {};
>{} : {}
> : ^^
}
return {
>{ c: "foo", p: "bar", s: "baz", } : { c: string; p: string; s: string; }
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
c: "foo",
>c : string
> : ^^^^^^
>"foo" : "foo"
> : ^^^^^
p: "bar",
>p : string
> : ^^^^^^
>"bar" : "bar"
> : ^^^^^
s: "baz",
>s : string
> : ^^^^^^
>"baz" : "baz"
> : ^^^^^
};
}
const bar = {
>bar : { c?: undefined; p: any; s: any; } | { c: string; p: string; s: string; }
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>{ p: null, s: null, ...doSthWithParams({ p: "hello", s: "world", }),} : { c?: undefined; p: null; s: null; } | { c: string; p: string; s: string; }
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
p: null,
>p : null
> : ^^^^
s: null,
>s : null
> : ^^^^
...doSthWithParams({
>doSthWithParams({ p: "hello", s: "world", }) : { c?: undefined; p?: undefined; s?: undefined; } | { c: string; p: string; s: string; }
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>doSthWithParams : (params: unknown) => { c?: undefined; p?: undefined; s?: undefined; } | { c: string; p: string; s: string; }
> : ^ ^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>{ p: "hello", s: "world", } : { p: string; s: string; }
> : ^^^^^^^^^^^^^^^^^^^^^^^^^
p: "hello",
>p : string
> : ^^^^^^
>"hello" : "hello"
> : ^^^^^^^
s: "world",
>s : string
> : ^^^^^^
>"world" : "world"
> : ^^^^^^^
}),
};

26
tests/cases/compiler/noImplicitAnyUnionNormalizedObjectLiteral1.ts Normal file
View File

@ -0,0 +1,26 @@
// @strictNullChecks: false
// @noImplicitAny: true
// @noEmit: true
// https://github.com/microsoft/TypeScript/issues/58150
function doSthWithParams(params: unknown) {
if (typeof params !== "object") {
return {};
}
return {
c: "foo",
p: "bar",
s: "baz",
};
}
const bar = {
p: null,
s: null,
...doSthWithParams({
p: "hello",
s: "world",
}),
};