microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-17 01:49:41 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

test cases

Browse Source
This commit is contained in:
Pranav Senthilnathan (from Dev Box)
2023-10-25 11:51:46 -07:00
parent b2b138fe2f
commit 00303d53fe
3 changed files with 370 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/completions.ts
View File

@@ -3769,7 +3769,7 @@ function getCompletionData(
function createComputedPropertyAccess(nameSymbol: Symbol, leftMostNameSymbol: Symbol, computedPropertyNameExpression: Expression) {
let node: Node | undefined;
if (!isTransientSymbol(nameSymbol)) {
node = typeChecker.symbolToEntityName(nameSymbol, /*meaning*/ undefined!, contextToken, NodeBuilderFlags.UseAliasDefinedOutsideCurrentScope);
node = typeChecker.symbolToNode(nameSymbol, /*meaning*/ undefined!, contextToken, NodeBuilderFlags.UseAliasDefinedOutsideCurrentScope);
}
else {
// Object literals assigned as const

303
tests/baselines/reference/completionsDotComputedPropertyEnum3.baseline Normal file
View File

@@ -0,0 +1,303 @@
=== /tests/cases/fourslash/completionsDotComputedPropertyEnum3.ts ===
// /**
// * Mimicking rxjs to avoid dependency import
// */
//
// type Observable<X> = {
// subscribe(): Observable<X>
// };
//
// enum CPEvents {
// CLICK = "click",
// EMSG = "emsg",
// }
//
// // Payloads have been replaced for the repro-case, but they do not matter right now.
// interface CPMappedEvents {
// [CPEvents.EMSG]: unknown;
// }
//
// type CPUnmappedEvents = {
// [K in Exclude<CPEvents, keyof CPMappedEvents>]: Event;
// };
//
// export type CPEventsMap = CPMappedEvents & CPUnmappedEvents;
//
// export type CPObservableEvents = {
// [K in keyof CPEventsMap]: Observable<CPEventsMap[K]>;
// };
//
// declare const eventObservables: CPObservableEvents;
// eventObservables.;
// ^
// | ----------------------------------------------------------------------
// | (property) click: Observable<Event>
// | (enum member) CPEvents.EMSG = "emsg"
// | ----------------------------------------------------------------------
// eventObservables[''];
//
// | ----------------------------------------------------------------------
// | (property) click: Observable<Event>
// | (property) [CPEvents.EMSG]: Observable<unknown>
// | ----------------------------------------------------------------------
[
{
"marker": {
"fileName": "/tests/cases/fourslash/completionsDotComputedPropertyEnum3.ts",
"position": 616,
"name": "a"
},
"item": {
"flags": 0,
"isGlobalCompletion": false,
"isMemberCompletion": true,
"isNewIdentifierLocation": false,
"entries": [
{
"name": "click",
"kind": "property",
"kindModifiers": "",
"sortText": "11",
"displayParts": [
{
"text": "(",
"kind": "punctuation"
},
{
"text": "property",
"kind": "text"
},
{
"text": ")",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "click",
"kind": "propertyName"
},
{
"text": ":",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "Observable",
"kind": "aliasName"
},
{
"text": "<",
"kind": "punctuation"
},
{
"text": "Event",
"kind": "text"
},
{
"text": ">",
"kind": "punctuation"
}
],
"documentation": []
},
{
"name": "CPEvents.EMSG",
"kind": "enum member",
"kindModifiers": "",
"sortText": "11",
"insertText": "[CPEvents.EMSG]",
"replacementSpan": {
"start": 615,
"length": 1
},
"displayParts": [
{
"text": "(",
"kind": "punctuation"
},
{
"text": "enum member",
"kind": "text"
},
{
"text": ")",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "CPEvents",
"kind": "enumName"
},
{
"text": ".",
"kind": "punctuation"
},
{
"text": "EMSG",
"kind": "enumMemberName"
},
{
"text": " ",
"kind": "space"
},
{
"text": "=",
"kind": "operator"
},
{
"text": " ",
"kind": "space"
},
{
"text": "\"emsg\"",
"kind": "stringLiteral"
}
],
"documentation": []
}
]
}
},
{
"marker": {
"fileName": "/tests/cases/fourslash/completionsDotComputedPropertyEnum3.ts",
"position": 636,
"name": "b"
},
"item": {
"isGlobalCompletion": false,
"isMemberCompletion": true,
"isNewIdentifierLocation": false,
"optionalReplacementSpan": {
"start": 636,
"length": 0
},
"entries": [
{
"name": "click",
"kind": "property",
"kindModifiers": "",
"sortText": "11",
"replacementSpan": {
"start": 636,
"length": 0
},
"displayParts": [
{
"text": "(",
"kind": "punctuation"
},
{
"text": "property",
"kind": "text"
},
{
"text": ")",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "click",
"kind": "propertyName"
},
{
"text": ":",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "Observable",
"kind": "aliasName"
},
{
"text": "<",
"kind": "punctuation"
},
{
"text": "Event",
"kind": "text"
},
{
"text": ">",
"kind": "punctuation"
}
],
"documentation": []
},
{
"name": "emsg",
"kind": "property",
"kindModifiers": "",
"sortText": "11",
"replacementSpan": {
"start": 636,
"length": 0
},
"displayParts": [
{
"text": "(",
"kind": "punctuation"
},
{
"text": "property",
"kind": "text"
},
{
"text": ")",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "[CPEvents.EMSG]",
"kind": "propertyName"
},
{
"text": ":",
"kind": "punctuation"
},
{
"text": " ",
"kind": "space"
},
{
"text": "Observable",
"kind": "aliasName"
},
{
"text": "<",
"kind": "punctuation"
},
{
"text": "unknown",
"kind": "keyword"
},
{
"text": ">",
"kind": "punctuation"
}
],
"documentation": []
}
]
}
}
]

66
tests/cases/fourslash/completionsDotComputedPropertyEnum3.ts Normal file
View File

@@ -0,0 +1,66 @@
/// <reference path="fourslash.ts" />
// Make sure completion shows fully qualified names for enum members
// and literals for mapped proeprties keyed with string literals
/////**
//// * Mimicking rxjs to avoid dependency import
//// */
////
////type Observable<X> = {
//// subscribe(): Observable<X>
////};
////
////enum CPEvents {
//// CLICK = "click",
//// EMSG = "emsg",
////}
////
////// Payloads have been replaced for the repro-case, but they do not matter right now.
////interface CPMappedEvents {
//// [CPEvents.EMSG]: unknown;
////}
////
////type CPUnmappedEvents = {
//// [K in Exclude<CPEvents, keyof CPMappedEvents>]: Event;
////};
////
////export type CPEventsMap = CPMappedEvents & CPUnmappedEvents;
////
////export type CPObservableEvents = {
//// [K in keyof CPEventsMap]: Observable<CPEventsMap[K]>;
////};
////
////declare const eventObservables: CPObservableEvents;
////eventObservables./*a*/;
////eventObservables['/*b*/'];
verify.completions({
marker: "a",
unsorted: [
{ name: "click" },
{ name: "CPEvents.EMSG", insertText: "[CPEvents.EMSG]" },
],
preferences: { includeCompletionsWithInsertText: true }
});
verify.completions({
marker: "a",
unsorted: [
{ name: "click" },
{ name: "emsg" },
],
preferences: { includeCompletionsWithInsertText: false }
});
verify.completions({
marker: "b",
unsorted: [
{ name: "click" },
{ name: "emsg" },
]
});
verify.baselineCompletions({
includeCompletionsWithInsertText: true,
});