mirror of
https://github.com/home-assistant/iOS.git
synced 2026-04-17 08:05:44 -05:00
<!-- Thank you for submitting a Pull Request and helping to improve Home Assistant. Please complete the following sections to help the processing and review of your changes. Please do not delete anything from this template. --> ## Summary <!-- Provide a brief summary of the changes you have made and most importantly what they aim to achieve --> Fixes three distinct crashes in the widget extension process that cause widgets to go blank and not recover until the app is reinstalled. - **ServerCache precondition crash** — `ServerCache.info.didSet` uses a `precondition` that reads `deletedServers` from shared UserDefaults on every check. When the main app deletes a server, the widget's cached `info` dict still contains it, causing the precondition to fail on the next mutation. Replaced with an error log, matching the existing pattern for the `server` dict. This was the most common crash (4 of 10 logs) and created a permanent crash loop only fixable by reinstalling. - **Thread-unsafe `cachedApis` dictionary** — `AppEnvironment.cachedApis` is a plain dictionary accessed concurrently from multiple AppIntent threads (`ScriptAppIntent`, `SwitchIntent`), causing memory corruption. Added `NSLock` synchronization around all access. - **`fatalError` in GRDB initialization** — When `DatabaseQueue` fails to open the on-disk database (locked file, corruption, file protection), the widget extension calls `fatalError`. Replaced with a fallback to an in-memory database, matching Realm's existing pattern. ## Screenshots <!-- If this is a user-facing change not in the frontend, please include screenshots in light and dark mode. --> ## Link to pull request in Documentation repository <!-- Pull requests that add, change or remove functionality must have a corresponding pull request in the Companion App Documentation repository (https://github.com/home-assistant/companion.home-assistant). Please add the number of this pull request after the "#" --> Documentation: home-assistant/companion.home-assistant# ## Any other notes <!-- If there is any other information of note, like if this Pull Request is part of a bigger change, please include it here. -->
128 lines
4.8 KiB
Swift
128 lines
4.8 KiB
Swift
import Foundation
|
|
import GRDB
|
|
|
|
public extension DatabaseQueue {
|
|
// Following GRDB cocnurrency rules, we have just one database instance
|
|
// https://swiftpackageindex.com/groue/grdb.swift/v6.29.3/documentation/grdb/concurrency#Concurrency-Rules
|
|
static var appDatabase: DatabaseQueue = {
|
|
let database: DatabaseQueue
|
|
do {
|
|
database = try DatabaseQueue(path: databasePath())
|
|
#if targetEnvironment(simulator)
|
|
print("GRDB App database is stored at \(AppConstants.appGRDBFile.description)")
|
|
#endif
|
|
} catch {
|
|
Current.Log.error("Failed to initialize GRDB, error: \(error.localizedDescription)")
|
|
// Fallback to in-memory database so extensions don't crash
|
|
do {
|
|
database = try DatabaseQueue()
|
|
Current.Log.error("Using in-memory GRDB database as fallback")
|
|
} catch {
|
|
fatalError("Failed to create even an in-memory GRDB database: \(error.localizedDescription)")
|
|
}
|
|
}
|
|
|
|
setupSchema(database: database)
|
|
return database
|
|
}()
|
|
|
|
private static func setupSchema(database: DatabaseQueue) {
|
|
for table in DatabaseQueue.tables() {
|
|
do {
|
|
try table.createIfNeeded(database: database)
|
|
} catch {
|
|
let className = String(describing: type(of: table))
|
|
let errorMessage = "Failed create GRDB table \(className), error: \(error.localizedDescription)"
|
|
Current.clientEventStore.addEvent(ClientEvent(text: errorMessage, type: .database))
|
|
}
|
|
}
|
|
DatabaseQueue.deleteOldTables(database: database)
|
|
}
|
|
|
|
static func databasePath() -> String {
|
|
// Path for tests
|
|
if ProcessInfo.processInfo.environment["XCTestConfigurationFilePath"] != nil {
|
|
let tempDirectory = NSTemporaryDirectory()
|
|
return (tempDirectory as NSString).appendingPathComponent("test_database.sqlite")
|
|
} else {
|
|
// Path for App use
|
|
return AppConstants.appGRDBFile.path
|
|
}
|
|
}
|
|
|
|
internal static func tables() -> [DatabaseTableProtocol] {
|
|
[
|
|
HAppEntityTable(),
|
|
WatchConfigTable(),
|
|
CarPlayConfigTable(),
|
|
AssistPipelinesTable(),
|
|
ServerInfoMirrorTable(),
|
|
AppEntityRegistryListForDisplayTable(),
|
|
AppEntityRegistryTable(),
|
|
AppDeviceRegistryTable(),
|
|
AppPanelTable(),
|
|
CustomWidgetTable(),
|
|
AppAreaTable(),
|
|
HomeViewConfigurationTable(),
|
|
CameraListConfigurationTable(),
|
|
AssistConfigurationTable(),
|
|
KioskSettingsTable(),
|
|
]
|
|
}
|
|
|
|
internal static func deleteOldTables(database: DatabaseQueue) {
|
|
do {
|
|
/*
|
|
ClientEvent used to be saved in GRDB, but because of a problem of one process holding
|
|
lock on the database and causing crash 0xdead10cc now it is saved as a json file
|
|
More information: https://github.com/groue/GRDB.swift/issues/1626#issuecomment-2623927815
|
|
*/
|
|
try database.write { db in
|
|
try db.drop(table: GRDBDatabaseTable.clientEvent.rawValue)
|
|
}
|
|
} catch {
|
|
let errorMessage =
|
|
"Failed or not needed delete client event GRDB info, error: \(error.localizedDescription)"
|
|
Current.Log.verbose(errorMessage)
|
|
}
|
|
}
|
|
}
|
|
|
|
protocol DatabaseTableProtocol {
|
|
/// The name of the database table
|
|
var tableName: String { get }
|
|
|
|
/// The list of column names defined for this table
|
|
var definedColumns: [String] { get }
|
|
|
|
/// Creates the table if it doesn't exist, or migrates it if it does
|
|
func createIfNeeded(database: DatabaseQueue) throws
|
|
}
|
|
|
|
extension DatabaseTableProtocol {
|
|
/// Migrates the table by adding new columns and removing obsolete columns
|
|
func migrateColumns(database: DatabaseQueue) throws {
|
|
try database.write { db in
|
|
let existingColumns = try db.columns(in: tableName)
|
|
let definedColumnSet = Set(definedColumns)
|
|
|
|
// Add new columns that don't exist yet
|
|
for columnName in definedColumns {
|
|
let shouldCreateColumn = !existingColumns.contains { $0.name == columnName }
|
|
if shouldCreateColumn {
|
|
try db.alter(table: tableName) { tableAlteration in
|
|
tableAlteration.add(column: columnName)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Remove columns that are no longer defined
|
|
for existingColumn in existingColumns where !definedColumnSet.contains(existingColumn.name) {
|
|
try db.alter(table: tableName) { tableAlteration in
|
|
tableAlteration.drop(column: existingColumn.name)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|