git-for-windows/git
1
0
Fork 0
mirror of https://github.com/git-for-windows/git.git synced 2026-03-16 19:41:56 -05:00
Code Issues Packages Projects Releases 335 Wiki Activity

Avoid Coverity warning about unfree()d git_exec_path()

Browse Source 
Technically, it is correct that git_exec_path() returns a possibly
malloc()ed string. Practically, it is *sometimes* not malloc()ed. So
let's just use a static variable to make it a singleton. That'll shut
Coverity up, hopefully.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2016-11-30 17:39:37 +01:00
parent 5c76d3ceb2
commit cd00deccd1
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
exec_cmd.c
View File

@@ -65,6 +65,7 @@ void git_set_argv_exec_path(const char *exec_path)
const char *git_exec_path(void)
{
const char *env;
static char *system_exec_path;
if (argv_exec_path)
return argv_exec_path;
@@ -74,7 +75,9 @@ const char *git_exec_path(void)
return env;
}
return system_path(GIT_EXEC_PATH);
if (!system_exec_path)
system_exec_path = system_path(GIT_EXEC_PATH);
return system_exec_path;
}
static void add_path(struct strbuf *out, const char *path)