git-for-windows/git
1
0
Fork 0
mirror of https://github.com/git-for-windows/git.git synced 2026-03-31 11:31:50 -05:00
Code Issues Packages Projects Releases 335 Wiki Activity

mingw: be more informative when ownership check fails on FAT32

Browse Source 
The FAT file system has no concept of ACLs. Therefore, it cannot store
any ownership information anyway, and the `GetNamedSecurityInfoW()` call
pretends that everything is owned "by the world".

Let's special-case that scenario and tell the user what's going on, at
least when they set `GIT_TEST_DEBUG_UNSAFE_DIRECTORIES`.

This addresses https://github.com/git-for-windows/git/issues/3886

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin
2022-06-08 11:56:03 +02:00
parent e8e6aa08f7
commit 793c2bbc1c
1 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
compat/mingw.c
View File

@@ -2674,6 +2674,22 @@ static PSID get_current_user_sid(void)
return result;
}
static int acls_supported(const char *path)
{
size_t offset = offset_1st_component(path);
WCHAR wroot[MAX_PATH];
DWORD file_system_flags;
if (offset &&
xutftowcs_path_ex(wroot, path, MAX_PATH, offset,
MAX_PATH, 0) > 0 &&
GetVolumeInformationW(wroot, NULL, 0, NULL, NULL,
&file_system_flags, NULL, 0))
return !!(file_system_flags & FILE_PERSISTENT_ACLS);
return 0;
}
int is_path_owned_by_current_sid(const char *path)
{
WCHAR wpath[MAX_PATH];
@@ -2731,7 +2747,14 @@ int is_path_owned_by_current_sid(const char *path)
* okay, too.
*/
result = 1;
else if (git_env_bool("GIT_TEST_DEBUG_UNSAFE_DIRECTORIES", 0)) {
else if (IsWellKnownSid(sid, WinWorldSid) &&
git_env_bool("GIT_TEST_DEBUG_UNSAFE_DIRECTORIES", 0) &&
!acls_supported(path)) {
/*
* On FAT32 volumes, ownership is not actually recorded.
*/
warning("'%s' is on a file system that does not record ownership", path);
} else if (git_env_bool("GIT_TEST_DEBUG_UNSAFE_DIRECTORIES", 0)) {
LPSTR str1, str2, to_free1 = NULL, to_free2 = NULL;
if (ConvertSidToStringSidA(sid, &str1))