Compare commits

...

5 Commits

Author SHA1 Message Date
Joe Previte
0f66360646 fix: keep product.json file permissions in release
When we added the change to modify the `package.json` version using `mv`
and `jq` we didn't account for lost file permissions.

This caused a bug only happening in CI.

This should fix it by giving it 755 via `chmod`.
2022-12-02 11:03:20 -07:00
Joe Previte
130f52e6b7 chore: increase timeout 2022-12-01 12:28:58 -07:00
Joe Previte
c9279ccbe4 Merge branch 'main' into release/v4.9.0 2022-12-01 11:07:47 -07:00
Joe Previte
fc4d2b532f fix: add +x to product.json in build-vscode
While testing a pre-release, there seems to be a bug with the file
permissions for `product.json`. Adding `chmod +x` to see if that fixes
it.
2022-12-01 10:19:47 -07:00
Joe Previte
df49838739 chore: add VERSION check in build-vscode.sh (#5823) 2022-12-01 11:51:07 -05:00
3 changed files with 11 additions and 1 deletions

View File

@@ -296,7 +296,7 @@ jobs:
name: Run e2e tests
needs: build
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 25
steps:
- name: Checkout repo
uses: actions/checkout@v3

View File

@@ -322,6 +322,8 @@ jobs:
echo "Updating version in lib/vscode/product.json"
tmp=$(mktemp)
jq '.codeServerVersion = "$VERSION"' release/lib/vscode/product.json > "$tmp" && mv "$tmp" release/lib/vscode/product.json
# Ensure it has the same permissions as before
chmod 755 release/lib/vscode/product.json
- name: Compress release package
run: tar -czf package.tar.gz release

View File

@@ -42,6 +42,12 @@ main() {
pushd lib/vscode
if [[ ! ${VERSION-} ]]; then
echo "VERSION not set. Please set before running this script:"
echo "VERSION='0.0.0' yarn build:vscode"
exit 1
fi
# Set the commit Code will embed into the product.json. We need to do this
# since Code tries to get the commit from the `.git` directory which will fail
# as it is a submodule.
@@ -90,6 +96,8 @@ main() {
EOF
) > product.json
chmod +x product.json
# Any platform here works since we will do our own packaging. We have to do
# this because we have an NPM package that could be installed on any platform.
# The correct platform dependencies and scripts will be installed as part of