refactor: warn plugin range incompatibble

This reverts commit 5d70994f22.

CHANGELOG.md

@@ -20,15 +20,7 @@ Code v99.99.999
 
 -->
 
-## [4.8.3](https://github.com/coder/code-server/releases/tag/v4.8.3) - 2022-11-07
-
-Code v1.72.1
-
-### Changed
-
-- Updated text in the Getting Started page.
-
-## [4.8.2](https://github.com/coder/code-server/releases/tag/v4.8.2) - 2022-11-02
+## [4.8.2-rc.1](https://github.com/coder/code-server/releases/tag/v4.8.2-rc.1) - 2022-11-01
 
 Code v1.72.1
 

ci/helm-chart/Chart.yaml

@@ -15,9 +15,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 3.3.3
+version: 3.3.1
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 4.8.3
+appVersion: 4.8.1

ci/helm-chart/values.yaml

@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: codercom/code-server
-  tag: '4.8.3'
+  tag: '4.8.1'
   pullPolicy: Always
 
 # Specifies one or more secrets to be used when pulling images from a

flake.nix

@@ -12,13 +12,13 @@
         in {
           devShells.default = pkgs.mkShell {
             nativeBuildInputs = with pkgs; [
-              nodejs yarn' python pkg-config git rsync jq moreutils quilt bats
+              nodejs yarn' python pkg-config git rsync jq moreutils
             ];
             buildInputs = with pkgs; (lib.optionals (!stdenv.isDarwin) [ libsecret ]
                           ++ (with xorg; [ libX11 libxkbfile ])
-                          ++ lib.optionals stdenv.isDarwin (with pkgs.darwin.apple_sdk.frameworks; [ 
-                            AppKit Cocoa CoreServices Security xcbuild
-                          ]));
+                          ++ lib.optionals stdenv.isDarwin [
+                            AppKit Cocoa CoreServices Security cctools xcbuild
+                          ]);
           };
         }
       );

install.sh

@@ -131,11 +131,6 @@ Or, if you don't want/need a background service you can run:
 EOF
 }
 
-echo_coder_postinstall() {
-  echoh
-  echoh "Deploy code-server for your team with Coder: https://github.com/coder/coder"
-}
-
 main() {
   if [ "${TRACE-}" ]; then
     set -x
@@ -248,7 +243,6 @@ main() {
   if [ "$METHOD" = standalone ]; then
     if has_standalone; then
       install_standalone
-      echo_coder_postinstall
       exit 0
     else
       echoerr "There are no standalone releases for $ARCH"
@@ -292,8 +286,6 @@ main() {
       npm_fallback install_standalone
       ;;
   esac
-
-  echo_coder_postinstall
 }
 
 parse_arg() {
@@ -490,7 +482,7 @@ os() {
 # - amzn, centos, rhel, fedora, ... -> fedora
 # - opensuse-{leap,tumbleweed} -> opensuse
 # - alpine -> alpine
-# - arch, manjaro, endeavouros, ... -> arch
+# - arch -> arch
 #
 # Inspired by https://github.com/docker/docker-install/blob/26ff363bcf3b3f5a00498ac43694bf1c7d9ce16c/install.sh#L111-L120.
 distro() {
@@ -504,7 +496,7 @@ distro() {
       . /etc/os-release
       if [ "${ID_LIKE-}" ]; then
         for id_like in $ID_LIKE; do
-          case "$id_like" in debian | fedora | opensuse | arch)
+          case "$id_like" in debian | fedora | opensuse)
             echo "$id_like"
             return
             ;;

package.json

@@ -1,7 +1,7 @@
 {
   "name": "code-server",
   "license": "MIT",
-  "version": "4.8.3",
+  "version": "4.8.2-rc.1",
   "description": "Run VS Code on a remote server.",
   "homepage": "https://github.com/coder/code-server",
   "bugs": {

patches/getting-started.diff

@@ -10,7 +10,7 @@ Index: code-server/lib/vscode/src/vs/workbench/contrib/welcomeGettingStarted/bro
 ===================================================================
 --- code-server.orig/lib/vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts
 +++ code-server/lib/vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts
-@@ -62,7 +62,7 @@ import { GettingStartedIndexList } from
+@@ -62,7 +62,7 @@ import { GettingStartedIndexList } from 
  import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
  import { KeyCode } from 'vs/base/common/keyCodes';
  import { getTelemetryLevel } from 'vs/platform/telemetry/common/telemetryUtils';
@@ -19,106 +19,32 @@ Index: code-server/lib/vscode/src/vs/workbench/contrib/welcomeGettingStarted/bro
  import { OpenFolderViaWorkspaceAction } from 'vs/workbench/browser/actions/workspaceActions';
  import { OpenRecentAction } from 'vs/workbench/browser/actions/windowActions';
  import { Toggle } from 'vs/base/browser/ui/toggle/toggle';
-@@ -758,6 +758,72 @@ export class GettingStartedPage extends
+@@ -753,11 +753,24 @@ export class GettingStartedPage extends 
+ 			onShowOnStartupChanged();
+ 		}));
+ 
+-		const header = $('.header', {},
++		let header = $('.header', {},
+ 			$('h1.product-name.caption', {}, this.productService.nameLong),
  			$('p.subtitle.description', {}, localize({ key: 'gettingStarted.editingEvolved', comment: ['Shown as subtitle on the Welcome page.'] }, "Editing evolved"))
  		);
  
-+		let gettingStartedCoder: HTMLElement = $('.header', {});
 +		if (this.contextService.contextMatchesRules(IsEnabledCoderGettingStarted)) {
-+			gettingStartedCoder = $('.gettingStartedCategory', {},
-+				$('h2', {
-+					style: 'margin-bottom: 12px',
-+				}, 'Next Up'),
-+				$('a', {
-+					href: 'https://cdr.co/code-server-to-coder',
-+					target: '_blank',
-+				},
-+					$('button', {
-+						style: [
-+							'padding: 10px 16px	',
-+							'border-radius: 4px',
-+							'background: linear-gradient(94.04deg, #7934DA 0%, #4D52E0 101.2%)',
-+							'color: white',
-+							'overflow: hidden',
-+							'margin-right: 14px',
-+						].join(';'),
-+					},
-+					$('h3', {
-+						style: [
-+							'margin: 0px 0px 6px',
-+							'font-weight: 500',
-+						].join(';'),
-+					}, 'Deploy code-server for your team'),
-+					$('p', {
-+						style: [
-+							'margin: 0',
-+							'font-size: 13px',
-+							'color: #dcdee2',
-+						].join(';'),
-+					}, 'Provision remote development environments on your infrastructure with Coder.'),
-+					$('p', {
-+						style: [
-+							'margin-top: 8px',
-+							'font-size: 13px',
-+							'color: #dcdee2',
-+						].join(';'),
-+					}, 'Coder is a self-service portal which provisions via Terraform—Linux, macOS, Windows, x86, ARM, and, of course, Kubernetes based infrastructure.'),
-+					$('p', {
-+						style: [
-+							'margin: 0',
-+							'margin-top: 8px',
-+							'font-size: 13px',
-+							'display: flex',
-+							'align-items: center',
-+						].join(';'),
-+					}, 'Get started ', $('span', {
-+						class: Codicon.arrowRight.classNames,
-+						style: [
-+							'color: white',
-+							'margin-left: 8px',
-+						].join(';'),
-+					})),
-+					$('img', {
-+						src: './_static/src/browser/media/templates.png',
-+						style: [
-+							'margin-bottom: -65px',
-+						].join(';'),
-+					}),
-+					),
-+				),
-+			);
++			header = $('.header', {},
++			   $('h1.product-name.caption', {}, this.productService.nameLong),
++			   $('p.subtitle.description.coder', {},
++				   "Using code-server on a team?",
++			   ),
++			   $('p.subtitle.description.coder-coder', {},
++				   "Check out: ",
++				   $('a', { href: "https://github.com/coder/coder" }, "coder/coder")
++			   ),
++		   );
 +	   }
 +
  
  		const leftColumn = $('.categories-column.categories-column-left', {},);
  		const rightColumn = $('.categories-column.categories-column-right', {},);
-@@ -775,13 +841,23 @@ export class GettingStartedPage extends
- 		const layoutLists = () => {
- 			if (gettingStartedList.itemCount) {
- 				this.container.classList.remove('noWalkthroughs');
--				reset(leftColumn, startList.getDomElement(), recentList.getDomElement());
--				reset(rightColumn, gettingStartedList.getDomElement());
-+				if (this.contextService.contextMatchesRules(IsEnabledCoderGettingStarted)) {
-+					reset(leftColumn, startList.getDomElement(), recentList.getDomElement(), gettingStartedList.getDomElement());
-+					reset(rightColumn, gettingStartedCoder);
-+				} else {
-+					reset(leftColumn, startList.getDomElement(), recentList.getDomElement());
-+					reset(rightColumn, gettingStartedList.getDomElement());
-+				}
-+
- 				recentList.setLimit(5);
- 			}
- 			else {
- 				this.container.classList.add('noWalkthroughs');
--				reset(leftColumn, startList.getDomElement());
-+				if (this.contextService.contextMatchesRules(IsEnabledCoderGettingStarted)) {
-+					reset(leftColumn, startList.getDomElement(), gettingStartedCoder);
-+				} else {
-+					reset(leftColumn, startList.getDomElement());
-+				}
- 				reset(rightColumn, recentList.getDomElement());
- 				recentList.setLimit(10);
- 			}
 Index: code-server/lib/vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/media/gettingStarted.css
 ===================================================================
 --- code-server.orig/lib/vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/media/gettingStarted.css

test/e2e/webview.test.ts

@@ -1,28 +0,0 @@
-import { promises as fs } from "fs"
-import * as path from "path"
-import { describe, test, expect } from "./baseFixture"
-
-describe("Webviews", ["--disable-workspace-trust"], {}, () => {
-  test("should preview a Markdown file", async ({ codeServerPage }) => {
-    // Create Markdown file
-    const heading = "Hello world"
-    const dir = await codeServerPage.workspaceDir
-    const file = path.join(dir, "text.md")
-    await fs.writeFile(file, `# ${heading}`)
-    await codeServerPage.openFile(file)
-
-    // Open Preview
-    await codeServerPage.executeCommandViaMenus("Markdown: Open Preview to the Side")
-    // Wait for the iframe to open and load
-    await codeServerPage.waitForTab(`Preview ${file}`)
-
-    // It's an iframe within an iframe
-    // so we have to do .frameLocator twice
-    const renderedText = await codeServerPage.page
-      .frameLocator("iframe.webview.ready")
-      .frameLocator("#active-frame")
-      .locator("text=Hello world")
-
-    expect(renderedText).toBeVisible
-  })
-})

test/scripts/install.bats

@@ -11,14 +11,14 @@ function should-use-deb() {
   DISTRO=$1 ARCH=$2 OS=linux run "$SCRIPT" --dry-run
   [ "$status" -eq 0 ]
   [ "${lines[1]}" = "Installing v$VERSION of the $2 deb package from GitHub." ]
-  [ "${lines[-6]}" = "deb package has been installed." ]
+  [ "${lines[-5]}" = "deb package has been installed." ]
 }
 
 function should-use-rpm() {
   DISTRO=$1 ARCH=$2 OS=linux run "$SCRIPT" --dry-run
   [ "$status" -eq 0 ]
   [ "${lines[1]}" = "Installing v$VERSION of the $2 rpm package from GitHub." ]
-  [ "${lines[-6]}" = "rpm package has been installed." ]
+  [ "${lines[-5]}" = "rpm package has been installed." ]
 }
 
 function should-fallback-npm() {
@@ -27,21 +27,21 @@ function should-fallback-npm() {
   [ "${lines[1]}" = "No standalone releases for $2." ]
   [ "${lines[2]}" = "Falling back to installation from npm." ]
   [ "${lines[3]}" = "Installing latest from npm." ]
-  [ "${lines[-6]}" = "npm package has been installed." ]
+  [ "${lines[-5]}" = "npm package has been installed." ]
 }
 
 function should-use-npm() {
   YARN_PATH=true DISTRO=$1 ARCH=$2 OS=linux run "$SCRIPT" --dry-run
   [ "$status" -eq 0 ]
   [ "${lines[1]}" = "Installing latest from npm." ]
-  [ "${lines[-6]}" = "npm package has been installed." ]
+  [ "${lines[-5]}" = "npm package has been installed." ]
 }
 
 function should-use-aur() {
   DISTRO=$1 ARCH=$2 OS=linux run "$SCRIPT" --dry-run
   [ "$status" -eq 0 ]
   [ "${lines[1]}" = "Installing latest from the AUR." ]
-  [ "${lines[-6]}" = "AUR package has been installed." ]
+  [ "${lines[-5]}" = "AUR package has been installed." ]
 }
 
 function should-fallback-npm-brew() {
@@ -52,21 +52,21 @@ function should-fallback-npm-brew() {
   [ "${lines[3]}" = "No standalone releases for $1." ]
   [ "${lines[4]}" = "Falling back to installation from npm." ]
   [ "${lines[5]}" = "Installing latest from npm." ]
-  [ "${lines[-6]}" = "npm package has been installed." ]
+  [ "${lines[-5]}" = "npm package has been installed." ]
 }
 
 function should-use-brew() {
   BREW_PATH=true OS=macos ARCH=$1 run "$SCRIPT" --dry-run
   [ "$status" -eq 0 ]
   [ "${lines[1]}" = "Installing latest from Homebrew." ]
-  [ "${lines[-4]}" = "Brew release has been installed." ]
+  [ "${lines[-3]}" = "Brew release has been installed." ]
 }
 
 function should-use-standalone() {
   DISTRO=$1 ARCH=$2 OS=$3 run "$SCRIPT" --method standalone --dry-run
   [ "$status" -eq 0 ]
   [ "${lines[1]}" = "Installing v$VERSION of the $2 release from GitHub." ]
-  [[ "${lines[-6]}" = "Standalone release has been installed"* ]]
+  [[ "${lines[-5]}" = "Standalone release has been installed"* ]]
 }
 
 @test "$SCRIPT_NAME: usage with --help" {
@@ -141,7 +141,7 @@ function should-use-standalone() {
   [ "${lines[1]}" = "Homebrew not installed." ]
   [ "${lines[2]}" = "Falling back to standalone installation." ]
   [ "${lines[3]}" = "Installing v$VERSION of the amd64 release from GitHub." ]
-  [[ "${lines[-6]}" = "Standalone release has been installed"* ]]
+  [[ "${lines[-5]}" = "Standalone release has been installed"* ]]
 }
 @test "$SCRIPT_NAME: macos i386 (no brew)" {
   should-fallback-npm-brew "i386"