TheAssassin
ce097235f2
Note for self: -O1+ strips out expressions surrounded by assert()
2018-11-23 18:05:56 +01:00
TheAssassin
b974f44ffd
Debug desktop file unit tests, mk.1
...
They're only broken on non-debug builds, so it's quite likely the
optimizations break the code.
2018-11-21 00:03:20 +01:00
TheAssassin
ecaeda4533
Deactivate unit tests that fail for no apparent reason on Travis CI
...
Will re-enable and debug them eventually. Right now, they prevent
binaries from being published, which is really a problem.
2018-11-19 22:25:20 +01:00
TheAssassin
ccfd05b5e0
Improve DesktopFile's comparison operators
2018-11-19 22:12:14 +01:00
TheAssassin
6cf9bc55a7
Fix comparison editor
2018-11-19 22:06:29 +01:00
TheAssassin
1e3e074f35
Properly copy desktop file reader
2018-11-19 22:06:08 +01:00
TheAssassin
7b16864dbe
Add missing return statement
2018-11-19 21:51:26 +01:00
TheAssassin
0b5ab2fc36
Fix return type of setter
2018-11-19 21:51:26 +01:00
TheAssassin
b3d0e7f20f
Merge pull request #57 from linuxdeploy/fix-plugin-detection
...
Fix plugin detection
2018-11-19 21:09:23 +01:00
TheAssassin
132931772c
Fix directory check
2018-11-19 20:52:45 +01:00
TheAssassin
6f7a2fd54a
Reduce verbosity of debug logging related to plugin detection
2018-11-19 20:50:09 +01:00
TheAssassin
c4258759b4
Make sure directories aren't falsely recognized as plugins
2018-11-19 20:48:04 +01:00
TheAssassin
786a24cb25
Fix CMake syntax
2018-11-16 00:25:27 +01:00
TheAssassin
35f1acf00d
Cleaning up coverage data after creating them makes no sense
...
The cleanup shall take place before running the test binaries which
create the new data, not afterwards.
2018-11-16 00:23:03 +01:00
TheAssassin
be0a891770
Improve test fixture names
2018-11-15 23:45:42 +01:00
TheAssassin
92a1370b30
Be able to use EXPECT_EQ with DesktopFile objects
...
GoogleTest internally uses operator==(first, second) instead of
first.operator==(second). By implementing the operators outside the
classes, GoogleTest can be made happy.
2018-11-15 23:36:04 +01:00
TheAssassin
541da1b573
Test (in)equality operators
2018-11-15 23:32:36 +01:00
TheAssassin
f274de8045
Make sure default keys don't overwrite existing ones
2018-11-15 21:24:08 +01:00
TheAssassin
6a951558ce
Use assert to check for impossible scenarios
2018-11-15 21:23:43 +01:00
TheAssassin
a4b13a1916
Clean up coverage data before new run
...
This makes sure that reports on subsequent runs are accurate.
2018-11-15 21:19:22 +01:00
TheAssassin
1c4e4a3888
Remove redundant setters/getters
2018-11-15 20:53:16 +01:00
TheAssassin
e4bf795211
No need for a string conversion operator
...
Doesn't make sense here anyway.
2018-11-15 20:44:43 +01:00
TheAssassin
e994eacfa0
Prevent unnecessary log messages in unit tests
2018-11-15 19:08:03 +01:00
TheAssassin
beb2ee15be
Don't use exceptions to detect abnormal behavior
...
https://isocpp.org/wiki/faq/exceptions#why-not-exceptions
2018-11-15 18:48:58 +01:00
TheAssassin
2e1a37ccf5
Fix path to test data
2018-11-15 18:05:08 +01:00
TheAssassin
520ac6de9b
Reduce amount of implicit behavior in desktop file parser
2018-11-15 18:03:46 +01:00
TheAssassin
1bcdcab057
Restructure desktop file tests, build single binary
2018-11-15 17:58:02 +01:00
TheAssassin
1d9c907ec3
Merge pull request #55 from linuxdeploy/test_desktopfile_parser_conformance
...
Test desktopfile parser conformance
2018-11-15 17:51:06 +01:00
TheAssassin
3e584f5551
Merge branch 'master' into test_desktopfile_parser_conformance
2018-11-15 17:21:23 +01:00
TheAssassin
f7975f1b80
Use return types with guaranteed sizes
...
This will ensure the conversions work equally on both 32-bit platforms
(int == long on 32-bit Linux systems, on 64 bit long > int).
2018-11-15 17:19:42 +01:00
TheAssassin
4af76a92c5
Fix duplicate key detection
2018-11-15 13:41:53 +01:00
TheAssassin
b6f5f371b6
Avoid copying data more often than necessary c
2018-11-15 13:40:22 +01:00
TheAssassin
d10e0614a1
Increase build speed of tests
2018-11-15 13:39:17 +01:00
TheAssassin
4ffa1a66ae
Improve code style
2018-11-15 13:22:41 +01:00
TheAssassin
9707b81931
Fix basic format header checks
2018-11-15 13:14:31 +01:00
TheAssassin
21b12cc6b6
Use EXPECT instead of ASSERT
2018-11-15 13:01:10 +01:00
TheAssassin
ae61f6b9d8
Update README.md
2018-11-15 01:35:09 +01:00
TheAssassin
b43b04f693
Check for valid and invalid keys (spec/basic format)
2018-11-15 01:29:14 +01:00
TheAssassin
61fb8bebdb
Fix execution of desktop file tests
2018-11-15 00:58:56 +01:00
TheAssassin
002ba4a496
Split two checks to make sure they're tested separately
...
Otherwise, one test case is always uncovered (either the first one
passes and the second one triggers, or the first one triggers and the
second one is never tested).
2018-11-14 11:22:38 +01:00
TheAssassin
244d82fede
Test behavior on lines with multiple = characters
2018-11-14 11:19:02 +01:00
TheAssassin
9f8121ebff
Check whether invalid lines are recognized
2018-11-14 11:16:35 +01:00
TheAssassin
80adfa8872
Recognize broken section headings, mk. 4
2018-11-14 11:14:24 +01:00
TheAssassin
4a07c8151e
Make sure errors are recognized in all sections, not just the first one
2018-11-14 11:10:34 +01:00
TheAssassin
ded20c162d
Recognize broken section headings, mk. 3
2018-11-14 10:59:17 +01:00
TheAssassin
bf152a509b
Recognize broken section headings, mk. 2
2018-11-14 10:46:48 +01:00
TheAssassin
dc8f446ca4
Recognize broken section headings, mk. 1
2018-11-14 10:41:47 +01:00
TheAssassin
fbc1d78122
Use custom exceptions for error handling
2018-11-14 10:31:41 +01:00
TheAssassin
9b2ff305e0
Merge pull request #52 from linuxdeploy/generate-coverage-reports
...
Generate coverage reports
2018-11-10 19:54:05 +01:00
TheAssassin
ee0acdb6f1
Patchelf is indeed also needed by the integration tests
2018-11-10 14:18:11 +01:00