mirror of
https://github.com/VSCodium/vscodium.git
synced 2026-04-09 20:50:20 -05:00
dont fetch online sourcemaps on runtime #714
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @milahu on GitHub.
Originally assigned to: @daiyam on GitHub.
Describe the bug
many javascript files in
lib/vscode/resources/have online sourcemapsexample:
this is unwanted because
Please confirm that this problem is VSCodium-specific
Please confirm that the issue/resolution isn't already documented
Additional context
Add any other context about the problem here.
on nixos linux ...
vscodium-online-sourcemaps.txt
@daiyam commented on GitHub:
To be useful, the sourcemaps need to hosted somewhere since MS don't include them since they would increase the install size of the app.
Since the url needs to be hardcoded, to use a local url would be difficult (for all systems). And the weight of those files can be an issue to include them adhoc.
It only an issue to debug vscode or one of its components.
@milahu commented on GitHub:
sourceMappingURLcan be a filename, then its relative to dirnamemaybe we can compress them as .js.map.gz?
but there is another problem ...
all URLs produce HTTP 404, because sourcemaps are only generated in macos builds, and there is no macos build for my vscode versions
https://github.com/microsoft/vscode/issues/39824
https://github.com/Microsoft/vscode/issues/43487
@milahu commented on GitHub:
... to
${workdir}/sourcemaps, but this fails in my casedebug console:
... caused by debugging an vscode extension (vscode-nix-ide)
@daiyam commented on GitHub:
@milahu yes, they are loaded only if you open the Developer Tools in the Help menu.
Should we keep them? I don't know.
@milahu commented on GitHub:
also some stack traces will (try to) fetch these sourcemaps
sourcemaps are useful for debugging,
so ideally, prefetch the sourcemaps on build, and patch the urls
@daiyam commented on GitHub:
Yeah, I forgot... it must be linked the BUILD_SOURCEVERSION which is now different between VSCode and VSCodium (due to the release number)
So a solution is needed, either remove them or find a solution to have them locally...
@Crystal-RainSlide commented on GitHub:
One may just turn off "Enable JavaScript source maps" in the Chromium Dev Tools settings:
This is
electron.devtools.preferences.jsSourceMapsEnabled: "true" | "false"(yes, string),in the
<user data directory, see this>/Preferencesfile, a JSON file without a proper.jsonsuffix.Since we have good reasons, maybe we can just preload this preference and tell user about this change somewhere.
But...
This is related to a larger topic: Should the Web Dev Tools fetch source maps automatically? Should source map errors be printed on the main console?
Personally, I want Dev Tools do nothing when I launch them, but fetch the source map when I inspect a source. The source map fetch errors should be printed to somewhere else, like Firefox's browser console. Maybe just leave one
infolevel message on the main console, to indicate there is source map error(s) on this Dev Tools instance.Source map is just for convenience, not essential. It shoule be fetched on demand, not unconditionally.
@daiyam commented on GitHub:
Maybe a script that do all of that??? Locate the app, get the version, download the maps and update the urls.... ???
Hum, Snap, AppImage and macOS might be an issue.
@GitMensch commented on GitHub:
Generating them with the CI build and ideally have them uploaded along with changing the URL.
Additional: a script that change the URLs to the home directory and the option to download them packed.
... wishful thinking ...
@daiyam commented on GitHub:
I know... but the app is installed at different locations. Unless if we can specify a standard location like the user profile or in the same directory as the extensions, it will be difficult.
Then, you will need to download a
tar.gzorzipfile and uncompress the maps to that location.@daiyam commented on GitHub:
+1
@github-actions[bot] commented on GitHub:
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!
@r3m0t commented on GitHub:
I think this needs to be an option- I can't debug my vscodium without these source maps, so they should be included. For the VSCodium that's downloadable on GitHub, we can assume nobody will use the source map so the sourceMappingURL line can be removed, or the domain name replaced with a
.invaliddomain.@github-actions[bot] commented on GitHub:
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!
@milahu commented on GitHub:
or you know... build vscodium from source #887 #420
one downside is the long build time
this could be reduced by replacing
tscwithswc, see also https://github.com/microsoft/vscode/pull/163660@milahu commented on GitHub:
still
@milahu commented on GitHub:
still an issue
@daiyam commented on GitHub:
+1
@github-actions[bot] commented on GitHub:
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!
@github-actions[bot] commented on GitHub:
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!