mirror of
https://github.com/Cleanuparr/Cleanuparr.git
synced 2026-02-04 12:21:33 -06:00
[BUG] Queue Cleaner does not blocklist release on 'Failed Import', causing re-download loop #19
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Molier on GitHub.
Before submitting a bug report, I have:
What is the behavior?
When the Queue Cleaner module identifies a download that Sonarr/Radarr cannot import (specifically "No files found are eligible for import" due to .iso/.exe files), it successfully removes the download from the download client. However, it does not appear to apply a blocklist to the release within the *arr application.
Immediately after deletion, Cleanuparr triggers a search, and the *arr application proceeds to re-download the exact same problematic release, creating an infinite loop. The Malware Blocker module, when it gets a chance to run, does correctly apply the blocklist. This suggests the blocklisting logic is missing or failing within the Queue Cleaner's "Failed Import" workflow.
What I expected to happen:
The Queue Cleaner, upon removing a failed download, should also add that release to the Sonarr/Radarr blocklist to prevent it from being downloaded again in the subsequent search.
Sonarr Log (immediately following the Cleanuparr search trigger):
Anything else?
this should perhaps be a feature request , for a boolean option to add to blocklist when queue remover hits import strikes: Currently, when the Queue Cleaner removes a download due to a "Failed Import" (e.g., the torrent only contains an .iso), it does not blocklist the release in Sonarr/Radarr. The subsequent search triggered by Cleanuparr often re-downloads the exact same problematic release, causing a loop. The Malware Blocker does correctly blocklist releases, but the Queue Cleaner often acts first on the "Failed Import" symptom. The current workaround is to add the import error message to the Queue Cleaner's "Ignored Patterns" to let the Malware Blocker handle it, but this is not immediately intuitive.
but i wanted to open the question since i was very confused by default behaviour
@Flaminel commented on GitHub:
No problem! If they had different hashes, then yes, they would be considered unique even though it's the exact same content inside them. Thank you for the update!
@Molier commented on GitHub:
i cannot verify perfectly since sonarr for some reason purged the history of the file. but i have this screenshot from when i was diagnosing, and if i recall , I figured out that all the releases were 'unique'.
As in, they were all brought in from separate trackers that i had set up i think and that's why it kept re-grabbing them perhaps? and every time it was malware so it got a strike and removed but only got banned after 3 strikes or something? and then it tried again, different tracker but actually same malware release perhaps.
But either way I have not seen the behavior reproduced so as far as I can see this can be closed :) . thank you for the follow up.
@magrhino commented on GitHub:
I believe I am having the same issue as well. Cleanuparr repeatedly deleted a private torrent on import from my seedbox due to a "failed import". I did have the box checked to ignore private torrents. It did not blacklist the torrent and continued to retry.
@Flaminel commented on GitHub:
@Molier ?
@Flaminel commented on GitHub:
Both
Malware BlockerandQueue Cleaneruse the same way to remove and block items from the queues and, as you can see here, items are always blocklisted. Given that there's no difference between them, are you 100% sureMalware Blockeractually did anything different?While it's pretty rare, it is possible that Sonarr does not blocklist some of the items, but I have no idea why and I can't fix that. The API call to do it should be correct.
@Flaminel commented on GitHub:
@magrhino there's no issue with Cleanuparr here.