starred/Cleanuparr-Cleanuparr
1
0
Fork 0
mirror of https://github.com/Cleanuparr/Cleanuparr.git synced 2026-02-04 12:21:33 -06:00
Code Issues 38 Packages Projects Releases 10 Wiki Activity

[BUG] Arr queue cleanup not working without DownloadClient #132

New Issue
Closed
opened 2025-10-09 16:58:56 -05:00 by giteasync · 4 comments
giteasync commented 2025-10-09 16:58:56 -05:00
Owner
Copy Link

Originally created by @pradumnk-mahanta on GitHub.

Before submitting a bug report, I have:

  • Reviewed the documentation.
  • Ensured I am using ghcr.io/flmorg/cleanuperr docker repository.
  • Ensured I am using the latest version.
  • Enabled debug logging.

What is the behavior?

Hi,

First of all, thank you for this wonderful tool. It is awesome.

So, the issue started with the new build only. Everything is working in version 1.5.10 for my use case. I am not sure if it If it is intended behaviour for the latest build, if it is, i will have to change my setup.

I use Arr Stack with RDTClient and my download manager. It mimics the qBittorrent API but does not support it fully. So, I cannot use it with Cleanupperr. So, I only use Cleanupperr for the queue cleaner.

For any failed to import downloads it would give a strike and remove it from the queue after 5 strikes.

However, since the build, 1.5.11 onwards, it is not working. It is skipping the failed imports by giving the reason, download client is not configured.

Which operating system do you use?

Linux

What type of deployment do you use?

Docker container

Relevant log output

Latest Build: 

[2025-03-19 23:45:00.000 WRN]  [DownloadCleaner] download client is set to none
[2025-03-19 23:45:00.000 WRN]  [ContentBlocker] download client is set to none
[2025-03-19 23:45:00.002 INF]    [QueueCleaner] [Sonarr] 4 items found in queue
[2025-03-19 23:45:00.002 WRN]    [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME1
[2025-03-19 23:45:00.002 WRN]    [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME3
[2025-03-19 23:45:00.002 WRN]    [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME3
[2025-03-19 23:45:00.002 WRN]    [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME4


V1.5.10

[2025-03-19 23:50:09.523 INF]    [QueueCleaner] [Sonarr] 4 items found in queue
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME1
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] skip | SOMETITLENAME1
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME2
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] skip | SOMETITLENAME2
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME3
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] skip | SOMETITLENAME3
[2025-03-19 23:50:09.524 INF]    [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME4
[2025-03-19 23:50:09.525 INF]    [QueueCleaner] [Sonarr] skip | SOMETITLENAME4

Anything else?

I believe it is because of this change,

Image

released as a part of PR #85

I am not sure, if this is intended behaviour for the future of this project or it is indeed a bug. For now, I have reverted back to v1.5.10.

I can assist with the fix if you can give me a background on the intended behaviour for the future of this.

Again, thank you so much for this awesome project.

Originally created by @pradumnk-mahanta on GitHub. ### Before submitting a bug report, I have: - [x] Reviewed the documentation. - [x] Ensured I am using ghcr.io/flmorg/cleanuperr docker repository. - [x] Ensured I am using the latest version. - [x] Enabled debug logging. ### What is the behavior? Hi, First of all, thank you for this wonderful tool. It is awesome. So, the issue started with the new build only. Everything is working in version 1.5.10 for my use case. I am not sure if it If it is intended behaviour for the latest build, if it is, i will have to change my setup. I use Arr Stack with RDTClient and my download manager. It mimics the qBittorrent API but does not support it fully. So, I cannot use it with Cleanupperr. So, I only use Cleanupperr for the queue cleaner. For any failed to import downloads it would give a strike and remove it from the queue after 5 strikes. However, since the build, 1.5.11 onwards, it is not working. It is skipping the failed imports by giving the reason, `download client is not configured`. ### Which operating system do you use? Linux ### What type of deployment do you use? Docker container ### Relevant log output ```shell Latest Build: [2025-03-19 23:45:00.000 WRN] [DownloadCleaner] download client is set to none [2025-03-19 23:45:00.000 WRN] [ContentBlocker] download client is set to none [2025-03-19 23:45:00.002 INF] [QueueCleaner] [Sonarr] 4 items found in queue [2025-03-19 23:45:00.002 WRN] [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME1 [2025-03-19 23:45:00.002 WRN] [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME3 [2025-03-19 23:45:00.002 WRN] [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME3 [2025-03-19 23:45:00.002 WRN] [QueueCleaner] [Sonarr] skip | download client is not configured | SOMETITLENAME4 V1.5.10 [2025-03-19 23:50:09.523 INF] [QueueCleaner] [Sonarr] 4 items found in queue [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME1 [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] skip | SOMETITLENAME1 [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME2 [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] skip | SOMETITLENAME2 [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME3 [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] skip | SOMETITLENAME3 [2025-03-19 23:50:09.524 INF] [QueueCleaner] [Sonarr] item on strike number 2 | reason ImportFailed | SOMETITLENAME4 [2025-03-19 23:50:09.525 INF] [QueueCleaner] [Sonarr] skip | SOMETITLENAME4 ``` ### Anything else? I believe it is because of this change, ![Image](https://github.com/user-attachments/assets/dd156113-95f4-46d6-aa44-0c4bdf609dd7) released as a part of [PR #85](https://github.com/flmorg/cleanuperr/pull/85/commits) I am not sure, if this is intended behaviour for the future of this project or it is indeed a bug. For now, I have reverted back to v1.5.10. I can assist with the fix if you can give me a background on the intended behaviour for the future of this. Again, thank you so much for this awesome project.
giteasync added the
bug
 label 2025-10-09 16:58:56 -05:00
giteasync commented 2025-10-09 16:58:59 -05:00
Author
Owner
Copy Link

@Flaminel commented on GitHub:

Hi!

First of all, thank you for this wonderful tool. It is awesome.

Thank you so much for the kind words!

Now about that not working anymore, it is intentional. This change was done because some people would use the queue cleaner, but would not configure the download client. Without the download client, cleanuperr can not know which downloads come from a private tracker and this resulted in people getting hit with H&Rs because private downloads would be removed completely. I did not realize this would be breaking RDT-Client, especially because #83 mentions that it doesn't work at all (maybe a different version?).

Long story short, this was done to guard people from misconfiguration that could result in getting their private tracker accounts banned. But I'm open to suggestions, so please let me know if you have any!

@Flaminel commented on GitHub: Hi! > First of all, thank you for this wonderful tool. It is awesome. Thank you so much for the kind words! Now about that not working anymore, it is intentional. This change was done because some people would use the queue cleaner, but would not configure the download client. Without the download client, cleanuperr can not know which downloads come from a private tracker and this resulted in people getting hit with H&Rs because private downloads would be removed completely. I did not realize this would be breaking RDT-Client, especially because #83 mentions that it doesn't work at all (maybe a different version?). Long story short, this was done to guard people from misconfiguration that could result in getting their private tracker accounts banned. But I'm open to suggestions, so please let me know if you have any!
giteasync commented 2025-10-09 16:58:59 -05:00
Author
Owner
Copy Link

@Flaminel commented on GitHub:

RDT Client does not work

Oh yeah, my bad on that one. I confused the way things work on cleanuperr.

I just released v1.5.13 which includes a new disabled option for the download client. At least that way the users explicitly state what they want to do. Please try it out and let me know how it goes!

As for RDT-Client, it is on my radar and I want to integrate it here, but unfortunately I didn't get the time to do it yet. Any help is highly appreciated, but please let me know if you think of helping out. I kinda want to refactor some stuff about all download clients.

@Flaminel commented on GitHub: > RDT Client does not work Oh yeah, my bad on that one. I confused the way things work on cleanuperr. I just released v1.5.13 which includes a new `disabled` option for the download client. At least that way the users explicitly state what they want to do. Please try it out and let me know how it goes! As for RDT-Client, it is on my radar and I want to integrate it here, but unfortunately I didn't get the time to do it yet. Any help is highly appreciated, but please let me know if you think of helping out. I kinda want to refactor some stuff about all download clients.
giteasync commented 2025-10-09 16:58:59 -05:00
Author
Owner
Copy Link

@pradumnk-mahanta commented on GitHub:

I just released v1.5.13 which includes a new disabled option for the download client. At least that way the users explicitly state what they want to do. Please try it out and let me know how it goes!

Thank you for this. I tested the latest build with, DOWNLOAD_CLIENT=disabled and everything works for me.

I will close this issue. Will definitely look into the RDT Client APIs this weekend and get back.

Again, thank you for the quick turnaround.

@pradumnk-mahanta commented on GitHub: > I just released v1.5.13 which includes a new `disabled` option for the download client. At least that way the users explicitly state what they want to do. Please try it out and let me know how it goes! Thank you for this. I tested the latest build with, `DOWNLOAD_CLIENT=disabled` and everything works for me. I will close this issue. Will definitely look into the RDT Client APIs this weekend and get back. Again, thank you for the quick turnaround.
giteasync commented 2025-10-09 16:59:00 -05:00
Author
Owner
Copy Link

@pradumnk-mahanta commented on GitHub:

Hi @Flaminel,

Thank you for the response and the clarification. RDT Client does not work as such and gives the error mentioned in #83 , but because this tool removes, from Queue, Sonarr/Radarr deletes the download from RDT Client and from the Debrid Provider as well for me. So, I get best of all worlds 😁

For now I have reverted back to 1.5.10, so everything works.

Just some thoughts, what if we add another download client type as "QueueOnly" or something similar, and if people configure that then it will work only on Arr Queue?

Don't worry about it though. For now, I am happy with 1.5.10.

Also, I will look into the RDT Client API, and try to see, if I am able to integrate it. I think that would be much cleaner solution.

@pradumnk-mahanta commented on GitHub: Hi @Flaminel, Thank you for the response and the clarification. RDT Client does not work as such and gives the error mentioned in #83 , but because this tool removes, from Queue, Sonarr/Radarr deletes the download from RDT Client and from the Debrid Provider as well for me. So, I get best of all worlds 😁 For now I have reverted back to 1.5.10, so everything works. Just some thoughts, what if we add another download client type as "QueueOnly" or something similar, and if people configure that then it will work only on Arr Queue? Don't worry about it though. For now, I am happy with 1.5.10. Also, I will look into the RDT Client API, and try to see, if I am able to integrate it. I think that would be much cleaner solution.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
planned
pull-request
Mirrored from GitHub Pull Request
question
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
giteasync
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Cleanuparr-Cleanuparr#132
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?