diff --git a/src/common/AsideMenu.tsx b/src/common/AsideMenu.tsx index a301d4ef..9c086e27 100644 --- a/src/common/AsideMenu.tsx +++ b/src/common/AsideMenu.tsx @@ -40,7 +40,8 @@ const AsideMenuItem: FC = ({ children, to, className, ...res const AsideMenu = (DeleteServerButton: FC) => ( { selectedServer, showOnMobile = false }: AsideMenuProps, ) => { - const serverId = isServerWithId(selectedServer) ? selectedServer.id : ''; + const hasId = isServerWithId(selectedServer); + const serverId = hasId ? selectedServer.id : ''; const addManageDomainsLink = supportsDomainRedirects(selectedServer); const asideClass = classNames('aside-menu', { 'aside-menu--hidden': !showOnMobile, @@ -77,7 +78,7 @@ const AsideMenu = (DeleteServerButton: FC) => ( Edit this server - {isServerWithId(selectedServer) && ( + {hasId && ( { diff --git a/src/tags/TagCard.tsx b/src/tags/TagCard.tsx index df0fd26a..482a998c 100644 --- a/src/tags/TagCard.tsx +++ b/src/tags/TagCard.tsx @@ -6,7 +6,7 @@ import { Link } from 'react-router-dom'; import { prettify } from '../utils/helpers/numbers'; import { useToggle } from '../utils/helpers/hooks'; import ColorGenerator from '../utils/services/ColorGenerator'; -import { isServerWithId, SelectedServer } from '../servers/data'; +import { getServerId, SelectedServer } from '../servers/data'; import TagBullet from './helpers/TagBullet'; import { NormalizedTag, TagModalProps } from './data'; import './TagCard.scss'; @@ -29,7 +29,7 @@ const TagCard = ( const [ isEditModalOpen, toggleEdit ] = useToggle(); const [ hasTitle,, displayTitle ] = useToggle(); const titleRef = useRef(); - const serverId = isServerWithId(selectedServer) ? selectedServer.id : ''; + const serverId = getServerId(selectedServer); useEffect(() => { if (isTruncated(titleRef.current)) {