qbittorrent/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-10 00:46:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

WebUI: fix adding torrent when using virtual tables

Browse Source 
When using virtual tables we can't rely on fetching the values from the DOM. We should always fetch values directly from the file tree.

PR #23263.
Closes #23241.
This commit is contained in:
Tom Piccirello 2025-09-28 11:19:07 -07:00 committed by GitHub
parent 84224c1bbf
commit 4fb54d3da0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/webui/www/private/addtorrent.html
View File

@ -85,10 +85,7 @@
});
window.qBittorrent.pathAutofill.attachPathAutofill();
window.qBittorrent.TorrentContent.init("addTorrentFilesTableDiv", window.qBittorrent.DynamicTable.AddTorrentFilesTable);
if (fetchMetadata)
window.qBittorrent.AddTorrent.loadMetadata(source, downloader);
window.qBittorrent.AddTorrent.init(source, downloader, fetchMetadata);
});
</script>

19
src/webui/www/private/scripts/addtorrent.js
View File

@ -29,14 +29,15 @@ window.qBittorrent.AddTorrent ??= (() => {
return {
changeCategorySelect: changeCategorySelect,
changeTMM: changeTMM,
loadMetadata: loadMetadata,
metadataCompleted: metadataCompleted,
populateMetadata: populateMetadata,
setWindowId: setWindowId,
submitForm: submitForm
submitForm: submitForm,
init: init
};
};
let table = null;
let defaultSavePath = "";
let defaultTempPath = "";
let defaultTempPathEnabled = false;
@ -307,10 +308,10 @@ window.qBittorrent.AddTorrent ??= (() => {
document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
document.getElementById("filePriorities").value = [...document.getElementsByClassName("combo_priority")]
.filter((el) => !window.qBittorrent.TorrentContent.isFolder(Number(el.dataset.fileId)))
.sort((el1, el2) => Number(el1.dataset.fileId) - Number(el2.dataset.fileId))
.map((el) => Number(el.value));
document.getElementById("filePriorities").value = table.getFileTreeArray()
.filter((node) => !node.isFolder)
.sort((node1, node2) => (node1.fileId - node2.fileId))
.map((node) => node.priority);
if (!isAutoTMMEnabled())
document.getElementById("useDownloadPathHidden").value = document.getElementById("useDownloadPath").checked;
@ -326,6 +327,12 @@ window.qBittorrent.AddTorrent ??= (() => {
}
};
const init = (source, downloader, fetchMetadata) => {
table = window.qBittorrent.TorrentContent.init("addTorrentFilesTableDiv", window.qBittorrent.DynamicTable.AddTorrentFilesTable);
if (fetchMetadata)
loadMetadata(source, downloader);
};
window.addEventListener("load", async (event) => {
// user might load this page directly (via browser magnet handler)
// so wait for crucial initialization to complete

4
src/webui/www/private/scripts/dynamicTable.js
View File

@ -2478,6 +2478,10 @@ window.qBittorrent.DynamicTable ??= (() => {
this.#addNodeToTable(child, depth + 1, node);
}
getFileTreeArray() {
return this.fileTree.toArray();
}
getRoot() {
return this.fileTree.getRoot();
}