openjdk/jdk8u
1
0
Fork 0
mirror of https://github.com/openjdk/jdk8u.git synced 2025-12-11 14:00:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer

Browse Source 
Reviewed-by: phh, stuefe
This commit is contained in:
SendaoYan 2025-09-26 09:32:07 +00:00
parent 26a41cde17
commit 7bbd26b326
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hotspot/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2013, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -34,13 +34,17 @@
class LineBuffer: public StackObj { class LineBuffer: public StackObj {
private: private:
static const int BUFFER_LEN = 1024; static const int BUFFER_LEN = 1024*3;
static const int INDENT_CHARS = 3; static const int INDENT_CHARS = 3;
char _buffer[BUFFER_LEN]; char _buffer[BUFFER_LEN];
int _indent_level; int _indent_level;
int _cur; int _cur;
void vappend(const char* format, va_list ap) ATTRIBUTE_PRINTF(2, 0) { void vappend(const char* format, va_list ap) ATTRIBUTE_PRINTF(2, 0) {
if (_cur >= BUFFER_LEN) {
DEBUG_ONLY(warning("previous LineBuffer overflow, request ignored");)
return;
}
int res = os::vsnprintf(&_buffer[_cur], BUFFER_LEN - _cur, format, ap); int res = os::vsnprintf(&_buffer[_cur], BUFFER_LEN - _cur, format, ap);
if (res > BUFFER_LEN) { if (res > BUFFER_LEN) {
DEBUG_ONLY(warning("buffer too small in LineBuffer");) DEBUG_ONLY(warning("buffer too small in LineBuffer");)