mirror of
https://github.com/nasa/fprime.git
synced 2025-12-10 00:44:37 -06:00
11 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Thomas Boyer-Chammard
|
9141f01919
|
Fix Intermittent UT failure in FprimeDeframer (#4177)
* Fix random UT failure in FprimeDeframer * Update UTs and docs to reflect expectations |
||
|
Vince Woo
|
3422cfa117
|
Mark legacy serialize and deserialize methods as DEPRECATED. Upgrade remaining references to legacy methods. (#4145)
* Mark legacy serialize and deserialize functions as deprecated. Clean up of remaining legacy references. * Upgrading serialization in FppTestProject and Ref * Fixed formatting issues |
||
|
Thomas Boyer-Chammard
|
ade6cc5ff3
|
Make APID and FwPacketDescriptorType the same width (#4076)
* Make APID same width as FwPacketDescriptorType * Rename ComCfg.APID to ComCfg.Apid * Fix FprimeDeframer UTs * FpySequencer stack based architecture (#3975) * Some work towards stack based arch * Bring fp/int conv up to date * Get compiling with stack based arch * Start trying to fix UTs * Start adding store/load dirs * Add push val dir * UTs are running * UTs passing * Make exit stack based * Fix more uts * Fix final UTs * sp * Fix overflow potential err * Fix another overflow * same error fix * Update sdd * sp * Fix undefined behavior with bitshift of signed integer * sp --------- Co-authored-by: Zimri Leisher <zimri.leisher@fireflyspace.com> * Fix AI Policy link in PR template (#4019) * Update NOTICE.txt references (#4045) With the removal of the Autocoders directory, we also remove the pyparsestring usage. * Reformat FppTest (#4048) * Update Drv IP stack to use FwSizeType instead of U32 (#4013) * Update IP stack source to use SizeType instead of I/U32 * Update UTs reflecting U32/I32 change to SizeType * Static cast sizes per review * Fix commented out thing * Basic data structure library, phase 1 (#3927) * Revise SDD for SetBase * Revise SDD for SetBase * Revise SDD for Fw/DataStructures * Revise SDD for FifoQueue * Revise SDD for Fw/DataStructures * Revise SDD for MapBase * Revise SDD for StackBase * Revise SDD for Fw/DataStructures * Revise SDD for Fw/DataStructures * Add StackBase.hpp * Add ExternalStack.hpp * Add Stack.hpp * Add ExternalStackTest * Revise Stack tests * Revise ExternalStack * Revise ExternalStackTest * Revise ExternalStackTest * Revise ExternalStackTest * Revise ExternalStackTest * Add StackTest * Revise SDD for Fw/DataStructures * Revise SDD for Fw/DataStructures * Revise SDD for Fw/DataStructures * Add MapIterator * Add SetIterator * Add SetOrMapIterator * Add MapBase.hpp * Revise SDD for Fw/DataStructures * Revise SDD for ArraySetOrMapImpl * Revise SDD for ArraySetOrMapImpl * Revise SDD for ExternalArray * Revise SDD for Fw/DataStructures * Revise SDD for Fw/DataStructures * Revise MapBase * Revise MapBase * Revise comments * Revise SDD for ArraySetOrMapImpl * Revise Fw/DataStructures * Add ArraySetOrMapImpl * Add ExternalArrayMap * Revise ExternalArrayMap * Revise Fw/DataStructures * Revise SetBase * Revise SDD for Fw/DataStructures * Revise SDD for ExternalArraySet * Revise SDD for ExternalArraySet * Revise SDD for ArraySetOrMapImpl * Revise Fw/DataStructures * Revise SDD for Fw/DataStructures * Revise Fw/DataStructures tests * Revise unit tests for Fw/DataStructures * Revise tests for ArraySetOrMapImpl * Revise unit tests for Fw/DataStructures * Revise unit tests for Fw/DataStructures * Revise unit tests for ArraySetOrMapImpl * Revise unit tests for ArraySetOrMapImpl * Revise unit tests for ArraySetOrMapImpl * Revise unit tests for ArraySetOrMapImpl * Revise unit tests for ArraySetOrMapImpl * Revise unit tests for ArraySetOrMapImpl * Revise unit tests for Fw/DataStructures * Revise SDD for SetOrMapIterator * Add ExternalArrayMapTest * Revise ExternalArrayMapTest * Revise design for sets and maps * Revert changes to design * Revise unit tests for Fw/DataStructures * Revise unit tests for Fw/DataStructures * Revise ExternalArrayMapTest * Revise ExternalArrayMapTest * Revise unit tests for ArraySetOrMapImpl * Revise ExternalArrayMapTest * Revise ExternalArrayMapTest and MapTest * Revise MapTestScenarios * Revise ExternalArrayMapTest * Revise ExternalArrayMapTest * Revise ExternalArrayMapTest * Revise array set and map Remove at function from interface. It breaks the array or set abstraction. It provides little value, since one can use the iterator provided by SetBase or MapBase to range over the elements. * Revise ExternalArrayMapTest * Add ExternalArraySetTest * Revise ExternalArraySet and ExternalArrayMap * Revise ExternalArraySetTest * Revise ExternalArraySetTest * Revise ExternalArraySetTest * Revise ExternalArraySetTest * Revise ExternalArraySetTest * Revise ExternalArraySetTest * Revise ExternalArraySetTest and ExternalArrayMapTest * Revise ArraySetOrMapImplTest * Revise ExternalArrayMapTest * Revise ExternalArraySetTest * Revise SDD for ArrayMap * Revise SDD for ArraySet * Revise SDD for ArraySet * Add ArrayMap * Revise ArrayMapTest * Revise Fw/DataStructures * Revise SDDs for ArrayMap and ArraySet * Revise Fw/DataStructures * Refactor map test scenarios * Refactor data structures tests * Refactor SetTestScenarios * Refactor FifoQueueTestScenarios * Refactor ExternalFifoQueueTest * Revise Fifo Queue tests * Refactor ExternalFifoQueueTest * Revise comments * Revise Stack tests * Revise Stack tests * Refactor Stack tests * Revise Stack tests * Revise Array Remove getStaticSize * Refactor Fifo tests * Refactor ArraySetOrMapImplTest * Revise data structures design Rename Iterator to Entry * Revise data structures implementation Rename Iterator to Entry * Revise data structures impl and test Rename Iterator to Entry throughout * Revise data structures implementation Rename SetOrMapEntry to SetOrMapImplEntry * Revise data structure implementation Rename Entry to ImplEntry * Revise data structures design Rename symbols to match implementation * Revise design for data structures Add ConstIterator to Map * Revise ArraySetOrMapImpl Add ConstIterator * Add iterators to DS implementation * Revise map iteration * Revise unit tests Use iterators for maps * Revise iterators * Revise iterators * Rename MapEntry to MapConstEntry * Revise map interface * Rename SetOrMapImplEntry to SetOrMapImplConstEntry * Revert "Rename SetOrMapImplEntry to SetOrMapImplConstEntry" This reverts commit cc6371d03c8f65fa130212d589812cf4ab3714fe. * Rename SetEntry to SetConstEntry * Add SetConstIterator * Revise SetBase and unit tests Use iterators * Revise set interface * Revise comments * Reformat code * Revise array set and map impl Remove forward links * Revise data structures tests * Revise Set iterator * Remove SetConstEntry * Refactor SetOrMapImplEntry * Pull in changes from rb-tree branch * Revise MapBase * Revise MapBase and docs * Revise MapBase * Revise MapBase * Revise iterators * Revise MapConstIterator docs * Rename MapConstEntry to MapEntry * Revise MapEntry * Fix MapBase docs * Revise MapConstIterator * Revise MapEntry * Revise MapConstIterator docs * Revise docs for ExternalArrayMap * Revise ArrayMap docs * Revise ArraySetOrMapImpl * Revise SetOrMapImplEntry * Revise MapEntry * Revise map and set interfaces * Revert changes to map interface * Rename MapEntry to MapEntryBase * Revise type aliases * Reformat code * Revise SetBase * Revise map interface * Revise set and map interface * Revise ExternalArraySet docs * Revise ArraySet * Revise ArraySet docs * Revise SetConstIterator * Revise SetBase * Revise SetBase docs * Revise SetBase * Revise ArraySet * Revise ArraySet docs * Revise ExternalArraySet docs * Add SetOrMapImplEntry * Revise ArraySetOrMapImpl * Revise Fw/DataStructures Reformat code * Revise Fw/DataStructures Fix compile errors on Linux * Revise Fw/DataStructures Fix compile errors on Linux * Revise Fw/DataStructures Fix compile errors on Linux * Revise Fw/DataStructures Fix compile errors on Linux * Fix comments * Revise Fw/DataStructures Fix compile errors on Linux * Revise ArrayMap docs * Remove helper scripts * Revise tests for Fw/DataStructures * Fix spelling * Fix Markdown link * Fix uninitialized variable in test * Fix uninitialized variable in test * Fix "spelling" Why is the spelling check enforcing arbitrary rules of style? * Fix comments * Revise tests for ArraySetOrMapImpl * Revise comment * Revise ArraySetOrMap impl * Revise formatting * Revise docs * Revise docs for Fw/DataStructures * Revise Array and ExternalArray Add static assertions * Revise FifoQueue and Stack Add static assertions * Revise ArraySet and ArrayMap Add static assertions * Revise ArrayMap tests * Revise ExternalArraySet tests * Refactor ArraySetTest * Revise array initialization * Revise comments * Revise Array initialization * Revise Array design and implementation * Revert changes to Fw/DataStructures * Revise Array * Revise Array * Revise Array * Fix formatting * Add SizedContainer base class * Revise StackBase Make it inherit from SizedContainer Revise stack tests * Revise MapBase Make it inherit from SizedContainer Revise tests * Revise SetBase Make it inherit from SizedContainer Revise tests * Revise DataStructures design Add SizedContainer * Revise SDD for DataStructures * Revise DataStructures design * Revise DataStructures design * Revise DataStructures design * Revise DataStructures design * Fix spelling * Revise zero-arg constructor for Array * Revise Array interface Make it consistent with the arrays generated by FPP * Fix to assertion * FpySequencer arithmetic (#4025) * Some work towards stack based arch * Bring fp/int conv up to date * Get compiling with stack based arch * Start trying to fix UTs * Start adding store/load dirs * Add push val dir * UTs are running * UTs passing * Make exit stack based * Fix more uts * Fix final UTs * sp * Fix overflow potential err * Fix another overflow * same error fix * Format * Also add to format checker * Add math directives * Add integer extension and truncation * Also check correct size on stack * Fix comment * Push cmd response to stack * Cast cmd response code to i32 * Add stack cmd, memcmp, discard dirs * Fix some bugs with stack cmd * Fix lil bug in sgtack cmd * same bug * Fix another bug sry * Update sdd * sp * Fix undefined behavior with bitshift of signed integer * sp * Fix lil bug in timeout detection of stack cmd * Switch format check to do all Svc dirs * Reformat, and fix packet descriptor serialize bug * Add UTs for all of arith ops * Add tests for disc, memcmp, stack cmd * Add deser tests for those three dirs * sp * Format * Replace magic numbers with sizeofs * Add currentStatementIdx helper function * Format * Split imod into smod and umod * sp * Add fmod, copy python behavior for fmod and smod --------- Co-authored-by: Zimri Leisher <zimri.leisher@fireflyspace.com> * Update supported platforms (#4071) * improved step to contribute back * added delivery date for targeted platforms * added tbd since we are not sure at the moment * fixed column data * updating list of supported targets. This reflects how F Prime runs on these hardware with zephyr. * alphabetized list and added link for freertos * fix spelling * rename Apple M* to Apple Silicon --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Add ground derived channels how-to guide (#4074) * Initial derived channel work * Write ground-derived channels * Update plugin handler * Updating publishChannel case Updated method name to follow naming conventions. * Fix method name to use snake_case in documentation * Add environment setup to CONTRIBUTING.md (#4078) * Fix typo `cp` to `cd` in CONTRIBUTING.md * Mention Python venv requirements for running tests * Add logic for assert failure short circuiting in `AssertFatalAdapter` (#4042) * Add logic for assertion short circuiting - Add guard logic to AssertFatalAdapter to prevent a cascading FW_ASSERT chain from occurring - If any assert checks fail while handling an in-progress assert check failure, reportAssert will log the additional assert and execute the system-specific assert handler before returning * Update assert guard logic to counter based - Instead of using a bool guard to determine when to off-ramp from a series of FW_ASSERT check failures, use a counter that is configurable in a program's FpConfig.h file --------- Co-authored-by: M Starch <LeStarch@googlemail.com> * Add subtopology documentation (#4072) * Add subtopology guide * fix typo and how-to * Add reference link * Add event ID filters to text logger components (#4028) * Add event ID filter to PassiveConsoleTextLogger * Add event ID filter to ActiveTextLogger * Add const qualifier to filtered event list pointers * Fix assert argument types * Fix clang format errors * Fix copy-paste error on include file Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Add missing initialization to ActiveTextLogger constructor --------- Co-authored-by: Ian Brault <ian.r.brault@jpl.nasa.gov> Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> Co-authored-by: M Starch <LeStarch@googlemail.com> * Bump GDS to v4.0.2a3 (#4079) * Bump to v4.0.2a2 (GDS) * Fix integration tests * Fix requirements.txt * Allow FPP arrays of arbitrary size (#4073) * Revise array tests Update constructor calls to conform to new code gen Format the code * Reformat FppTest * Revise requirements.txt * Update requirements.txt * Update fpp version * Revise Ref to conform to FPP changes * Remove trailing spaces --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Update project structure in cookiecutters CI (#3991) * Update project structure * Fix sourcing path * fix paths --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Fix #3397 (#4086) * Add test driven development how-to (#4090) * Add test driven development how-to * sp; review * Add reusable InT test scripts (#3923) * add deployment function * update file to use config json file * remove unuse function * fix typos * fixed spelling * update to use get_mnemonic * rm shellcmd from fileManager and add health & systemResources testcase * check memory usage and number of CPUs * remove Ref.PingReceiver and fixed typos * fixed spelling fileDownlink,health,systemResources and add config.json file * Update config.json * replace ActiveLogger to EventManager * Updated config.json use lowercase CdhCore and FileHandling(fileDownlink,fileManager,prmDb) and ComCcsds(cmdSeq) etc * update test_cmd_version to compare version of telemetry channel vs. evr version * extend max_delay to work with Raspberry pi * rename config.json to int_config.json * delete Ref/config.json new file name int_config.json * add time.sleep between AppendFile cmd to work with rasberry Pi * fix int_config.json and add new Int DpMgr, DpWriter and DpCatalog * add comments to confirm /tmp/1MiB.txt and /tmp/test_seq.seq exist before execute script * add send uplink files * Rename config.json, fix spelling * python formatting --------- Co-authored-by: Cindy T Huynh <chuynh@jpl.nasa.gov> Co-authored-by: M Starch <LeStarch@googlemail.com> Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> Co-authored-by: Kevin F. Ortega <kevin.f.ortega@jpl.nasa.gov> * Modify LinuxTimer interface for consistency (#4087) * Use Fw::TimeInterval in LinuxTimer * Fix Linux FD typo * Fix interval timer UT * Format * Fix assert casts * Fix ComLogger UTs * Fix FppTest microseconds * Fix casting * Fix overflow * FpySequencer U32 stack size + some error telemetry (#4065) * Switch everything that references stack size or offset to U32 * Add dir err tlm * Rename tlm point to be consistent * Update state tlm type to enumstoretype * Make new Fpy::StackSizeType alias * Add explanation for why we chose U32 * Fix one more static cast * Bump schema vers to 2 --------- Co-authored-by: Zimri Leisher <zimri.leisher@fireflyspace.com> * Add Framing subtopologies and use them within Com subtopologies (#4113) * Update ComX subtopologies to not include ComStub and update Ref * Cosmetic updates * Working FramingCcsds subtopology used in ComCcsds * Revert Ref to use ComCcsds * Move FramingSubtopology into ComCcsds build module * Working ComFprime subtopology * Cosmetic updates * formatting * Incorporate student feedback for ground derived channels (#4117) * Update fprime-gds version to 4.0.2a4 (#4118) * Revise subtopology development documentation (#4119) * Revise subtopology development documentation * Document subtopology configuration process Added detailed instructions for configuring subtopologies, including module setup and CMake integration. * Enhance documentation on subtopology structure Added recommendations for including documentation and optional files in subtopology. * fix spelling * fix spelling v2 final --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Add SDD for ComCcsds subtopology (#4128) * Create SDD for ComCcsds subtopology * Update Svc/Subtopologies/ComCcsds/docs/sdd.md Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Update Svc/Subtopologies/ComCcsds/docs/sdd.md Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Update Svc/Subtopologies/ComCcsds/docs/sdd.md Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Revise CCSDS subtopology entries and limitations Updated descriptions for CCSDS subtopologies and clarified limitations. --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Create SDD for CdhCore subtopology (#4121) * Create SDD for CdhCore subtopology Added a comprehensive Software Design Document (SDD) for the CdhCore subtopology, detailing requirements, design, usage, configuration, and traceability. * sp * Update SDD with review feedback Added section for rate-group connection points and updated instance requirements. * Feedback updates on common port patters, health, and worker (#4115) * Feedback updates on common port patters, health, and worker * Fix typos and improve clarity in documentation * Fix typo in health-checking documentation - pt 2 Corrected a typo in the description of Svc.Health regarding configurable timeouts. * Fix typo in manager-worker documentation - pt 3 * Fix formatting in health-checking documentation * Add Software Design Document for FileHandling subtopology (#4125) * Add FPP state machine How-To (#4096) * Add FPP state machine How-To * Fix state definitions in state diagram for newlines * sp Clarified wording regarding state transitions in the documentation. * Missing `.` Co-authored-by: Rob Bocchino <bocchino@icloud.com> * Review updates * Update links in define-state-machines.md * sp --------- Co-authored-by: Rob Bocchino <bocchino@icloud.com> * Add Software Design Document for ComFprime subtopology (#4127) * Add Software Design Document for ComFprime subtopology * sp * fix spelling and same feedback as ComCcsds * Update instance summary in sdd.md documentation --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Add file size and subdirectory support to FileManager directory listing feature (#4041) * Enhancement: Added file size and subdirectory support to FileManager directory listing feature * Refactor to directory listing feature using rategroup 2 component * Spelling fixes to expect.txt, config feilds for schedin call, fixes on comments/types * Fix for spellcheck * Replace fixed size with FileNameStringSize for commands * Fix minor nits * Formatting * Remove fileManager instance, use FileHandling.fileManager * Fix review feedback --------- Co-authored-by: M Starch <LeStarch@googlemail.com> * Revise Communication Adapter Interface documentation (#4133) Updated reference to the Communication Adapter Interface in the documentation to reflect changes in the interface file names and added usage instructions. * Add ActivePhaser to Svc (#3974) * Initial open source review of active phaser * Start working on ActivePhaser's FPP model * Add ActivePhaser implementation * Start working on unit tests * Fill in test logic * Add comments * Guard against writing outside of container * Add comment * Update comments * Fix comment on overflow * Comment on the use of actual_start and others * Add comments and max connection count * Add comments * Phaser updates * Add telemetry channels * Update comments, fix FPP, update API calls in tester * Apply formatter * Minor comment change * Fix spelling * First draft of SDD * Revert "Add telemetry channels" This reverts commit 1690e51e125477d032e07fa8cd3882d6db2b8b3b. * PRIVATE -> private * Add friend class declaration for ActivePhaserTester * Fix FIXMEs where possible * Formatting * Fix minor UT issues * Remove (void) --------- Co-authored-by: ZIIIKT <shaokail@jpl.nasa.gov> Co-authored-by: M Starch <LeStarch@googlemail.com> Co-authored-by: Michael D Starch <Michael.D.Starch@jpl.nasa.gov> * Fix other UTs * Bump GDS dependency to latest v4.0.2a5 * Bump fprime-gds to v4.0.2a6 * Update dictionary command in seqgen tests --------- Co-authored-by: Zimri Leisher <zimri.leisher@gmail.com> Co-authored-by: Zimri Leisher <zimri.leisher@fireflyspace.com> Co-authored-by: M Starch <LeStarch@googlemail.com> Co-authored-by: Rob Bocchino <bocchino@jpl.nasa.gov> Co-authored-by: kevin-f-ortega <kevin.f.ortega@gmail.com> Co-authored-by: Philip Romano <pjromano94@gmail.com> Co-authored-by: Kyle Jones <kylej@jpl.nasa.gov> Co-authored-by: Ian Brault <ian@brault.dev> Co-authored-by: Ian Brault <ian.r.brault@jpl.nasa.gov> Co-authored-by: chuynh4duarte <chuynh4duarte@gmail.com> Co-authored-by: Cindy T Huynh <chuynh@jpl.nasa.gov> Co-authored-by: Kevin F. Ortega <kevin.f.ortega@jpl.nasa.gov> Co-authored-by: Rob Bocchino <bocchino@icloud.com> Co-authored-by: Isaac Garibay <144189484+Isaac-G5900@users.noreply.github.com> Co-authored-by: Shaokai (Jerry) Lin <shaokai@berkeley.edu> Co-authored-by: ZIIIKT <shaokail@jpl.nasa.gov> Co-authored-by: Michael D Starch <Michael.D.Starch@jpl.nasa.gov> |
||
|
Thomas Boyer-Chammard
|
c69ff72110
|
Format Svc and add to CI (#3978)
* Format Svc and add to CI * Fix comlogger include * fix assert UTs * Fix static analysis warning * formatting |
||
|
M Starch
|
968746083b
|
Replace struct get/set with get_/set_ (#3917)
* Replace struct get/set with get_/set_ * Bump FPP to a16 |
||
|
Thomas Boyer-Chammard
|
728a022e9c
|
Add support for CCSDS TC/TM and SpacePacket protocols (#3684)
* First pass at Svc + TcpClient implementation * Tmp work * Revert FileUplink changes * Add copy (with allocation/deallocation) to FprimeRouter to simplify buffer management * Update FprimeRouter UTs * Update FprimeDeframer UTs * Update FrameAccumulator UTs * Update ComStub UTs * Update missing Drv and UTs * Update ComInterface to use ComDataWithContext on output * Update Ref/RPI topology * Fix spelling * Fix test typo * Update Udp component and UTs * Rename data ports and standardize "Return" naming pattern * Fix variable name * Adapt UTs * Update Communication Adapter Interface docs * Full SDD updates * Spelling & nits and details * Put formatting back to original * Added SpacePacket, TC and TM framers/deframers + Ref topology. Working with GDS wohooo * TODOs and code cleanup * Add APID enum to ComCfg.fpp and route based on received APID * Increment counts per frame/apid * Remove duplicate files * Document and implement services/functions provided by the TCDeframer * Add events, todos and notes * fill TM frame with idle packet * Add ApidMapper component and map APID - FwPacketDescriptor * Refactor to new CMake API * Update Types and Add TCDeframer tests * Update type usage namespacing * Finish TCDeframer UTs * Add TMFramer tests and refine VcId handling * Tests and code cleanup * Define ComPacketType in FPP * Map FW_PACKET_FILE to downlink specific APID * Remove sequence number check * Add packet loss notification to space packet * Tests WIP * WIP * Use SpacePacket header type in TMFramer idle packet * SpacePacketDeframer tests and untracked APID detection * Add APID (=PacketDescriptor) extraction to FprimeDeframer * Use ApidManager on uplink to validate seq count (is central authority for APID - SeqCount) * Code cleanup * Much cleaner ApidManager as a service, not in the middle of framing * Even better ApidManager * Add SpacePacketFramer UTs * Set up rule based testing for ApidManager * Code cleanup and fix TMFramer UT * First pass at SDDs and stuff * SDD fixes * ApidManager Rule-based testing * Improve TMFramer code coverage, docs and comments * Types cleanup * Add CRC check to CcsdsTCFrameDetector * Add unit tests for CcsdsTCFrameDetector * Fix Ref topology * Fix old PacketType usage * Fix ComQueue UTs * Fix CI warnings * Add test for CRC corruption in frame detector * Spelling * Remove ApidDemo component from topology * Fix more static analysis * Clean up ApidManager tests and fix static analysis warnings * Fix UTs on RHEL8 * Fix SDD links * Fix more static analysis on UTs * More spelling fixes * Improve SDDs and comments * Update metadata check-spelling run (pull_request_target) for ccsds-protocols Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> on-behalf-of: @check-spelling <check-spelling-bot@check-spelling.dev> * More SDD updates * Attempt UT fixes * First pass of review comments * Fix length token is minus 1 inconsistency * Review recs: static assert frame size, docs, TM buffer asserts * Add fprime-gds.yml to Ref for GDS with framing selection * Update requirements.txt for GDS 4.0.0a3 (CCSDS protocols) * Update UTs to reflect last update * Drop Python 3.8 support * Update FprimeRouter UTs for new APID routing * Fix spelling and RHEL8 cast warnings * Fix spelling again... * Deserialize APID in FprimeDeframer only if it is valid * Fix googletest warning?? * static casting that u8 yall * Use width FPP constants * Add SDD links * Switch TMFramer/TCDeframer capitalization to TmFramer/TcDeframer * Use git mv to rename files and directory * oops forgot rename a test file * review changes: add annotations on all FPP ports --------- Signed-off-by: check-spelling-bot <check-spelling-bot@users.noreply.github.com> Co-authored-by: Thomas Boyer-Chammard <thomas-bc@users.noreply.github.com> |
||
|
Thomas Boyer-Chammard
|
c3b2e04880
|
Use data return pattern on Uplink and standardize port names (#3546)
* First pass at Svc + TcpClient implementation * Revert FileUplink changes * Add copy (with allocation/deallocation) to FprimeRouter to simplify buffer management * Update FprimeRouter UTs * Update FprimeDeframer UTs * Update FrameAccumulator UTs * Update ComStub UTs * Update missing Drv and UTs * Update ComInterface to use ComDataWithContext on output * Update Ref/RPI topology * Fix spelling * Fix test typo * Update Udp component and UTs * Rename data ports and standardize "Return" naming pattern * Fix variable name * Adapt UTs * Update Communication Adapter Interface docs * Full SDD updates * Spelling & nits and details * Put formatting back to original * Update Deframer interface to include bufferReturn * Address review comments |
||
|
Thomas Boyer-Chammard
|
d0246f148b
|
Add Framer FPP interface, implement FprimeFramer and adapt ComQueue (#3486)
* Initial FprimeFramer and FprimePacketizer * Code clarity + set up UTs * Rework ComQueue and ComStub to use DataWithContext * Add packets to RefPackets.fppi * Fix ComQueue tests * Add hotfix to FileDownlink instead of ComQueue * Fix cancelPacket as well * Fix ComQueue UTs by removing hotfix * Refactor DataWithContext to use an FPP object for context instead of Fw.Buffer * Touch up testing * Add docs * more docs * More docs * Rework buffer deallocation pattern to pass-through ComQueue * Update ComStub UTs * Restore original FileDownlink.cpp * Formatting tweak * Update deprecated getSerializeRepr() calls * deserialization methods * Fix spelling * add cast for safety * CMakefile change * Bump ComQueue depth * Update RPI deployment with new Downlink stack * Rename comQueueIn port to comPktQueueIn * Fix comQueueIn to comPktQueueIn change * Remove legacy Svc.Framer * Fix CMake UTs * Fix RPI topology config * Fix FprimeProtocol.fpp module * Fix namespacing * Use const reference for FrameContext port * Review comments EXCEPT port passback refactor * Rework ComStub with new ByteStream * New ByteStream - ComInterface model * Rework TcpClient / TcpServer with new bytestream * Adapt UDP component for new ByteStream * Adapt FrameAccumulator for new ByteStream * Adapt FprimeFramer for new ByteStream * Update Ref topology with new ByteStream model * Remove all legacy deallocates from Drivers; reintroduce DEPRECATED model types * Fix spelling and include error * More spelling.... * RPI and RpiDemo fixes * Fix conversion warning on RPI * static_cast for short int on RPI * Standardize port names * Remove legacy Drv types and merge RECV/SEND enum type, delete StreamCrossover * Update SDDs * Update SDDs * Fix ComInterface <-> Framer interfaction, clarify comments and fix annotations * Switch ComStub from ASSERT to log failure and return buffer * Add history size check + clarify test handler overrides * Fix RPI topology to wire comStub on Uplink * Rename comm to comDriver in RPI topology * Update communication adapter interface docs |
||
|
Vince Woo
|
a2141d98fb
|
Deprecate Fw::Buffer::getSerializeRepr in favor of 'getSerializer' and 'getDeserializer' (#3431)
* Deprecating Fw::Buffer::getSerializeRepr in favour of Fw::Buffer::getSerializer and Fw::Buffer::getDeserializer (#2714) * Addressing PR comments. * Add workflow for running fpp-to-json on Ref (#3430) * Add workflow for running fpp-to-json on Ref * Update working dirs * Add FPP v3.0.0a4 * fpp v3.0.0a5 * Use setup action * Rename workflow for better display --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> * Return cmd repsonse and UT check (#3438) Co-authored-by: Zimri Leisher <zimri.leisher@fireflyspace.com> * Update Ref to use FPP telemetry packets (#3440) * Revise Ref app Convert Ref packets to FPP * Remove header include for XML packets * Remove trailing spaces * Delete RefPackets.xml * Update Ref packets * Update fpp version * Update fpp version --------- Co-authored-by: M Starch <LeStarch@googlemail.com> * Refactored type organization (#3422) * Refactored type organization * Creating better configuration/types header hierarchy * Replace FpConfig type aliases with FPP generated aliases * Add the aliases to the FPP model * Config + Type Aliases builds * Renamed Fw/Types.h,hpp to Fw/FPrimeBasicTypes.h,hpp * Updating to FPP-a7 * Adding newline * sp * Fixing minor nit from review * Spurious ; --------- Co-authored-by: Andrei Tumbar <andrei.tumbar@jpl.nasa.gov> * Deprecating Fw::Buffer::getSerializeRepr in favour of Fw::Buffer::getSerializer and Fw::Buffer::getDeserializer (#2714) * Incorporating PR suggested fixes * Adding the setting of m_serLoc and m_deserLoc to the copy constructor. Moving those members from private to protected. * Adding m_serLoc and m_deserLoc copying to = operator function. Fixing FPP tests to explicitly move deserialize location to offset. * File typo (#3464) * typo. SeekType does not have a CURRENT value but it does have a RELATIVE value * applied formatter * Incorporating PR comments * Incorporating PR comments --------- Co-authored-by: Justine West <35715959+jwest115@users.noreply.github.com> Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com> Co-authored-by: Zimri Leisher <zimri.leisher@gmail.com> Co-authored-by: Zimri Leisher <zimri.leisher@fireflyspace.com> Co-authored-by: Rob Bocchino <bocchino@jpl.nasa.gov> Co-authored-by: M Starch <LeStarch@googlemail.com> Co-authored-by: Andrei Tumbar <andrei.tumbar@jpl.nasa.gov> Co-authored-by: kevin-f-ortega <kevin.f.ortega@gmail.com> |
||
|
M Starch
|
0659f0940b
|
Refactored type organization (#3422)
* Refactored type organization * Creating better configuration/types header hierarchy * Replace FpConfig type aliases with FPP generated aliases * Add the aliases to the FPP model * Config + Type Aliases builds * Renamed Fw/Types.h,hpp to Fw/FPrimeBasicTypes.h,hpp * Updating to FPP-a7 * Adding newline * sp * Fixing minor nit from review * Spurious ; --------- Co-authored-by: Andrei Tumbar <andrei.tumbar@jpl.nasa.gov> |
||
|
Thomas Boyer-Chammard
|
dcc3436200
|
Split Deframer into FrameAccumulator, Deframer, and Router (#3250)
* Split Router out of Deframer - initial implementation * Rename variable to packetBuffer and resolve conversion warnings * Add test cases for each incoming packet type * Adjust comments and stuff * Update Ref topology with Router * WIP - FrameAccumulator * Add lightweight deframer * Working frame detector, accumulator, and fprime packet * CCSDS implementation and better checksums * Fixing overly small start word to use SCID as well * Fixing frame accumulator for new structure * Minor cleanup to frame detectors * Add CCSDS Deframers and F´ minimal deframer * Clean up comments * Update Ref topology with Accumulator/Deframer/Router * Update buffer manager * Upgrade Router.cpp to latest Fw::Logger * Update RPI deployment to use FrameAccumulator/Router * Remove CCSDS Deframers * Add first pass at UTs * add buffer accumulation testing * start SDD and rename author * Fix static analysis warnings and add comments to UTs * Spelling * Add FprimeFrameDetector UTs * Fix CI issue * Fix test component creation * Add first pass at SDDs * Rename FrameAccumulator allocation ports * Add review comments * Functional one-off detection * Fix algorithms and rename Deframer to FprimeDeframer * Remove file * Remove templated detectors * Improve test code * Rename frame Footer to Trailer, and improve SDDs * finish renaming footer to trailer and add implementation note * Fix spelling and CI warning * Fix test code * More CI and spelling fixes * Add back virtual destructor * appease pedantic warnings * Fix declaration ordering for safe destruction * Run formatting and add a few comments * Add RouterInterface.fppi and use it in Router * review changes round 1 * Rename Router to FprimeRouter and add test for unconnected unknownDataOut port * Finish renaming Router -> FprimeRouter * Use get-target-branch for cookiecutters tests and fix spelling * fix a few comments, CI warning and formatting * Update types for compatibility with updated FwSizeType * Move FprimeProtocol.fpp to Svc/ and update non-compliant UINT types * Code review recommendations * Move FrameAccumulator destruction to cleanup() code * Add frame validation to FprimeDeframer * Add cleanup() call to test code * Fix static analysis warnings * Resolve type warnings and add multiple events in FprimeDeframer * latest latest v3 --------- Co-authored-by: Michael D Starch <Michael.D.Starch@jpl.nasa.gov> |