11 Commits

Author SHA1 Message Date
Saransh Chopra
903677e97d
Fix clang-tidy checks (#4379)
* fix(.clang-tidy): `Checks` is supposed to be a comma separated list of checks

* fix clang-tidy warning

* fix a few lint warnings

* run clang-format

* more format
2025-11-03 17:45:54 -08:00
Vince Woo
3422cfa117
Mark legacy serialize and deserialize methods as DEPRECATED. Upgrade remaining references to legacy methods. (#4145)
* Mark legacy serialize and deserialize functions as deprecated. Clean up of remaining legacy references.

* Upgrading serialization in FppTestProject and Ref

* Fixed formatting issues
2025-09-22 07:57:34 -07:00
Thomas Boyer-Chammard
c69ff72110
Format Svc and add to CI (#3978)
* Format Svc and add to CI

* Fix comlogger include

* fix assert UTs

* Fix static analysis warning

* formatting
2025-08-04 16:21:47 -07:00
Mishaal
ef5f255628
Update F' Time handling with FPP struct and clean up TIME flags, and remove Time Context comparison (#3844)
* Update F' Time handling with FPP struct and clean up TIME flags

* Update documentation to indicate required time base options

* Remove time context comparison from Time compare method and FpySequencer

* UT updates

* Remove time add/sub context assertions, upload context compare logic and UTs, and doc updates

* Update Fw::Time SDD serializables section

* Markdown format fix

* Markdown format fix

* Markdown format fix

* Markdown format fix

* Bump FPP to v3.0.0a14

---------

Co-authored-by: M Starch <LeStarch@googlemail.com>
2025-07-21 16:13:33 -07:00
M Starch
f912e1bd75
Issue 3285 reducing signed size type in os file (#3402)
* Remove FwSignedSizeType from file

* Restoring FwSignedSizeType to seek offsets

* Fixing usages and UTs

* Fixes on Linux

* CI fix

* CI round 3

* CI rev 4

* Fixing code scan errors

* Review fixes - pt 1

* Failed to save
2025-03-28 11:47:07 -07:00
M Starch
a5c853b9cf
NATIVE_INT_TYPE portNum to FwIndexType portNum (#3236) 2025-02-14 12:25:12 -08:00
M Starch
d034786bc6
Refactor Os::Queue into CMake selection (#2895)
* Initial interface tests

* Initial working rules tests

* Moving MaxHeap to Types; Fixing minor bugs

* Basic ConditionVariables, Queue blocking, and UTs

* Queue updates for Ref

* Queue build all WIP

* UTs compile

* Passing UTs

* Removing unupdated linux queue implementations

* Fixing linux specific build issues

* Fixing task regression

* Fixing queue test memory leak

* Spelling, comments, formating, and todos

* Condition variable tests

* Minor edits from review

* Condition variable interface tests, fixes

* sp

* ci fixes

* Minor condition variable fix

* Fixing post merge issues

* Final review fixes

* Fixing FS stubs

* Fixing max heap failures

* Linux fixes

* Fixing issues w.r.t. CI
2024-09-30 12:42:50 -07:00
Rob Bocchino
cdac751845
Make single-argument string constructors explicit (#2707)
* Revise Linux platform types

* Fix regression in test autocoder

TimeBaseStoreType is not the same as TimeBase

* Revise test autocoder

Cast to the TimeBaseStore type with a known size

* Revise test autocoder

Remove unnecessary const casting

* Fix integer type mismatch in ComQueue

* Update fpp version

* Update fpp version

* Revise DpWriter unit tests

Remove manually written functions
Use new autocode in tester base

* Update fpp version

* Update fpp version

* Revise DpTest

Add check for priority set by dpGet

* Reivse StringType; add ExternalString

* Revise dp test

* Revise dp test; update fpp version

* Revise dp test

* Revise dp test

* Revise dp test

* Revise dp test

* Revise dp test

* Revise dp test

* Revise dp test

* Revise dp test

* Revise dp test

* Revise fpp version

* Update fpp version

* Revise ExternalString

* Reformat Fw/Serializable.{hpp,cpp}

* Reformat StringType.{hpp,cpp}

* Revise StringBase

* Update fpp version

* Remove trailing space

* Reformat code

* Revise dp test

* Reformat cpp and hpp files in Fw/Types

* Revise string types

* Revise string types

* Revise string types

* Remove EightyCharString

* Revise CmdString

* Revise LogString

* Revise PrmString

* Revise TextLogString

* Revise Test/String

* Revise TlmString

* Revise InternalInterfaceString

* Revise Os/QueueString

* Revise Os/TaskString

* Add missing type qualifier

* Fix warning in String.hpp

* Revise string types

* Remove stray character

* Revise StringBase

* Revise string types

* Revise String type

* Revise FileNameString

* Revise string types

* Add missing file

* Revise InternalInterfaceString

* Revise comment

* Revise TlmString

* Revise string types

* Revise log strings

* Revise PrmString

* Revise Os string classes

* Revise string types

* Revise string types

* Revise os strings

* Add test for ExternalString to TypesTest

* Revise ExternalString

* Revise ExternalString

* Update fpp version

* Format Fw/Types

* Add static serialized size to StringBase

* Update fpp version

* Update fpp version; revise string classes

* Revise event handling in DpWriter

* Revise string implementations

* Revise string implementations

* Refactor dp tests

* Add static assertion to PrmBuffer

For safety's sake!

* Revise string implementations; update fpp version

* Revise StringBase

Existing code was correct but somewhat terse and obscure
Refactor and add comments for clarity

* Fix tests to conform to FPP changes

* Remove helper scripts

* Add const qualifier

* Revise StringBase

* Revise StringBase

* Revise comment

* Update fpp version

* Fix code formatting

* Make constructors explicit

* Make string constructors explicit

* Make string constructors explicit

* Revise String.hpp

Remove explicit from char* constructor
The autocoder depends on the implicit constructor

* Fixing improper null-termination in fail case

* Fixing conversion warnings

* Removing broken link

---------

Co-authored-by: M Starch <LeStarch@googlemail.com>
Co-authored-by: Michael D Starch <Michael.D.Starch@jpl.nasa.gov>
2024-04-30 11:28:39 -07:00
M Starch
58c21418aa
Issue 2457 (#2502)
* Os::File refactor: open w/ basic stub, posix UTs

* Refactoring Os::File for all methods, less UTs

* Adding rules-based common tests

* Fixing posix file for common UTs

* Adding WriteRead and WriteReadSeek tests

* Working random tests

* Working randomized tests and stub testing

* Fixing PrmDb unit tests

* Updating files to used FwSignedSizeType

* Factoring out the synthetic file system

* Initial work on CmdSequencer UTs

* Fixing linux implementation

* Newlines at end of file

* sp

* Static analysis checks

* Changing API to use enums

* Refactoring for proper class tree

* CmdSequencer UTs - WIP

* CmdSequencer UTs work

* Adding copy constructor functionality

* Spelling and static analysis fixes

* Copy constructor/assignment operator UTs and fixes

* Initial CRC work

* Working CRC and FPP models

* Minor UT fixes

* Correcting CMake choices implementation

* MAking implementation choices real dependencies

* Fixing implementation to use source files

* Fixing posix file read/write permissions

* Allowing None implementations

* Fixed CI breakages

* Fixing MyRules.hpp formatting

* Minor CRC unit test fix

* Removing direct write support

* Changing get delegate to static method of interface

* Replacing old comments with new comments

* Fixing friend regression

* Review fixes

* Fixing serialization method usages

* Review fixes

* Fixing RPI build

* Fixing FwBuffSizeType overflow

* Fixing review comment

* Renaming FwExternalSize -> FwSizeStoreType
2024-02-28 11:25:19 -08:00
Johan Bertrand
f0f19baafb
Fix shadow variables (#2482)
* Fixed shadow warnings from Fprime

* Fix unit tests

* Fix missing shadow warnings

* Fix condition in cmake

* Fix cmake

* Fixes from review

* Fixed mistake in PathName

* Fixing comment

---------

Co-authored-by: M Starch <LeStarch@googlemail.com>
2024-02-01 10:18:10 -08:00
M Starch
f797734994
Integrate/fpp v2 (#2293)
* WIP: FPP v2

* Initial integration of FPP UT generation

* Updating UT GTestBase.hpp includes

* Update fpp version

* Revise header path

* Revise test; add modified generated code

* Revise modified code gen

* Revise modified generated code

* Add and move files

* Revise Fpp tests

* Add fpp deps

* Update fpp version

* Update include paths

* Fix unit tests

* Fix unit tests

* Revise TlmPacketizer test

* Fix unit tests

* Fix unit tests

* Delete temporary files

* Updating for new FPP tools flags

* Bump for fixed FPP tools

* Migrating TcpServer unit tests to v3.4.0 standards

* Migrating Udp unit tests to v3.4.0 standards

* Migrating LinuxSpiDriver unit tests to v3.4.0 standards

* Migrating LinuxI2cDriver unit tests to v3.4.0 standards

* Migrating LinuxGpioDriver unit tests to v3.4.0 standards

* Migrating TcpClient unit tests to v3.4.0 standards

* Migrating StreamCrossover unit tests to v3.4.0 standards

* Migrating SignalGen unit tests to v3.4.0 standards

* Migrating Checksum unit tests to v3.4.0 standards

* Migrating queued unit tests to v3.4.0 standards

* Migrating empty unit tests to v3.4.0 standards

* Migrating passive unit tests to v3.4.0 standards

* Migrating active unit tests to v3.4.0 standards

* Migrating FilePacket unit tests to v3.4.0 standards

* Migrating Logger unit tests to v3.4.0 standards

* Migrating port_return_type unit tests to v3.4.0 standards

* Migrating ext_dict unit tests to v3.4.0 standards

* Migrating time_tester unit tests to v3.4.0 standards

* Migrating serial_passive unit tests to v3.4.0 standards

* Migrating tlm_multi_inst unit tests to v3.4.0 standards

* Migrating param2 unit tests to v3.4.0 standards

* Migrating param_string unit tests to v3.4.0 standards

* Migrating command_string unit tests to v3.4.0 standards

* Migrating command_res unit tests to v3.4.0 standards

* Migrating tlm_onchange unit tests to v3.4.0 standards

* Migrating param_multi_inst unit tests to v3.4.0 standards

* Migrating command2 unit tests to v3.4.0 standards

* Migrating port_nogen unit tests to v3.4.0 standards

* Migrating tlm2 unit tests to v3.4.0 standards

* Migrating command_tester unit tests to v3.4.0 standards

* Migrating event2 unit tests to v3.4.0 standards

* Migrating param_tester unit tests to v3.4.0 standards

* Migrating tlm_string unit tests to v3.4.0 standards

* Migrating testgen unit tests to v3.4.0 standards

* Migrating log_tester unit tests to v3.4.0 standards

* Migrating port_loopback unit tests to v3.4.0 standards

* Migrating param_enum unit tests to v3.4.0 standards

* Migrating command_multi_inst unit tests to v3.4.0 standards

* Migrating log1 unit tests to v3.4.0 standards

* Migrating event_multi_inst unit tests to v3.4.0 standards

* Migrating serialize_user unit tests to v3.4.0 standards

* Migrating telem_tester unit tests to v3.4.0 standards

* Migrating param1 unit tests to v3.4.0 standards

* Migrating event_throttle unit tests to v3.4.0 standards

* Migrating string_port unit tests to v3.4.0 standards

* Migrating command1 unit tests to v3.4.0 standards

* Migrating noargport unit tests to v3.4.0 standards

* Migrating time_get unit tests to v3.4.0 standards

* Migrating event_enum unit tests to v3.4.0 standards

* Migrating comp_no_namespace unit tests to v3.4.0 standards

* Migrating event1 unit tests to v3.4.0 standards

* Migrating event_string unit tests to v3.4.0 standards

* Migrating tlm1 unit tests to v3.4.0 standards

* Migrating comp_diff_namespace unit tests to v3.4.0 standards

* Migrating tlm_enum unit tests to v3.4.0 standards

* Migrating pass_by_attrib unit tests to v3.4.0 standards

* Migrating stress unit tests to v3.4.0 standards

* Migrating interface1 unit tests to v3.4.0 standards

* Migrating templates unit tests to v3.4.0 standards

* Migrating FileUplink unit tests to v3.4.0 standards

* Migrating ComLogger unit tests to v3.4.0 standards

* Migrating SystemResources unit tests to v3.4.0 standards

* Migrating TlmPacketizer unit tests to v3.4.0 standards

* Migrating ComStub unit tests to v3.4.0 standards

* Migrating ComSplitter unit tests to v3.4.0 standards

* Migrating Health unit tests to v3.4.0 standards

* Migrating BufferLogger unit tests to v3.4.0 standards

* Migrating AssertFatalAdapter unit tests to v3.4.0 standards

* Migrating FileDownlink unit tests to v3.4.0 standards

* Migrating StaticMemory unit tests to v3.4.0 standards

* Migrating CmdSequencer unit tests to v3.4.0 standards

* Migrating Framer unit tests to v3.4.0 standards

* Migrating GroundInterface unit tests to v3.4.0 standards

* Migrating FileManager unit tests to v3.4.0 standards

* Migrating ActiveTextLogger unit tests to v3.4.0 standards

* Migrating LinuxTime unit tests to v3.4.0 standards

* Migrating Deframer unit tests to v3.4.0 standards

* Migrating Deframer unit tests to v3.4.0 standards

* Migrating BufferRepeater unit tests to v3.4.0 standards

* Migrating TlmChan unit tests to v3.4.0 standards

* Migrating GenericHub unit tests to v3.4.0 standards

* Migrating BufferAccumulator unit tests to v3.4.0 standards

* Migrating LinuxTimer unit tests to v3.4.0 standards

* Migrating BufferManager unit tests to v3.4.0 standards

* Migrating CmdSplitter unit tests to v3.4.0 standards

* Migrating ComQueue unit tests to v3.4.0 standards

* Migrating Os unit tests to v3.4.0 standards

* Federating FPP tools with release versions

* Python formatting

* Reverting FPPTest to correctly working build

* Removing minor dead code and comments

---------

Co-authored-by: bocchino <bocchino@jpl.nasa.gov>
2023-10-05 14:42:09 -07:00