mirror of
https://github.com/microsoft/vscode.git
synced 2026-07-11 05:30:03 -05:00
8a8d6bb880
* Improve sessions list rendering on phone layout
- Phone-aware row height (76px) in SessionsTreeDelegate, refreshed on IsPhoneLayoutContext changes.
- Larger title/details fonts and roomier padding under .phone-layout.
- Card-style row margin/border-radius and centered icon alignment.
- Per-row toolbar always visible on touch; pulled out of the title-row flow with absolute positioning so 44px tap targets do not shift the details row.
- Stop pointer/click propagation at the toolbar container so action taps do not trigger the row open handler.
* Address PR review
- Stop Monaco Gesture tap from reaching the list when the user taps
an inline action on touch (DOM stopPropagation only covers mouse).
- Drop unsafe vertical margin on the absolutely positioned list row;
any inter-row spacing lives inside the row via padding/border.
- Refresh stale doc comments (row geometry, iteration cost, no-op
'2-line wrap' description).
* agents mobile: redesign changes/diff overlays with master-detail nav and syntax highlighting
- Add MobileChangesView: full-screen overlay listing all changed files with
codicon file-type icons, A/M/D pills, colored +N/-N counters and reactive
live updates via autorun over sessionsManagementService.activeSession.changes
- Rewrite MobileDiffView: prev/next navigation between sibling files (chevrons
+ horizontal swipe gesture), Monaco tokenization with regex fallback (4
token kinds: comment/string/keyword/number), 3px colored left-edge bar on
added/removed lines, sticky hunk headers, horizontal scroll fix
- Wire title-bar Changes pill to MOBILE_OPEN_CHANGES_VIEW_COMMAND_ID; single-
file sessions skip the list and open the diff directly (fewer taps)
- Add mobileDiffColors.ts: mobile-specific registerColor registrations for
agentsMobileDiff.{added,modified,deleted}Foreground; imported as side-effect
from mobileChangesView.ts so colors are available before any view renders
- Fix disposable leak: per-row gesture/click listeners use a rowsStore that
clears on every renderList call instead of accumulating in viewStore
- Fix merged-hunk rendering: track sub-change list per group, emit context
rows between adjacent sub-changes so unchanged lines aren't misclassified
- Update vscode-known-variables.json with new --vscode-agentsMobileDiff-*
theme tokens and --mobile-diff-{tok,added,modified,deleted} CSS vars
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* agents mobile: address Copilot reviewer feedback on PR #314433
- Fix deletion bug in single-file shortcut: reuse toRow/rowToDiffData
(now exported) from mobileChangesView.ts so modifiedURI stays undefined
for IChatSessionFileChange2 deletions instead of incorrectly falling back
to the v2 uri field
- Localize Action2 titles in mobileOverlayContribution.ts via localize2()
- Correct MOBILE.md: MobileChangesView uses codicons not ResourceLabels;
MobileDiffView uses async tokenizeToString + injected colorMap <style>,
with regex fallback emitting CSS-class spans (not inline style spans)
- Rewrite regex tokenizer comment to accurately describe the class-based
approach and per-theme CSS variable layering in mobileOverlayViews.css
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>