mirror of
https://github.com/microsoft/vscode.git
synced 2026-06-19 21:15:09 -05:00
bf2334eeee
* ci: add Node.js diagnostic reports for test crash investigation Enable Node.js diagnostic reporting for the node.js unit test runner so that native crashes (like the zlib crash in build 447204) produce actionable diagnostic reports instead of a silent exit code 1. Changes: - Configure process.report in test/unit/node/index.js to write JSON diagnostic reports to .build/crashes on fatal errors and uncaught exceptions - Add unhandledRejection handler (was missing, unlike Electron tests) - Set NODE_OPTIONS in CI pipeline steps (win32, linux, darwin) with --report-on-fatalerror and --report-uncaught-exception flags - Reports are picked up by the existing crash-dump artifact collection Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: remove process.exit(1) from exception handlers The uncaughtException handler intentionally does NOT exit — it logs the error and lets Mocha continue running. The test suite has a dedicated 'Errors' suite that asserts on collected unexpected errors at the end. Calling process.exit(1) kills the test runner on the first uncaught exception, failing all Electron tests on all platforms. Keep the writeReport() calls for diagnostic purposes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove writeReport() from exception handlers The manual writeReport() calls fire on benign unhandled rejections (e.g. Canceled errors during test teardown in UserDataSyncService) and block the event loop writing JSON reports to disk, causing subsequent faked-timer tests to exceed their 2000ms timeout. Report generation is already handled by process.report config and NODE_OPTIONS flags (--report-on-fatalerror, --report-uncaught-exception) which only fire on actual fatal errors, not on every caught rejection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>