Files
vscode/extensions/esbuild-common.mts
Dmitriy Vasyura ca569ae803 Fix infinite rebuild loop (#321728)
* Fix infinite rebuild loop

* Ignore outdir descendants in watcher (normalize separators, match subtree)
2026-06-17 10:10:23 +02:00

106 lines
3.5 KiB
TypeScript

/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import path from 'node:path';
import esbuild from 'esbuild';
export interface RunConfig {
readonly srcDir: string;
readonly outdir: string;
readonly entryPoints: esbuild.BuildOptions['entryPoints'];
readonly additionalOptions?: Partial<esbuild.BuildOptions>;
}
// `esbuild.stop()` shuts down the single esbuild service shared by all concurrent builds, so we
// must only call it once no builds are in flight. Otherwise a finishing build would tear down the
// service while a sibling build (e.g. running in the same `Promise.all`) is still using it.
let pendingBuilds = 0;
async function buildOnce(options: esbuild.BuildOptions): Promise<esbuild.BuildResult> {
pendingBuilds++;
try {
return await esbuild.build(options);
} finally {
if (--pendingBuilds === 0) {
esbuild.stop();
}
}
}
/**
* Shared build/watch runner for extension esbuild scripts.
*/
export async function runBuild(
config: RunConfig,
baseOptions: esbuild.BuildOptions,
args: string[],
didBuild?: (outDir: string) => unknown,
): Promise<void> {
let outdir = config.outdir;
const outputRootIndex = args.indexOf('--outputRoot');
if (outputRootIndex >= 0) {
const outputRoot = args[outputRootIndex + 1];
const outputDirName = path.basename(outdir);
outdir = path.join(outputRoot, outputDirName);
}
const resolvedOptions: esbuild.BuildOptions = {
...baseOptions,
entryPoints: config.entryPoints,
outdir,
...(config.additionalOptions || {}),
};
const isWatch = args.indexOf('--watch') >= 0;
if (isWatch) {
await watchWithParcel(resolvedOptions, config.srcDir, () => didBuild?.(outdir));
} else {
try {
await buildOnce(resolvedOptions);
await didBuild?.(outdir);
} catch {
process.exit(1);
}
}
}
// We use @parcel/watcher as it has much lower cpu usage when idle compared to esbuild's watch mode
async function watchWithParcel(options: esbuild.BuildOptions, srcDir: string, didBuild?: () => Promise<unknown> | unknown): Promise<void> {
let debounce: ReturnType<typeof setTimeout> | undefined;
const rebuild = () => {
if (debounce) {
clearTimeout(debounce);
}
debounce = setTimeout(async () => {
try {
// Also instead of retaining the esbuild context, we are re-running the entire build on each change.
// This reduces memory usage since most projects don't need to be re-built often.
const result = await buildOnce(options);
if (result.errors.length === 0) {
await didBuild?.();
}
} catch (error) {
console.error('[watch] build error:', error);
}
}, 100);
};
const watcher = await import('@parcel/watcher');
// Ignore the build's own output directory so emitted files never re-trigger the watcher
// (which would cause an infinite rebuild loop when `outdir` lives inside `srcDir`).
const ignore = ['**/node_modules/**', '**/dist/**', '**/out/**'];
if (options.outdir) {
// `@parcel/watcher` matches `ignore` entries as globs with forward slashes, so normalize the
// path separators and append `/**` so that every file emitted inside `outdir` is ignored too.
const outdirGlob = options.outdir.replace(/\\/g, '/').replace(/\/$/, '');
ignore.push(outdirGlob, `${outdirGlob}/**`);
}
await watcher.subscribe(srcDir, (_err, _events) => {
rebuild();
}, {
ignore
});
rebuild();
}