Commit Graph

473 Commits

Author SHA1 Message Date
Matt Bierner
011836a150 Prototyping custom editors (#77789)
* Custom Editor exploration

For #77131

Adds a prototype of custom editors contributed by extensions. This change does the following:

- Introduces a new contribution point for the declarative parts of a custom editor
- Adds API for registering a webview editor provider. This lets VS Code decided when to create a webview editor
- Adds an `openWith` command that lets you select which editor to use to open a resource from the file explorer
- Adds a setting that lets you say that you always want to use a custom editor for a given file extension
- Hooks up auto opening of a custom editor when opening a file from quick open or explorer
- Adds a new extension that contributes a custom image preview for png and jpg files

Still needs a lot of UX work and testing. We are also going to explore a more generic "open handler" based approach for supporting custom editors

Revert

* Re-use existing custom editor if one is already open

* Don't re-create custom editor webview when clicking on already visible custom editor

* Move customEditorInput to own file

* First draft of serializing custom editor inputs

* Use glob patterns instead of simple file extensions for matching custom resoruces for custom editors

* Add descriptions

* Try opening standard editor while prompting for custom editor

* Make sure we hide image status on dispose

* Make sure we restore editor group too

* Use glob patterns for workbench.editor.custom

* Allow users to configure custom editors for additional file types

* Use filename glob instead of glob on full resource path

* Adding placeholder for prompt open with

* Add enableByDefault setting for editor contributions

* Enable custom editors by default and add `discretion` enum

Changes `enableByDefault` boolean to a `discretion` enum. This should give more flexibility if we want other options (such as forcing a given custom editor to always be used even if there are other default ones)

* Allow custom editors to specify both a scheme and filenamePattern they are active for

* Rework custom editor setting

* Don't allow custom editors to be enabled for all resources by a config mistake

* Replace built-in image editor with one from extension

* Adding reopen with command

* Improve comment

* Remove commented code

* Localize package.json and remove image

* Remove extra lib setting from tsconfig
2019-09-10 17:56:57 -07:00
Johannes Rieken
5a9913099c undo usage of tsProjectSrc-stream 2019-09-10 14:58:08 +02:00
Johannes Rieken
c695729eb1 remove gulp-tsb hack, fixes #80629 2019-09-10 14:51:46 +02:00
Johannes Rieken
9ab449f3bd use tsb 4.0.2 use project files as src-stream, https://github.com/microsoft/vscode/issues/80632 2019-09-10 12:48:04 +02:00
Benjamin Pasero
0030e6ee92 🆙 terser@4.3.1 (#80627) 2019-09-10 10:57:54 +02:00
Rob Lourens
bb02180904 Delay gulp-watch read so watch task isn't broken on slower disks.
vscode writes files non-atomically. This is useful on an azure devbox over ssh.
2019-09-09 14:39:13 -07:00
isidor
a33e554693 adopt registerAndGetAmdImageURL
fixes #80563
2019-09-09 18:15:11 +02:00
Alex Dima
1ba4dc6954 Introduce registerAndGetAmdImageURL and inline such images in the bundle phase in .js 2019-09-09 17:17:12 +02:00
Alex Dima
7b4c75560d Merge remote-tracking branch 'origin/master' into alex/editor-options 2019-09-06 22:03:38 +02:00
Johannes Rieken
2b46fe4c30 adopt gulp-tsb 4.0.0, remove postinstall hacks 2019-09-06 17:21:36 +02:00
Alex Dima
e787da13c3 Merge remote-tracking branch 'origin/master' into alex/editor-options 2019-09-04 12:54:28 +02:00
Joao Moreno
5d7c8d9212 fix i18n for extensions 2019-09-04 08:05:47 +02:00
Matt Bierner
cf446b9233 Build VS Code using TS 3.6
Fixes #80079

Updates our build to use TS 3.6. Fixes a few changes to dom apis and adds a monkey patch for the node typings break in 3.6
2019-09-02 21:27:52 -06:00
Alex Dima
363b976941 Convert more editor options 2019-09-02 23:05:00 +02:00
Benjamin Pasero
c7d4c3ce1b Use terser for minification (#80201)
* build - minify using terser

* fix minification issues

* build ffs

* Update .cachesalt

* add comment
2019-09-02 11:19:26 +02:00
Benjamin Pasero
ccd6d203a0 tslint - also show warning when using NodeJS type 2019-08-22 20:04:00 +02:00
Benjamin Pasero
de04dc374f tslint - move rules 2019-08-22 08:05:22 +02:00
Johannes Rieken
8d70c559e5 npm installing 2019-08-21 18:05:31 +02:00
Benjamin Pasero
da25e0802a tslint - polish rule (support multiple declarations) 2019-08-21 17:19:33 +02:00
Benjamin Pasero
90a35ecc5d TSLint: show a warning when accessing node.js globals in common|browser (#79222)
* trivial first cut

* document where globals are from

* improve rule detection

* fix "gulp tslint" task

* share rules

* enable more rules

* also add a rule for DOM
2019-08-19 17:13:18 +02:00
Joao Moreno
2278f87c1c fixes #78159 2019-08-12 16:45:12 +02:00
Yisrael Veller
f084f2c793 Reuse never show again logic - work in progress (#73968)
* Support never show again option in notification service

* in notify put never show again as secondary

* Allow customization of whether never show again is shown as secondary or primary

* put never show again inside notification object

* feedback

* feedback
2019-08-08 15:47:15 +02:00
Alex Dima
135c473ddf Fixes #77454:
- do not cary over unnecessary "extends" in tsconfig.json
- keep members ending with `Brand`, but do it at the right phase
- remove shorthand literal usage which confuses tree-shaker
- add back noImplicitAny
2019-07-29 15:39:29 +02:00
Joao Moreno
c96cf5d4d9 fixes #76508 2019-07-26 16:08:27 +02:00
Benjamin Pasero
9e09089a19 eng - bump gulp-watch to stay compatible with our node version 2019-07-15 15:09:22 +02:00
Joao Moreno
7181bf6820 Merge branch 'master' into joao/build-cleanup 2019-07-15 07:32:11 +02:00
Benjamin Pasero
1648e1dcf8 web - add build 2019-07-14 13:12:54 +02:00
Joao Moreno
28c01d3b52 move upload sourcemaps to common agent 2019-07-14 10:31:07 +02:00
Benjamin Pasero
4330dd0eb4 compile leftover 2019-07-11 12:21:14 +02:00
Sandeep Somavarapu
0df6764710 move file service to platform 2019-07-10 20:55:44 +02:00
Alex Dima
cb3b792b50 Fixes #70205: Switch to polling based watcher that does not miss events 2019-07-05 18:11:44 +02:00
Joao Moreno
b4add9fcaa remove gulp sequence 2019-07-05 16:11:50 +02:00
Joao Moreno
b472feaafa add node build script 2019-07-02 08:45:47 +02:00
Joao Moreno
9d75c4e528 cleanup node tasks 2019-07-01 15:20:38 +02:00
Joao Moreno
399ff1a2fe gulp ci build task 2019-07-01 12:24:33 +02:00
Joao Moreno
e2289d05da fix relative path 2019-07-01 12:01:47 +02:00
Joao Moreno
a78e60f67f missing compilation 2019-07-01 11:56:07 +02:00
Joao Moreno
0678cb9ed3 build: remove old extensions build task, split extensions into gulp task 2019-07-01 11:54:36 +02:00
Sandeep Somavarapu
664dacc8b2 move connection auth token out of web configuration 2019-06-19 12:30:16 +02:00
Sandeep Somavarapu
021839444b take web related changes 2019-06-19 11:55:53 +02:00
Aurélien Pupier
7a5bca9faf Add License field to package.jsons #68423 (#68771)
it should avoid to have "warning XXX: No license field" during yarn
build

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
2019-06-06 11:44:50 +02:00
Waldir Pimenta
f3e4e47164 Fix spelling of the example abbreviation (e.g.) 2019-06-05 16:00:26 +02:00
Johannes Rieken
6f1da34c2e debt - decouple webviews from code insets, move things to /browser/-layer, change inset api proposal to push style, re #66418 2019-06-04 12:31:18 +02:00
Benjamin Pasero
73643c60a6 Update to Electron 4.0.x (#73119)
* Bump electron@4.0.0-beta.9

* electron 4 - temporarily warn about exploration change

* update to Electron 4.0.0 stable

* remove electron 4 notification

* bump to electron@4.0.1

* electron 4: adopt format change of "version" file

* build - set to use exploration image

* Revert "build - set to use exploration image"

This reverts commit 1bb280fc5e.

* electron@4.0.2

* fix electron.d.ts

* update distro

* bump electron@4.0.4

* debt - adopt new process.getProcessMemoryInfo()

* update electron@4.0.5

* electron@4.0.6

* electron 4.0.x - remove Linux 32bit build

* electron@4.0.7

* electron - update to 4.1.2

* bump electron@4.1.4

* update build (remove Linux32)

* electron@4.1.5

* electron 4 - remove linux 32bit warning

* Remove more 32-bit Linux build stuff

Fixes #66271

* electron@4.2.0

* electron@4.2.1

* electron@4.2.2

* electron@4.2.3

* Revert "electron@4.2.3"

This reverts commit ae375ef764.

* Revert "Revert "electron@4.2.3""

This reverts commit 513581ebc5.
2019-06-04 10:50:10 +02:00
Alex Dima
9bcd00284b Add remote.contribution 2019-05-22 11:50:49 +02:00
Joao Moreno
a477e1eafe extract native modules ignore rules 2019-05-09 16:27:37 +02:00
Peng Lyu
b72fba1a56 Fix Monaco compilation (#73243)
* Fix Monaco tsconfig parsing failure and Monaco compilation.
2019-05-03 10:59:50 -07:00
Benjamin Pasero
d5e88fa051 files - more cleanup 2019-04-16 14:40:19 +02:00
Alex Dima
fd8b829e83 Hold back test extensions 2019-04-11 12:34:05 +02:00
Keyi Xie
172a32d5c6 fix mispell 2019-04-09 13:21:46 +08:00