Commit Graph

116133 Commits

Author SHA1 Message Date
Daniel Imms
d7b119fc34 Fix sticky scroll positioning to avoid bg leaking through
Fixes #198352
2023-11-15 12:49:40 -08:00
Daniel Imms
35fbd62c0f Add command nav hint to sticky scroll hover
Fixes #198013
2023-11-15 12:46:08 -08:00
Matt Bierner
8943ea4790 Fix markdown code block styling (#198351)
Fixes #198183

Remove extra background and also removes the extra divs inside of the code blocks as these were causing issues with styling (extra padding)
2023-11-15 21:03:04 +01:00
Megan Rogge
65b8f67d91 Merge pull request #198345 from microsoft/merogge/close-on-keypress
add `AccessibleViewCloseOnKeyPress` setting, move editor help code to separate file
2023-11-15 11:19:28 -08:00
Logan Ramos
eca3d313b2 Fix regression in paste context menu (#198346) 2023-11-15 20:11:50 +01:00
rebornix
afe429c5f5 Listen to inline and dismiss on cell properly 2023-11-15 11:09:41 -08:00
Rob Lourens
23fc07c5b1 Simplify ChatModel more (#198344)
* Simplify ChatModel further

* Simplify ChatModel more

* Remove helper

* Clean up

* Fix addCompleteRequest

* Fix updateRepr
2023-11-15 11:07:14 -08:00
meganrogge
bff6047b68 fix #197792 2023-11-15 10:44:20 -08:00
Henning Dieterichs
f26376f1f5 Removes unneeded monaco-editor-esm-bundle 2023-11-15 19:41:53 +01:00
Connor Peet
a0b548807a eng: add assertHeap method for memory assertions (#198334)
This adds an `assertHeap` function that can be used in tests. It
takes a heap snapshot, and asserts the state of classes in memory. This
works in Node and the Electron sandbox, but is a no-op in the browser.
Snapshots are process asynchronously and will report failures at the end
of the suite.

This method should be used sparingly (e.g. once at the end of a suite to
ensure nothing leaked before), as gathering a heap snapshot is fairly
slow, at least until V8 11.5.130 (https://v8.dev/blog/speeding-up-v8-heap-snapshots).

When used, the function will ensure the test has a minimum timeout
duration of 20s to avoid immediate failures.

It takes options containing a mapping of class names, and assertion functions
to run on the number of retained instances of that class. For example:

```ts
assertSnapshot({
	classes: {
		ShouldNeverLeak: count => assert.strictEqual(count, 0),
		SomeSingleton: count => assert(count <= 1),
	}
});
```

Closes https://github.com/microsoft/vscode/issues/191920
2023-11-15 10:41:22 -08:00
Daniel Imms
8cac42ebe2 Merge pull request #197099 from hamirmahal/feat/allow-keyboard-shortcut-creation-for-terminal-copy-commands
feat: allow keyboard shortcut creation for terminal copy commands
2023-11-15 09:44:54 -08:00
meganrogge
0edd8b42db tweak name 2023-11-15 09:29:40 -08:00
meganrogge
1d592f0a15 rename command 2023-11-15 09:25:08 -08:00
Megan Rogge
a50d46966f Merge branch 'main' into feat/allow-keyboard-shortcut-creation-for-terminal-copy-commands 2023-11-15 09:19:27 -08:00
meganrogge
c3783ace0f fix #188145 2023-11-15 09:16:50 -08:00
Megan Rogge
9998f639c0 Merge pull request #198337 from microsoft/merogge/task-folder
use `cwd` if it exists in task presentation options
2023-11-15 09:13:57 -08:00
meganrogge
7c2c501bbb fix #198310 2023-11-15 08:55:59 -08:00
David
2938e5d611 Add TMLanguage aliases to YAML (#198300) 2023-11-15 16:52:22 +00:00
Ladislau Szomoru
13cc577605 SCM - another attempt to fix getParent() (#198328) 2023-11-15 08:51:19 -08:00
Daniel Imms
36819f9339 Merge pull request #198327 from microsoft/tyriar/198224
Terminal sticky scroll context menu
2023-11-15 08:28:02 -08:00
Henning Dieterichs
e2670a457f Fixes "_b is not defined" error 2023-11-15 16:53:00 +01:00
Henning Dieterichs
4cbf4fa126 StandaloneAccessibleNotificationService 2023-11-15 16:53:00 +01:00
Henning Dieterichs
9ac90beb07 Always report monaco loading errors 2023-11-15 16:53:00 +01:00
Rob Lourens
9a5c293103 Remove toString eslint rule for now (#198326)
It's too slow to run in pre-commit
2023-11-15 16:52:11 +01:00
Daniel Imms
392b6de662 Merge pull request #198321 from microsoft/tyriar/obscure
Improve performance and don't obscure output while scrolling pagers
2023-11-15 07:48:45 -08:00
Daniel Imms
0864f3963e Terminal sticky scroll context menu
Fixes #198224
2023-11-15 07:45:34 -08:00
Daniel Imms
a1d520d9eb Also handle (END) for detecting pagers
Fixes #198314
2023-11-15 07:01:11 -08:00
Jacob Bandes-Storch
6855ba045b Update Swift grammar and upstream repository (#197470)
* Update Swift grammar and upstream repository

* update grammar for bug fix

* Update Swift cgmanifest

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
2023-11-15 15:59:29 +01:00
Daniel Imms
b0fa5e7ff6 Improve performance and don't obscure output in pagers
Fixes #198314
2023-11-15 06:57:14 -08:00
Daniel Imms
110e7886e2 Merge pull request #198316 from microsoft/tyriar/198313
Focus terminal after clicking sticky scroll
2023-11-15 06:49:07 -08:00
Daniel Imms
133726500b Merge pull request #198315 from microsoft/tyriar/198245
Allow navigating to current command if executed marker exists
2023-11-15 06:43:33 -08:00
Daniel Imms
d3aba242ca Focus terminal after clicking sticky scroll
Fixes #198313
2023-11-15 06:24:46 -08:00
Daniel Imms
2a5e0103ef Allow navigating to current command if executed marker exists
Fixes #198245
2023-11-15 06:21:59 -08:00
Ladislau Szomoru
e0b70e58b3 SCM - add caching layer to incoming/outgoing tree nodes (#198306)
* Upstream commit + improve onDidChangeCurrentHistoryItemGroup

* Refactor expanding a history item group

* Wire up caching

* Invoking the git.refresh command invalidates the cache

* Clean up cache data structure
2023-11-15 15:09:18 +01:00
Ladislau Szomoru
43b0558cc1 SCM - fix edge case when expanding the tree (#198294) 2023-11-15 13:28:25 +01:00
Benjamin Pasero
fd80237082 aux window - cleanup layout service (#198292) 2023-11-15 13:10:40 +01:00
Benjamin Pasero
ce711aae31 aux window - introduce and adopt ILayoutService.mainContainer (#198288) 2023-11-15 12:31:20 +01:00
Benjamin Pasero
b6b7a942bd aux window - improve DND (#198286) 2023-11-15 11:47:08 +01:00
Henning Dieterichs
59b1480f1e Merge pull request #198227 from hsfzxjy/inline-suggest-show-toolbar-never-198070
Add inlineSuggest.showToolbar.never
2023-11-15 10:50:11 +01:00
Benjamin Pasero
3d0503d96a Progress bar is not below editor title anymore (fix #198176) (#198280) 2023-11-15 10:08:09 +01:00
Ole
b3a649fe52 Remove cycle browserHostService.ts -> web.api.ts. (#198221)
* Remove cycle  browserHostService.ts -> web.api.ts.

Before this change, `IWorkbenchConstructionOptions` in web.api.ts
depended on `IWorkspaceProvider` in browserHostService.ts, which
depends on some types from web.api.ts.

While this apparently does not pose problems in VS Code's build, other
build system of downstream projects do not allow this, and it is also
overall harder to follow the code if "the API" depends on types defined
in ""the implementation".

* Fix one reference I missed
2023-11-15 07:17:50 +00:00
Arvid Lunnemark
0bc6184910 fix blank settings page (#198261) 2023-11-14 23:16:25 -08:00
Peng Lyu
beb804d1d2 Merge pull request #198272 from microsoft/rebornix/ambitious-pigeon
💄 better handling optional
2023-11-14 23:07:23 -08:00
rebornix
2fd988f075 early return for cancelled request 2023-11-14 23:06:16 -08:00
rebornix
a9954e0ddf Handle code cell editor async ctor 2023-11-14 23:04:23 -08:00
rebornix
77f41a2558 Update styles 2023-11-14 22:45:28 -08:00
Benjamin Pasero
1368f2a052 dom - use getWindow in more places (#198269) 2023-11-14 22:20:49 -08:00
Benjamin Pasero
d2d14e541e aux window - cleanup merge on close (#198268) 2023-11-14 22:18:20 -08:00
rebornix
bed797335d 💄 better handling optional 2023-11-14 22:17:15 -08:00
rebornix
c9b730cb98 styling update 2023-11-14 22:06:55 -08:00