328 Commits

Author SHA1 Message Date
Logan Ramos
4687600147
oss tool (#280470) 2025-12-02 00:12:19 +00:00
Josh Spicer
6cc2564bf9
remote: configurable 'reconnection grace time' (#274910)
* reconnection grace period prototype

* plumb through CLI

* polish

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-12 18:51:28 -08:00
Josh Spicer
b96e6d762c
allow update endpoint in rs cli to be configurable by env var (#276761) 2025-11-11 10:23:39 -08:00
Christof Marti
4e9b8174e1 Run OSS tool 2025-11-03 19:33:06 +01:00
Matt Bierner
aa3730584d
Run oss tool 2025-09-29 16:55:08 -07:00
Sandeep Somavarapu
c738ec6c40
run oss tool (#265291)
* run oss tool

* update distro
2025-09-05 08:25:46 +00:00
Sandeep Somavarapu
39512dc164
run oss tool (#264319) 2025-09-01 13:21:14 +02:00
Justin Wang
b0271fa725
Fix --commit-id flag for code serve-web (#258904)
* Fix --commit-id flag for code serve-web

Fixes a bug where passing --commit-id during `code serve-web` would
prevent serve-web from downloading a new version of the client at all.

* Update cli/src/commands/serve_web.rs

---------

Co-authored-by: Connor Peet <connor@peet.io>
2025-07-31 16:52:39 +00:00
Osvaldo Ortega
20de00cb1b
OSS tool run for endgame 2025-07-28 10:34:40 -07:00
Copilot
90072b47cf
Fix serve-web port randomization when --port 0 is specified (#254676)
* Initial plan

* Fix serve-web port randomization when --port 0 is specified

Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>

* Fix serve-web to display actual bound port instead of 0

When --port 0 is specified, the OS assigns a random port but the
logging was showing port 0 instead of the actual assigned port.
Fixed by reading the local_addr() from the server builder after binding.

Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>
2025-07-22 13:35:24 -07:00
Justin Wang
b4d1fec915
Add commit_id option to ServeWebArgs for specific client version (#255494)
* Add commit_id option to ServeWebArgs for specific client version

* Don't start serve-web update checker if given commit-id
2025-07-14 06:12:36 +00:00
Alex Ross
855c8cb8ac
Run OSS tool (#252952)
* Run OSS tool

* bump distro
2025-06-30 11:58:18 +02:00
S. M. Mohiuddin Khan Shiam
70f8e0e38f
Fix incorrect SHA-1 commit regex in [version_manager.rs](cci:7://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:0:0-0:0) (#251329)
The CLI’s `RequestedVersion::Commit` parser rejected many valid commit hashes and allowed invalid ones due to an erroneous regular expression:

* **Old pattern:** `^[a-e0-f]{40}$`
  * Allowed non-hex characters outside the `a–f` range
  * Excluded the valid hex digit `f` and any uppercase letters
* **New pattern:** [(?i)^[0-9a-f]{40}$](cci:1://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:102:1-107:2)
  * [(?i)](cci:1://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:102:1-107:2) enables case-insensitive matching (accepts `A–F`)
  * Character class now correctly restricts input to hexadecimal digits `0-9` and `a-f`
  * Ensures the string is exactly 40 characters, matching a valid SHA-1

#### Impact

`code version use <commit>` and related commands could silently fail or accept malformed commit IDs, leading to unexpected version resolution behavior.
With this fix, only valid 40-character hexadecimal commit hashes are accepted, restoring reliable version selection and preventing subtle bugs.

#### Notes

No API changes; the fix is a single-line update in [cli/src/desktop/version_manager.rs](cci:7://file:///d:/Github/vscode/cli/src/desktop/version_manager.rs:0:0-0:0).
2025-06-13 15:40:55 +00:00
Robo
6947b69d47
fix: revert remote libcxx requirement to 3.4.25 (#248976)
* fix: revert libcxx requirement to 3.4.25

* ci: temp debugging

* fix: use gcc 8.5.0 for remote

* ci: update cache

* ci: fix sysroot directory

* ci: fix objdump directory
2025-05-14 20:10:32 -07:00
Robo
12326f9906
chore: update to Electron 35 (#245423)
* chore: bump electron@35.0.1

* chore: update types/node@22.x

* chore: update web types for node v22.x

* chore: bump electron@35.1.2

* chore: update node.js build

* chore: update app.dock usage

Refs 71f3ff6bf2

* chore: bump electron@35.1.4

* chore: bump electron@35.1.5

* ci: bump sysroot to glibc 2.28 and gcc 10.5.0

* ci: enable timeout for smoketests

* chore: bump min glibcxx to 3.4.26 for server

* Revert "ci: enable timeout for smoketests"

This reverts commit afb637e85dfb6c553c0e76ccc7063b5c8cf550bb.

* chore: update debian dependencies

* fix: workaround npm.ps1 argument parsing with powershell

* chore: update rpm dependencies

* test: partially revert changes from 242535

* test: remove redudant keybinding dispatch for selectTab

* test: fix test failure from running configured tasks

* test: focus settings editor for preferences.test.ts

* node - adopt compile cache (#246835)

* node - adopt compile cache

* adopt for utility process

* tweaks

* log state of compilation cache

* Revert "log state of compilation cache"

This reverts commit f3840387a583013834762e2c44f6e8424929297f.

* Revert "node - adopt compile cache (#246835)"

This reverts commit 673a00cab66c9bac87f3cd27b80efa41c80150f1.

* chore: update builds

* chore: bump electron@35.2.0

* chore: bump electron@35.2.1

* chore: bump electron@35.2.2

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2025-05-09 19:03:36 +09:00
Ladislau Szomoru
a73a3243c2
Engineering - OSS tool result (#247379) 2025-04-25 14:37:01 +02:00
dependabot[bot]
87bb001971
Bump crossbeam-channel from 0.5.13 to 0.5.15 in /cli (#246213)
Bumps [crossbeam-channel](https://github.com/crossbeam-rs/crossbeam) from 0.5.13 to 0.5.15.
- [Release notes](https://github.com/crossbeam-rs/crossbeam/releases)
- [Changelog](https://github.com/crossbeam-rs/crossbeam/blob/master/CHANGELOG.md)
- [Commits](https://github.com/crossbeam-rs/crossbeam/compare/crossbeam-channel-0.5.13...crossbeam-channel-0.5.15)

---
updated-dependencies:
- dependency-name: crossbeam-channel
  dependency-version: 0.5.15
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-14 10:42:53 +02:00
dependabot[bot]
74e9aabf76
Bump tokio from 1.37.0 to 1.38.2 in /cli (#245924)
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.37.0 to 1.38.2.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.37.0...tokio-1.38.2)

---
updated-dependencies:
- dependency-name: tokio
  dependency-version: 1.38.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-14 10:42:21 +02:00
dependabot[bot]
6c707c80c8
Bump openssl from 0.10.70 to 0.10.72 in /cli
Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.70 to 0.10.72.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](https://github.com/sfackler/rust-openssl/compare/openssl-v0.10.70...openssl-v0.10.72)

---
updated-dependencies:
- dependency-name: openssl
  dependency-version: 0.10.72
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-04 20:52:20 +00:00
Connor Peet
e166b219d8
cli: make the build faster (#245705)
codegen-units=1 lets the compiler optimize more aggressively, but it
makes things _much_ slower. The benefits of this has been evaporating
as the compiler has improved, and now that the CLI build is a bottleneck,
let's just remove it.
2025-04-04 20:43:48 +02:00
Aaron Munger
cf21b3df5f
OSS tool run result (#244471)
Co-authored-by: amunger <>
2025-03-24 09:21:32 -07:00
Robo
e9a3e2a03c
fix: libc checks for exec server (#243254) 2025-03-11 12:54:24 -07:00
Robo
31ec1c528f
build: remove legacy server support (#235232)
* build: remove legacy server support

* chore: update rpm dependencies

* chore: fix publishing

* cli: provide option for unsupported glibc sysroot

* chore: add unsupported mode to prereq check

* chore: add logging

* chore: add comment about patchelf execution order
2025-03-10 17:54:23 +01:00
Connor Peet
3331d2d87d
chore: update to rust 1.85 (#242609) 2025-03-04 21:58:23 +01:00
Martin Aeschlimann
649a74e7d8
Update third party licenses for 1.98 (#241806)
* Update third party licenses for 1.98

* update
2025-02-25 11:42:35 +00:00
M Hickford
c515f75608 Log provider in "tunnel user show" 2025-02-11 19:53:57 +00:00
Connor Peet
90e4da155a
cli: remove unsupported arguments from serve-web (#239731)
Fixes #238303
2025-02-05 13:20:23 -08:00
dependabot[bot]
d04d44610f
Bump openssl from 0.10.66 to 0.10.70 in /cli (#239517)
Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.66 to 0.10.70.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](https://github.com/sfackler/rust-openssl/compare/openssl-v0.10.66...openssl-v0.10.70)

---
updated-dependencies:
- dependency-name: openssl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-04 08:05:29 -08:00
Connor Peet
ba815c5c82
eng: rev TPN for 1.97 (#238902) 2025-01-27 23:40:37 +01:00
Connor Peet
e2e9a7306b
cli: update url to 2.5.4 for dependabot (#237417) 2025-01-07 18:37:48 +01:00
Connor Peet
eee5e7643a
cli: propagate server-data-dir and extensions-dir when installing service (#236734)
Fixes #236195
2024-12-20 10:29:40 -08:00
Connor Peet
3e86f1e6cd
cli: fix serve-web needs to wait a certain amount of time after machine startup (#236427)
Fixes #233155
2024-12-18 01:38:47 +01:00
aslezar
386d58d0de
fixed formattting error 2024-12-16 20:49:25 +05:30
aslezar
5c525a4d56
fixed formatting 2024-12-15 16:54:08 +05:30
aslezar
e044a71719
Fix incorrect GLIBC version parsing
Fixes #230370
2024-12-13 22:22:13 +05:30
Sandeep Somavarapu
4920694ece
fix #234843 (#235955)
* fix #234843

* fix lint error
2024-12-12 16:48:37 +01:00
Dirk Baeumer
8a7bbaf943
Run OSS license tool 2024-12-03 09:47:36 +01:00
benshi
4e2855ff7f
Cli serve_web sets the path prefix to /<quality>-<commit>/, commit value parsing error (#233986)
fix #233984
2024-11-17 04:34:54 +00:00
Sandeep Somavarapu
653fd419de
#232043 revert cli command and support downloading VSIX in UI (#233843)
* Revert "fix #232043 (#233596)"

This reverts commit e9d6c6afc0b99827d7732099ced7e3bb3101ca4c.

* #232043 revert cli command and support downloading VSIX in UI
2024-11-14 15:41:28 +01:00
Connor Peet
c4efcbdfb4
cli: remove stray debug log (#233714) 2024-11-12 10:42:28 -08:00
Sandeep Somavarapu
e9d6c6afc0
fix #232043 (#233596)
* fix #232043

* fix compilation error

* fix compilation

* fix compilation

* fix compilation

* fix compilation

* fix compilation
2024-11-12 14:09:05 +01:00
Raymond Zhao
22b0035d32
chore: add guard:cf flags to CLI (#232452) 2024-10-29 11:51:22 -07:00
Hamir Mahal
a744313eb7
style: simplify string formatting for readability (#231763)
* style: simplify string formatting for readability

* fix: formatting in `.rs` files in `src/`
2024-10-22 16:30:46 +00:00
Raymond Zhao
d5baf34009
Revert "fix: CLI is missing guard:cf flags" (#231874)
Revert "fix: CLI is missing guard:cf flags (#231863)"

This reverts commit 1e580bc97d257512ac07b494d485b877a2d3372c.
2024-10-21 12:48:49 -07:00
Raymond Zhao
1e580bc97d
fix: CLI is missing guard:cf flags (#231863) 2024-10-21 19:53:34 +02:00
Benjamin Pasero
3d6f6d2df3
run OSS license tool (#229904)
* run OSS license tool

* bump distro
2024-09-27 06:21:02 +02:00
Benjamin Pasero
2815397248
eng - update licenses 2024-09-23 11:26:22 +02:00
Connor Peet
061cbf557f
cli: add server-data-dir and extensions-dir on command-shell (#228287) 2024-09-12 17:06:42 +02:00
Connor Peet
4d221c6b85 cli: reapply "code server-web when offline" 2024-09-09 09:18:56 -07:00
Robo
746ba5bc68
cli: revert "code server-web when offline" (#227981)
* Revert "Merge pull request #227830 from microsoft/connor4312/cli-offline-serve"

This reverts commit 136a5c6f5fdd19966ddb36f8aef080a6e94706a7, reversing
changes made to 9d388bbf8bf9ac0c3c978ec84431eee302cb7712.

* chore: bump distro
2024-09-09 16:21:08 +02:00