36 Commits

Author SHA1 Message Date
Dmitriy Vasyura
f2f21a56ea Remove Map/Set eslint rule 2025-11-25 11:00:09 -08:00
Dmitriy Vasyura
535f6eaa0f
Merge branch 'main' into dev/dmitriv/eslint-map-delete 2025-11-21 11:34:34 -08:00
Matt Bierner
2648263d3e
Run our build scripts directly as typescript (#277567)
* Run our build scripts directly as typescript #277567

Follow up on #276864
For #277526

* Remove a few more ts-node references

* Fix linux and script reference

* Remove `_build-script` ref

* Fix script missing closing quote

* use type only import

* Fix export

* Make sure to run copy-policy-dto

* Make sure we run the copy-policy-dto script

* Enable `verbatimModuleSyntax`

* Pipelines fixes

* Try adding explicit ext to path

* Fix bad edit

* Revert extra `--`

---------

Co-authored-by: João Moreno <joaomoreno@users.noreply.github.com>
2025-11-21 14:56:00 +01:00
Dmitriy Vasyura
fbef8a93e9 Add eslint rule to prevent Map.has call immediately before Map.delete 2025-11-21 01:12:58 -08:00
Rob Lourens
676ae78fa5
Fix localized tool markdownDescriptions (#277589)
* Fix localized tool markdownDescriptions
And add a lint rule

* Just keep this the same

* Fixes
2025-11-15 13:12:37 -08:00
Tyler James Leonhardt
8711dcb9da
Fix offending l10n.t call and add an eslint rule to prevent it from happening (#277577)
ref https://github.com/microsoft/vscode/issues/277576
2025-11-14 18:13:03 -08:00
Matt Bierner
22663c3fe7
Small cleanup 2025-11-14 14:39:44 -08:00
Matt Bierner
b8329a3ffc
Run TS eslint rules directly with strip-types
Wth node 20.18, we can now run these typescript files directly instead of having to use ts-node
2025-11-14 14:38:15 -08:00
Matt Bierner
75c7c38a9d
Simpler fix 2025-11-10 13:52:43 -08:00
Matt Bierner
1d2bb43237
Reduce any typings in our eslint rules 2025-11-10 13:49:24 -08:00
Matt Bierner
b7b11cf3d1
Use config to disable rule in tests 2025-10-29 11:42:15 -07:00
Johannes Rieken
478b33a153
Add eslint rule for no in-operator (#273779)
* add no-in-operator rule, config, and ignore-list

* add `hasKey` util and tests

* updates

* sample adoption, no `in` in strings.ts
2025-10-28 17:51:49 +01:00
Paul
80d650774b
Add eslint rule for policy localization (#272334) 2025-10-27 12:03:18 -07:00
Matt Bierner
001632a7f7
Fix weird typings
Fixes an overly generic eslint selector. This lets us remove a weird typing workaround
2025-10-24 14:30:03 -07:00
Matt Bierner
f6e388e29e
Update .eslint-plugin-local/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-16 16:48:02 -07:00
Matt Bierner
0a4864aa7f
Update .eslint-plugin-local/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-16 16:47:53 -07:00
Matt Bierner
98503adeeb
Update .eslint-plugin-local/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-16 16:47:42 -07:00
Matt Bierner
ba9828d1dc
Add custom eslint rules info as readme
Copying the wiki section into the repo too so tools and contributors can find it more easily
2025-10-16 16:46:09 -07:00
Matt Bierner
7a6864552e
Add example fix for unexternalized strings
Adds a fix (off by default) for converting double quoted to single quoted string
2025-10-15 14:06:59 -07:00
Matt Bierner
f4d1b11372
Fix all any casts in lint rules
For #269213

Also bumps eslint versions to fix some typing issues
2025-10-03 13:36:25 -07:00
Matt Bierner
a4fbc54f29
Use selectors instead to simplify and speed up rule 2025-10-02 23:44:14 -07:00
Matt Bierner
360c9fd134
Add lint rule for as any and bulk ignore all existing breaks
For #269213

This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks

Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
Henning Dieterichs
dace6b32b3
Implements code-no-observable-get-in-reactive-context (#267526)
* Implements code-no-observable-get-in-reactive-context

* Improves code

* Fixes lint warnings
2025-09-20 20:29:58 +02:00
Henning Dieterichs
824678f51e feat: add ESLint rule to prevent reader method calls after await 2025-09-18 16:20:52 -07:00
Matt Bierner
97b2c007cd
Migrate fully of moduleResolution node10
Fixes #265420
2025-09-09 11:08:41 -07:00
Matt Bierner
46433f1a75 Fix ms auth compile error 2025-09-05 14:52:25 -07:00
Matt Bierner
e51d57aa5c Update target for build and test scripts 2025-08-04 17:28:08 -07:00
Matt Bierner
d2a794a719 Migrate off of eslint-plugin-local
We can now do this natively
2025-07-08 13:09:17 -07:00
Benjamin Pasero
cdf404ff47
debt - restore old layer name (#250928) 2025-06-09 07:08:43 +00:00
Henning Dieterichs
13cf8e47af
Introduces code-no-deep-import-of-internal (#245143)
* Introduces code-no-deep-import-of-internal
2025-04-01 10:23:29 +02:00
Alex Dima
46035d0296
Split up the editor's worker and the editor worker helper scripts, remove AMD support 2025-03-20 18:37:55 +01:00
Matt Bierner
6b3e9f6759 Fix eslint not linting our custom eslint rules 2025-03-19 22:49:06 -07:00
Rob Lourens
94da87e5c9
Remove vscode-dts-region-comments (#239868)
This is from how the old vscode.proposed.d.ts was managed, and is no longer relevant
2025-02-06 17:45:08 -08:00
Matt Bierner
68ec60529e Require export on all vscode public api types
Adds new eslint rule which requires `export` be used for public api types

The `export` is not actually needed, but our existing typing files largely use it. This makes it consistent
2025-01-08 11:40:36 -08:00
Matt Bierner
489c180f25 Merge branch 'main' into dev/eslint-9 2024-10-02 14:50:59 -07:00
Matt Bierner
e456f4cb66 Start eslint 9 migration
For #230339

Starts migrating to eslint 9. Everything runs but it produces a number of errors
2024-10-02 14:45:28 -07:00