From eb17ea787b93ca626463d4aeeea1e659007c52fd Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Wed, 9 Dec 2015 07:44:30 +0100 Subject: [PATCH] fix some npes --- src/vs/base/common/strings.ts | 4 ++++ src/vs/base/parts/quickopen/browser/quickOpenModel.ts | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vs/base/common/strings.ts b/src/vs/base/common/strings.ts index adf4e815188..798109d729b 100644 --- a/src/vs/base/common/strings.ts +++ b/src/vs/base/common/strings.ts @@ -622,6 +622,10 @@ export function startsWithUTF8BOM(str: string): boolean { export function score(target: string, query: string): number { let score = 0; + if (!target || !query) { + return score; // return early if target or query are undefined + } + const queryLen = query.length; const targetLower = target.toLowerCase(); const queryLower = query.toLowerCase(); diff --git a/src/vs/base/parts/quickopen/browser/quickOpenModel.ts b/src/vs/base/parts/quickopen/browser/quickOpenModel.ts index 0e03be332f5..68a4fa14348 100644 --- a/src/vs/base/parts/quickopen/browser/quickOpenModel.ts +++ b/src/vs/base/parts/quickopen/browser/quickOpenModel.ts @@ -186,7 +186,7 @@ export class QuickOpenEntry { } } - return compareAnything(nameA, nameB, lookFor.toLowerCase()); + return compareAnything(nameA, nameB, lookFor ? lookFor.toLowerCase() : lookFor); } /**