From e57d444efe3cca2a288d3ebbf0952f0e23c0149c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Burzy=C5=84ski?= Date: Tue, 9 Dec 2025 15:23:31 +0100 Subject: [PATCH] Simplify `TestInstantiationService#stub` overloads --- .../instantiation/test/common/instantiationServiceMock.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts b/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts index 74f06923801..676541bf4d7 100644 --- a/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts +++ b/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts @@ -53,10 +53,8 @@ export class TestInstantiationService extends InstantiationService implements ID return super.createInstance(ctorOrDescriptor, ...rest); } - public stub(service: ServiceIdentifier, ctor: Function): T; - public stub(service: ServiceIdentifier, obj: Partial): T; - public stub(service: ServiceIdentifier, ctor: Function, property: string, value: V): V extends Function ? sinon.SinonSpy : sinon.SinonStub; - public stub(service: ServiceIdentifier, obj: Partial, property: string, value: V): V extends Function ? sinon.SinonSpy : sinon.SinonStub; + public stub(service: ServiceIdentifier, obj: Partial> | Function): T; + public stub(service: ServiceIdentifier, obj: Partial> | Function, property: string, value: V): V extends Function ? sinon.SinonSpy : sinon.SinonStub; public stub(service: ServiceIdentifier, property: string, value: V): V extends Function ? sinon.SinonSpy : sinon.SinonStub; public stub(serviceIdentifier: ServiceIdentifier, arg2: any, arg3?: string, arg4?: any): sinon.SinonStub | sinon.SinonSpy { const service = typeof arg2 !== 'string' ? arg2 : undefined;