From d3decc7eeff9e1cbf84e1c175afa8ab458403280 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Fri, 15 Dec 2017 16:15:38 -0800 Subject: [PATCH] Support isRecommended property for TS completion items Fixes #40325 --- .../typescript/src/features/completionItemProvider.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/extensions/typescript/src/features/completionItemProvider.ts b/extensions/typescript/src/features/completionItemProvider.ts index fb8fd36867d..0b2ee92783d 100644 --- a/extensions/typescript/src/features/completionItemProvider.ts +++ b/extensions/typescript/src/features/completionItemProvider.ts @@ -31,7 +31,11 @@ class MyCompletionItem extends CompletionItem { ) { super(entry.name); this.source = entry.source; - this.sortText = entry.sortText; + + // Make sure isRecommended property always comes first + // https://github.com/Microsoft/vscode/issues/40325 + this.sortText = entry.isRecommended ? '\0' : entry.sortText; + this.kind = MyCompletionItem.convertKind(entry.kind); this.position = position; this.commitCharacters = MyCompletionItem.getCommitCharacters(enableDotCompletions, !useCodeSnippetsOnMethodSuggest, entry.kind);