From bc52841fa70e51e9e795ae3a63fbfa5f87e8d680 Mon Sep 17 00:00:00 2001 From: Christof Marti Date: Wed, 25 Jan 2017 10:06:43 -0800 Subject: [PATCH] Streamline user-facing names --- src/vs/code/electron-main/menus.ts | 2 +- .../walkThrough/electron-browser/editor/editorWalkThrough.ts | 2 +- .../workbench/parts/welcomeOverlay/browser/welcomeOverlay.ts | 4 ++-- .../parts/welcomePage/electron-browser/welcomePage.html | 4 ++-- .../parts/welcomePage/electron-browser/welcomePage.ts | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/vs/code/electron-main/menus.ts b/src/vs/code/electron-main/menus.ts index b5611709dd8..356d6134b58 100644 --- a/src/vs/code/electron-main/menus.ts +++ b/src/vs/code/electron-main/menus.ts @@ -847,7 +847,7 @@ export class VSCodeMenu { const keyboardShortcutsUrl = platform.isLinux ? product.keyboardShortcutsUrlLinux : platform.isMacintosh ? product.keyboardShortcutsUrlMac : product.keyboardShortcutsUrlWin; arrays.coalesce([ - new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miWelcome', comment: ['&& denotes a mnemonic'] }, "&&Welcome")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.welcomePage') }), + new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miWelcome', comment: ['&& denotes a mnemonic'] }, "&&Welcome")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.showWelcomePage') }), product.documentationUrl ? new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miDocumentation', comment: ['&& denotes a mnemonic'] }, "&&Documentation")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.openDocumentationUrl') }) : null, product.releaseNotesUrl ? new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miReleaseNotes', comment: ['&& denotes a mnemonic'] }, "&&Release Notes")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'update.showCurrentReleaseNotes') }) : null, __separator__(), diff --git a/src/vs/workbench/parts/walkThrough/electron-browser/editor/editorWalkThrough.ts b/src/vs/workbench/parts/walkThrough/electron-browser/editor/editorWalkThrough.ts index 9c3c761a723..7a309c64c90 100644 --- a/src/vs/workbench/parts/walkThrough/electron-browser/editor/editorWalkThrough.ts +++ b/src/vs/workbench/parts/walkThrough/electron-browser/editor/editorWalkThrough.ts @@ -16,7 +16,7 @@ import { WALK_THROUGH_SCHEME } from 'vs/workbench/parts/walkThrough/node/walkThr export class EditorWalkThroughAction extends Action { - public static ID = 'workbench.action.editorWalkThrough'; + public static ID = 'workbench.action.showInteractivePlayground'; public static LABEL = localize('editorWalkThrough', "Interactive Playground"); constructor( diff --git a/src/vs/workbench/parts/welcomeOverlay/browser/welcomeOverlay.ts b/src/vs/workbench/parts/welcomeOverlay/browser/welcomeOverlay.ts index eb6af4167eb..63dbd5ebd50 100644 --- a/src/vs/workbench/parts/welcomeOverlay/browser/welcomeOverlay.ts +++ b/src/vs/workbench/parts/welcomeOverlay/browser/welcomeOverlay.ts @@ -96,7 +96,7 @@ const OVERLAY_VISIBLE = new RawContextKey('interfaceOverviewVisible', f export class WelcomeOverlayAction extends Action { - public static ID = 'workbench.action.welcomeOverlay'; + public static ID = 'workbench.action.showInterfaceOverview'; public static LABEL = localize('welcomeOverlay', "User Interface Overview"); constructor( @@ -118,7 +118,7 @@ export class WelcomeOverlayAction extends Action { export class HideWelcomeOverlayAction extends Action { - public static ID = 'workbench.action.hideWelcomeOverlay'; + public static ID = 'workbench.action.hideInterfaceOverview'; public static LABEL = localize('hideWelcomeOverlay', "Hide Interface Overview"); constructor( diff --git a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.html b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.html index bd837d74214..799ff7e65a4 100644 --- a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.html +++ b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.html @@ -34,13 +34,13 @@

Quick links

    -
  • +
  • -
  • +
diff --git a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts index 7887412d4df..6958311c5da 100644 --- a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts +++ b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts @@ -54,7 +54,7 @@ export class WelcomePageContribution implements IWorkbenchContribution { export class WelcomePageAction extends Action { - public static ID = 'workbench.action.welcomePage'; + public static ID = 'workbench.action.showWelcomePage'; public static LABEL = localize('welcomePage', "Welcome"); constructor(