diff --git a/src/vs/editor/browser/widget/codeEditorWidget.ts b/src/vs/editor/browser/widget/codeEditorWidget.ts index 88f890fe5b6..610d2b0547c 100644 --- a/src/vs/editor/browser/widget/codeEditorWidget.ts +++ b/src/vs/editor/browser/widget/codeEditorWidget.ts @@ -118,7 +118,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE //#region Eventing private readonly _deliveryQueue = new EventDeliveryQueue(); - protected readonly _contributions2: CodeEditorContributions = this._register(new CodeEditorContributions()); + protected readonly _contributions: CodeEditorContributions = this._register(new CodeEditorContributions()); private readonly _onDidDispose: Emitter = this._register(new Emitter()); public readonly onDidDispose: Event = this._onDidDispose.event; @@ -153,7 +153,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE private readonly _onDidChangeCursorSelection: Emitter = this._register(new Emitter({ deliveryQueue: this._deliveryQueue })); public readonly onDidChangeCursorSelection: Event = this._onDidChangeCursorSelection.event; - private readonly _onDidAttemptReadOnlyEdit: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onDidAttemptReadOnlyEdit: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onDidAttemptReadOnlyEdit: Event = this._onDidAttemptReadOnlyEdit.event; private readonly _onDidLayoutChange: Emitter = this._register(new Emitter({ deliveryQueue: this._deliveryQueue })); @@ -167,55 +167,55 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE public readonly onDidFocusEditorWidget: Event = this._editorWidgetFocus.onDidChangeToTrue; public readonly onDidBlurEditorWidget: Event = this._editorWidgetFocus.onDidChangeToFalse; - private readonly _onWillType: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onWillType: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onWillType = this._onWillType.event; - private readonly _onDidType: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onDidType: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onDidType = this._onDidType.event; - private readonly _onDidCompositionStart: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onDidCompositionStart: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onDidCompositionStart = this._onDidCompositionStart.event; - private readonly _onDidCompositionEnd: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onDidCompositionEnd: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onDidCompositionEnd = this._onDidCompositionEnd.event; - private readonly _onDidPaste: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onDidPaste: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onDidPaste = this._onDidPaste.event; - private readonly _onMouseUp: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseUp: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseUp: Event = this._onMouseUp.event; - private readonly _onMouseDown: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseDown: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseDown: Event = this._onMouseDown.event; - private readonly _onMouseDrag: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseDrag: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseDrag: Event = this._onMouseDrag.event; - private readonly _onMouseDrop: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseDrop: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseDrop: Event = this._onMouseDrop.event; - private readonly _onMouseDropCanceled: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseDropCanceled: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseDropCanceled: Event = this._onMouseDropCanceled.event; - private readonly _onDropIntoEditor = this._register(new InteractionEmitter<{ readonly position: IPosition; readonly event: DragEvent }>(this._contributions2, this._deliveryQueue)); + private readonly _onDropIntoEditor = this._register(new InteractionEmitter<{ readonly position: IPosition; readonly event: DragEvent }>(this._contributions, this._deliveryQueue)); public readonly onDropIntoEditor = this._onDropIntoEditor.event; - private readonly _onContextMenu: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onContextMenu: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onContextMenu: Event = this._onContextMenu.event; - private readonly _onMouseMove: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseMove: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseMove: Event = this._onMouseMove.event; - private readonly _onMouseLeave: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseLeave: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseLeave: Event = this._onMouseLeave.event; - private readonly _onMouseWheel: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onMouseWheel: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onMouseWheel: Event = this._onMouseWheel.event; - private readonly _onKeyUp: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onKeyUp: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onKeyUp: Event = this._onKeyUp.event; - private readonly _onKeyDown: Emitter = this._register(new InteractionEmitter(this._contributions2, this._deliveryQueue)); + private readonly _onKeyDown: Emitter = this._register(new InteractionEmitter(this._contributions, this._deliveryQueue)); public readonly onKeyDown: Event = this._onKeyDown.event; private readonly _onDidContentSizeChange: Emitter = this._register(new Emitter({ deliveryQueue: this._deliveryQueue })); @@ -332,7 +332,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE } else { contributions = EditorExtensionsRegistry.getEditorContributions(); } - this._contributions2.initialize(this, contributions, this._instantiationService); + this._contributions.initialize(this, contributions, this._instantiationService); for (const action of EditorExtensionsRegistry.getEditorActions()) { if (this._actions.has(action.id)) { @@ -512,7 +512,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE this._onDidChangeModel.fire(e); this._postDetachModelCleanup(detachedModel); - this._contributions2.onAfterModelAttached(); + this._contributions.onAfterModelAttached(); } private _removeDecorationTypes(): void { @@ -979,7 +979,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE if (!this._modelData) { return null; } - const contributionsState = this._contributions2.saveViewState(); + const contributionsState = this._contributions.saveViewState(); const cursorState = this._modelData.viewModel.saveCursorState(); const viewState = this._modelData.viewModel.saveState(); return { @@ -1005,7 +1005,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE this._modelData.viewModel.restoreCursorState([cursorState]); } - this._contributions2.restoreViewState(codeEditorState.contributionsState || {}); + this._contributions.restoreViewState(codeEditorState.contributionsState || {}); const reducedState = this._modelData.viewModel.reduceRestoreState(codeEditorState.viewState); this._modelData.view.restoreState(reducedState); } @@ -1021,7 +1021,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE } public getContribution(id: string): T | null { - return this._contributions2.get(id) as T | null; + return this._contributions.get(id) as T | null; } public getActions(): editorCommon.IEditorAction[] { diff --git a/src/vs/editor/test/browser/testCodeEditor.ts b/src/vs/editor/test/browser/testCodeEditor.ts index 7568be86d1d..b9f488595a2 100644 --- a/src/vs/editor/test/browser/testCodeEditor.ts +++ b/src/vs/editor/test/browser/testCodeEditor.ts @@ -87,7 +87,7 @@ export class TestCodeEditor extends CodeEditorWidget implements ICodeEditor { } public registerAndInstantiateContribution(id: string, ctor: new (editor: ICodeEditor, ...services: BrandedService[]) => T): T { const r: T = this._instantiationService.createInstance(ctor, this); - this._contributions2.set(id, r); + this._contributions.set(id, r); return r; } public registerDisposable(disposable: IDisposable): void {