microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-10 00:27:05 -06:00
Code Issues Packages Projects Releases 177 Wiki Activity

debt - clean up agent sessions openAgentSession around non local chats (#282278)

Browse Source 
* debt - clean up agent sessions `openAgentSession` around non local chats

* address CI feedback
This commit is contained in:
Benjamin Pasero 2025-12-09 20:45:06 +01:00 committed by GitHub
parent cbb350b007
commit ab41693fdd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts
View File

@ -191,7 +191,7 @@ export class AgentSessionsControl extends Disposable implements IAgentSessionsCo
sessionOptions.ignoreInView = true;
const options: IChatEditorOptions = {
let options: IChatEditorOptions = {
...sessionOptions,
...e.editorOptions,
revealIfOpened: this.options?.allowOpenSessionsInPanel // always try to reveal if already opened
@ -208,19 +208,10 @@ export class AgentSessionsControl extends Disposable implements IAgentSessionsCo
target = ACTIVE_GROUP;
}
const isLocalChatSession = session.resource.scheme === Schemas.vscodeChatEditor ||
session.resource.scheme === Schemas.vscodeLocalChatSession;
const isLocalChatSession = session.resource.scheme === Schemas.vscodeChatEditor || session.resource.scheme === Schemas.vscodeLocalChatSession;
if (!isLocalChatSession && !(await this.chatSessionsService.canResolveChatSession(session.resource))) {
// Not a chat session, let open editor figure out how to handle
const editorTarget = target === ChatViewPaneTarget ? undefined : target;
await this.editorService.openEditor({
resource: session.resource,
options: {
...options,
revealIfOpened: options?.revealIfOpened ?? true
}
}, editorTarget);
return;
target = e.sideBySide ? SIDE_GROUP : ACTIVE_GROUP; // force to open in editor if session cannot be resolved in panel
options = { ...options, revealIfOpened: true };
}
await this.chatWidgetService.openSession(session.resource, target, options);