microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-10 00:27:05 -06:00
Code Issues Packages Projects Releases 177 Wiki Activity

fix #233234 (#233673)

Browse Source
This commit is contained in:
Sandeep Somavarapu 2024-11-12 12:56:47 +01:00 committed by GitHub
parent b511829a77
commit 9a129c0139
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/vs/platform/extensions/common/extensionValidator.ts
View File

@ -361,14 +361,11 @@ export function areApiProposalsCompatible(apiProposals: string[], arg1?: any): b
const incompatibleProposals: string[] = [];
const parsedProposals = parseApiProposals(apiProposals);
for (const { proposalName, version } of parsedProposals) {
const existingProposal = productApiProposals[proposalName];
if (!existingProposal) {
continue;
}
if (!version) {
continue;
}
if (existingProposal.version !== version) {
const existingProposal = productApiProposals[proposalName];
if (existingProposal?.version !== version) {
incompatibleProposals.push(proposalName);
}
}

1
src/vs/platform/extensions/test/common/extensionValidator.test.ts
View File

@ -436,6 +436,7 @@ suite('Extension Version Validator', () => {
assert.strictEqual(areApiProposalsCompatible(['proposal1', 'proposal2'], {}), true);
assert.strictEqual(areApiProposalsCompatible(['proposal1', 'proposal2'], { 'proposal1': { proposal: '' } }), true);
assert.strictEqual(areApiProposalsCompatible(['proposal2@1'], { 'proposal1': { proposal: '' } }), false);
assert.strictEqual(areApiProposalsCompatible(['proposal1@1'], { 'proposal1': { proposal: '', version: 2 } }), false);
assert.strictEqual(areApiProposalsCompatible(['proposal1@1'], { 'proposal1': { proposal: '' } }), false);
});