diff --git a/src/vs/workbench/parts/preferences/common/preferencesModels.ts b/src/vs/workbench/parts/preferences/common/preferencesModels.ts
index 4814c92369c..fa76bc4e18d 100644
--- a/src/vs/workbench/parts/preferences/common/preferencesModels.ts
+++ b/src/vs/workbench/parts/preferences/common/preferencesModels.ts
@@ -381,7 +381,9 @@ export class SettingsEditorModel extends AbstractSettingsModel implements ISetti
 				}
 			}
 		};
-		visit(model.getValue(), visitor);
+		if (!model.isDisposed()) {
+			visit(model.getValue(), visitor);
+		}
 		this._settingsGroups = settings.length > 0 ? [<ISettingsGroup>{
 			sections: [
 				{