From 5f40bbf67f27a31be0cb2cdcc6ff613b81943967 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 19 Dec 2018 14:51:00 -0800 Subject: [PATCH] Use shorthand instead of extra nesting --- .../parameterHints/parameterHintsWidget.ts | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts b/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts index 65e60300d88..fd8f896a2d7 100644 --- a/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts +++ b/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts @@ -166,19 +166,15 @@ export class ParameterHintsModel extends Disposable { } for (const support of modes.SignatureHelpProviderRegistry.ordered(model)) { - if (Array.isArray(support.signatureHelpTriggerCharacters)) { - for (const ch of support.signatureHelpTriggerCharacters) { - this.triggerChars.add(ch.charCodeAt(0)); + for (const ch of support.signatureHelpTriggerCharacters || []) { + this.triggerChars.add(ch.charCodeAt(0)); - // All trigger characters are also considered retrigger characters - this.retriggerChars.add(ch.charCodeAt(0)); - - } + // All trigger characters are also considered retrigger characters + this.retriggerChars.add(ch.charCodeAt(0)); } - if (Array.isArray(support.signatureHelpRetriggerCharacters)) { - for (const ch of support.signatureHelpRetriggerCharacters) { - this.retriggerChars.add(ch.charCodeAt(0)); - } + + for (const ch of support.signatureHelpRetriggerCharacters || []) { + this.retriggerChars.add(ch.charCodeAt(0)); } } }