From 47bb528350ac4090525eac3e9be55a249c362b87 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 6 Jan 2016 16:57:09 +0100 Subject: [PATCH] fix missing sort call in language feature registry --- src/vs/editor/common/modes/languageFeatureRegistry.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/vs/editor/common/modes/languageFeatureRegistry.ts b/src/vs/editor/common/modes/languageFeatureRegistry.ts index 39592189e0b..f33ff2648f0 100644 --- a/src/vs/editor/common/modes/languageFeatureRegistry.ts +++ b/src/vs/editor/common/modes/languageFeatureRegistry.ts @@ -119,9 +119,7 @@ export default class LanguageFeatureRegistry { return; } - if (this._updateScores(model)) { - this._sortByScore(); - } + this._updateScores(model); let supportIndex: number = -1; let supportEntry: Entry; @@ -171,10 +169,8 @@ export default class LanguageFeatureRegistry { for (let entry of this._entries) { entry._score = score(entry.selector, model.getAssociatedResource(), model.getModeId()); } - return true; - } - private _sortByScore(): void { + // needs sorting this._entries.sort(LanguageFeatureRegistry._compareByScoreAndTime); }