From 08069da0075f86f8feafcaa249021080bcfc56a2 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 25 Aug 2021 14:28:43 -0700 Subject: [PATCH] Fix creation of terminal profiles via dropdown Fixes #131577 --- .../workbench/contrib/terminal/browser/terminalActions.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalActions.ts b/src/vs/workbench/contrib/terminal/browser/terminalActions.ts index 9018b13fed4..cc49814f55c 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalActions.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalActions.ts @@ -2004,12 +2004,8 @@ export function validateTerminalName(name: string): { content: string, severity: } function convertOptionsOrProfileToOptions(optionsOrProfile?: ICreateTerminalOptions | ITerminalProfile): ICreateTerminalOptions | undefined { - if (typeof optionsOrProfile === 'object') { - if ('profileName' in optionsOrProfile) { - return { config: optionsOrProfile as ITerminalProfile, location: (optionsOrProfile as ICreateTerminalOptions).location }; - } else if ('location' in optionsOrProfile) { - return { location: (optionsOrProfile as ICreateTerminalOptions).location }; - } + if (typeof optionsOrProfile === 'object' && 'profileName' in optionsOrProfile) { + return { config: optionsOrProfile as ITerminalProfile, location: (optionsOrProfile as ICreateTerminalOptions).location }; } return optionsOrProfile; }