From 045f45a19cf71e37e5fcc686a5135ba52c3872df Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Wed, 18 Feb 2026 12:36:50 +0100 Subject: [PATCH] sessions - fix part layout assumptions (#295988) --- src/vs/sessions/browser/parts/auxiliaryBarPart.ts | 2 +- src/vs/sessions/browser/parts/sidebarPart.ts | 2 +- .../contrib/sessions/browser/sessionsViewPane.ts | 10 +++------- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/vs/sessions/browser/parts/auxiliaryBarPart.ts b/src/vs/sessions/browser/parts/auxiliaryBarPart.ts index abb205600d5..d4e677a6215 100644 --- a/src/vs/sessions/browser/parts/auxiliaryBarPart.ts +++ b/src/vs/sessions/browser/parts/auxiliaryBarPart.ts @@ -105,7 +105,7 @@ export class AuxiliaryBarPart extends AbstractPaneCompositePart { { hasTitle: true, trailingSeparator: false, - borderWidth: () => 0, + borderWidth: () => (this.getColor(SIDE_BAR_BORDER) || this.getColor(contrastBorder)) ? 1 : 0, }, AuxiliaryBarPart.activeViewSettingsKey, ActiveAuxiliaryContext.bindTo(contextKeyService), diff --git a/src/vs/sessions/browser/parts/sidebarPart.ts b/src/vs/sessions/browser/parts/sidebarPart.ts index b689ed528f4..d632124f3de 100644 --- a/src/vs/sessions/browser/parts/sidebarPart.ts +++ b/src/vs/sessions/browser/parts/sidebarPart.ts @@ -99,7 +99,7 @@ export class SidebarPart extends AbstractPaneCompositePart { ) { super( Parts.SIDEBAR_PART, - { hasTitle: true, trailingSeparator: false, borderWidth: () => 0 }, + { hasTitle: true, trailingSeparator: false, borderWidth: () => (this.getColor(SIDE_BAR_BORDER) || this.getColor(contrastBorder)) ? 1 : 0 }, SidebarPart.activeViewletSettingsKey, ActiveViewletContext.bindTo(contextKeyService), SidebarFocusContext.bindTo(contextKeyService), diff --git a/src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts b/src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts index 8f6af610ad5..a243503c2f5 100644 --- a/src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts +++ b/src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts @@ -73,7 +73,6 @@ const CUSTOMIZATIONS_COLLAPSED_KEY = 'agentSessions.customizationsCollapsed'; export class AgenticSessionsViewPane extends ViewPane { private viewPaneContainer: HTMLElement | undefined; - private newSessionButtonContainer: HTMLElement | undefined; private sessionsControlContainer: HTMLElement | undefined; sessionsControl: AgentSessionsControl | undefined; private aiCustomizationContainer: HTMLElement | undefined; @@ -156,7 +155,7 @@ export class AgenticSessionsViewPane extends ViewPane { const sessionsContent = DOM.append(sessionsSection, $('.agent-sessions-content')); // New Session Button - const newSessionButtonContainer = this.newSessionButtonContainer = DOM.append(sessionsContent, $('.agent-sessions-new-button-container')); + const newSessionButtonContainer = DOM.append(sessionsContent, $('.agent-sessions-new-button-container')); const newSessionButton = this._register(new Button(newSessionButtonContainer, { ...defaultButtonStyles, secondary: true })); newSessionButton.label = localize('newSession', "New Session"); this._register(newSessionButton.onDidClick(() => this.activeSessionService.openNewSession())); @@ -402,14 +401,11 @@ export class AgenticSessionsViewPane extends ViewPane { protected override layoutBody(height: number, width: number): void { super.layoutBody(height, width); - if (!this.sessionsControl || !this.newSessionButtonContainer) { + if (!this.sessionsControl || !this.sessionsControlContainer) { return; } - const buttonHeight = this.newSessionButtonContainer.offsetHeight; - const customizationHeight = this.aiCustomizationContainer?.offsetHeight || 0; - const availableSessionsHeight = height - buttonHeight - customizationHeight; - this.sessionsControl.layout(availableSessionsHeight, width); + this.sessionsControl.layout(this.sessionsControlContainer.offsetHeight, width); } override focus(): void {