Carlos Zamora e8a883fd41 [SUI] Improve accessibility to open json (#18828) ...

The "open JSON" button in the settings UI wasn't working when invoked
via accessibility tools (specifically Narrator in scan mode and Voice
Access). For some reason, in those scenarios, neither the `Tapped` or
`KeyDown` event were hit!

This PR adds the logic to open the json file via the `ItemInvoked` event
instead. The `Tapped` and `KeyDown` handlers were removed to prevent a
redundant `OpenJson` event being raised.

Additionally, `SelectsOnInvoked` was set to `False` on the "open JSON"
nav item. This prevents the selection pill from moving to the nav item,
which feels more correct.

## Validation Steps Performed
The following scenarios are confirmed to open the JSON
✅ Mouse click
✅ Keyboard (Spacebar and Enter)
✅ Voice Access
✅ Narrator in scan mode

For all of these (except Voice Access), I've confirmed that holding the
Alt button while invoking the JSON button opens defaults.json.

Closes #18770
Closes #12003

(cherry picked from commit a8a47b93671361e529ff9f967d0e7c1b028eebb9)
Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgZrZKs PVTI_lADOAF3p4s4AxadtzgZrDtw
Service-Version: 1.23

2025-04-23 18:09:15 -05:00

..

Resources

Localization Updates - main - 04/16/2025 21:02:38 (#18807)

2025-04-21 17:38:49 -05:00

Actions.cpp

Implement MVVM for the Actions page (#14292)

2024-02-13 19:25:09 +00:00

Actions.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

Actions.idl

Implement MVVM for the Actions page (#14292)

2024-02-13 19:25:09 +00:00

Actions.xaml

Fix text scaling issues in settings UI (#17910)

2024-09-17 19:45:59 +02:00

ActionsViewModel.cpp

ci: upgrade to check-spelling v0.0.24 (#18261)

2024-12-04 12:06:31 -06:00

ActionsViewModel.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

ActionsViewModel.idl

Implement MVVM for the Actions page (#14292)

2024-02-13 19:25:09 +00:00

AddProfile.cpp

Update accessible names for 'add profile' page buttons (#12324)

2022-02-02 20:45:05 +00:00

AddProfile.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

AddProfile.idl

Disable duplicate button without selected profile (#12096)

2022-01-06 18:29:45 +00:00

AddProfile.xaml

Introduce Microsoft.Terminal.UI and consolidate UI helpers (#15107)

2024-03-01 17:56:49 +00:00

Appearances.cpp

Fix SUI crash when image alignment not centered (#18481)

2025-01-30 13:28:42 -08:00

Appearances.h

Make SUI previews readable by screen readers (#18418)

2025-01-21 18:21:30 -08:00

Appearances.idl

Make SUI previews readable by screen readers (#18418)

2025-01-21 18:21:30 -08:00

Appearances.xaml

Make SUI previews readable by screen readers (#18418)

2025-01-21 18:21:30 -08:00

ColorSchemes.cpp

Revert "Manually set the automation name of the default color scheme for screen reader (#14704)"

2023-01-23 19:01:49 -06:00

ColorSchemes.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

ColorSchemes.idl

Implement MVVM for Color Schemes (#13179)

2022-07-29 17:11:29 +00:00

ColorSchemes.xaml

Introduce Microsoft.Terminal.UI and consolidate UI helpers (#15107)

2024-03-01 17:56:49 +00:00

ColorSchemesPageViewModel.cpp

Upgrade fmt to 11.0.2 (#16007)

2024-08-08 15:40:05 -07:00

ColorSchemesPageViewModel.h

Deduplicate identical inbox color schemes to heal user settings (#12800)

2024-02-27 19:07:08 +00:00

ColorSchemesPageViewModel.idl

Deduplicate identical inbox color schemes to heal user settings (#12800)

2024-02-27 19:07:08 +00:00

ColorSchemeViewModel.cpp

Upgrade fmt to 11.0.2 (#16007)

2024-08-08 15:40:05 -07:00

ColorSchemeViewModel.h

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

ColorSchemeViewModel.idl

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

CommonResources.xaml

Fix missing icon and truncated text on NullableColorPicker (#18476)

2025-02-04 16:27:03 -06:00

Compatibility.cpp

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

Compatibility.h

Remove Monarch/Peasant & Make UI single-threaded (#18215)

2024-12-12 22:21:24 +01:00

Compatibility.idl

Remove Monarch/Peasant & Make UI single-threaded (#18215)

2024-12-12 22:21:24 +01:00

Compatibility.xaml

Remove Monarch/Peasant & Make UI single-threaded (#18215)

2024-12-12 22:21:24 +01:00

EditColorScheme.cpp

Deduplicate identical inbox color schemes to heal user settings (#12800)

2024-02-27 19:07:08 +00:00

EditColorScheme.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

EditColorScheme.idl

Rejuvenate the color schemes page (#13269)

2022-08-31 14:15:10 -07:00

EditColorScheme.xaml

Fix text scaling issues in settings UI (#17910)

2024-09-17 19:45:59 +02:00

EnumEntry.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

EnumEntry.idl

Enable text search on combo boxes (#9206)

2021-02-19 18:11:07 +00:00

GlobalAppearance.cpp

Implement MVVM for the GlobalAppearance page (#13390)

2022-07-08 20:49:03 +00:00

GlobalAppearance.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

GlobalAppearance.idl

Implement MVVM for the GlobalAppearance page (#13390)

2022-07-08 20:49:03 +00:00

GlobalAppearance.xaml

Add the ability to show the tab bar in fullscreen (#18171)

2025-01-30 13:53:43 -08:00

GlobalAppearanceViewModel.cpp

Add input scope startup setting (#17953)

2024-09-24 16:14:31 -05:00

GlobalAppearanceViewModel.h

Add the ability to show the tab bar in fullscreen (#18171)

2025-01-30 13:53:43 -08:00

GlobalAppearanceViewModel.idl

Add the ability to show the tab bar in fullscreen (#18171)

2025-01-30 13:53:43 -08:00

Interaction.cpp

Implement MVVM for the Interaction page (#13378)

2022-07-08 22:13:15 +00:00

Interaction.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

Interaction.idl

Implement MVVM for the Interaction page (#13378)

2022-07-08 22:13:15 +00:00

Interaction.xaml

Add miscellaneous simple settings to the settings UI (#17923)

2024-10-10 18:14:55 -05:00

InteractionViewModel.cpp

Implement MVVM for the Interaction page (#13378)

2022-07-08 22:13:15 +00:00

InteractionViewModel.h

Add miscellaneous simple settings to the settings UI (#17923)

2024-10-10 18:14:55 -05:00

InteractionViewModel.idl

Add miscellaneous simple settings to the settings UI (#17923)

2024-10-10 18:14:55 -05:00

KeyChordListener.cpp

Use type inference throughout the project (#12975)

2022-04-25 15:40:47 +00:00

KeyChordListener.h

Use type inference throughout the project (#12975)

2022-04-25 15:40:47 +00:00

KeyChordListener.idl

Add a KeyChordListener to the Settings UI (#10652)

2021-07-16 22:11:55 +00:00

KeyChordListener.xaml

Add a KeyChordListener to the Settings UI (#10652)

2021-07-16 22:11:55 +00:00

Launch.cpp

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

Launch.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

Launch.idl

Implement MVVM for the Launch page (#13377)

2022-07-08 11:55:37 +00:00

Launch.xaml

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

LaunchViewModel.cpp

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

LaunchViewModel.h

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

LaunchViewModel.idl

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

MainPage.cpp

[SUI] Improve accessibility to open json (#18828)

2025-04-23 18:09:15 -05:00

MainPage.h

[SUI] Improve accessibility to open json (#18828)

2025-04-23 18:09:15 -05:00

MainPage.idl

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

MainPage.xaml

[SUI] Improve accessibility to open json (#18828)

2025-04-23 18:09:15 -05:00

Microsoft.Terminal.Settings.Editor.def

…

Microsoft.Terminal.Settings.Editor.vcxproj

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

Microsoft.Terminal.Settings.Editor.vcxproj.filters

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

NewTabMenu.cpp

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

NewTabMenu.h

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

NewTabMenu.idl

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

NewTabMenu.xaml

[Windows 10] Fix layout in New Tab Menu page (#18424)

2025-01-21 18:22:20 -08:00

NewTabMenuViewModel.cpp

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

NewTabMenuViewModel.h

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

NewTabMenuViewModel.idl

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

NullableColorPicker.cpp

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

NullableColorPicker.h

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

NullableColorPicker.idl

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

NullableColorPicker.xaml

Fix missing icon and truncated text on NullableColorPicker (#18476)

2025-02-04 16:27:03 -06:00

pch.cpp

Remove UTF-8 BOM from all files (#11821)

2021-11-29 12:54:35 -06:00

pch.h

Add Profile.BellSound to Settings UI (#17983)

2024-12-12 22:44:32 +00:00

PercentageSignConverter.cpp

Use type inference throughout the project (#12975)

2022-04-25 15:40:47 +00:00

PercentageSignConverter.h

Add percentage sign to opacity slider values (#10369)

2021-06-09 22:45:06 +00:00

PreviewConnection.cpp

Use a plain char array to pass connection input (#17710)

2024-08-13 21:35:47 -05:00

PreviewConnection.h

Use a plain char array to pass connection input (#17710)

2024-08-13 21:35:47 -05:00

Profiles_Advanced.cpp

Add Profile.BellSound to Settings UI (#17983)

2024-12-12 22:44:32 +00:00

Profiles_Advanced.h

Add Profile.BellSound to Settings UI (#17983)

2024-12-12 22:44:32 +00:00

Profiles_Advanced.idl

Update Profile and Appearance VMs to use CSVM; remove nav state (#14572)

2023-01-18 15:30:00 -06:00

Profiles_Advanced.xaml

Add Profile.BellSound to Settings UI (#17983)

2024-12-12 22:44:32 +00:00

Profiles_Appearance.cpp

Fix font axis/feature SUI issues (#17173)

2024-05-02 11:12:34 -05:00

Profiles_Appearance.h

Fix font axis/feature SUI issues (#17173)

2024-05-02 11:12:34 -05:00

Profiles_Appearance.idl

Clean up the Converters implementation (#16820)

2024-03-18 09:26:18 -05:00

Profiles_Appearance.xaml

Unify padding parsers, make SUI operate on struct Thickness (#18300)

2025-01-24 17:17:41 -06:00

Profiles_Base_Orphaned.cpp

Retain (and indicate) orphaned dynamic profiles (#18188)

2024-11-15 09:02:31 -08:00

Profiles_Base_Orphaned.h

Retain (and indicate) orphaned dynamic profiles (#18188)

2024-11-15 09:02:31 -08:00

Profiles_Base_Orphaned.idl

Retain (and indicate) orphaned dynamic profiles (#18188)

2024-11-15 09:02:31 -08:00

Profiles_Base_Orphaned.xaml

Retain (and indicate) orphaned dynamic profiles (#18188)

2024-11-15 09:02:31 -08:00

Profiles_Base.cpp

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

Profiles_Base.h

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

Profiles_Base.idl

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

Profiles_Base.xaml

Make SUI previews readable by screen readers (#18418)

2025-01-21 18:21:30 -08:00

Profiles_Terminal.cpp

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

Profiles_Terminal.h

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

Profiles_Terminal.idl

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

Profiles_Terminal.xaml

Let folks disable OSC 52 (#18449)

2025-01-23 18:28:02 -06:00

ProfileViewModel.cpp

Unify padding parsers, make SUI operate on struct Thickness (#18300)

2025-01-24 17:17:41 -06:00

ProfileViewModel.h

Unify padding parsers, make SUI operate on struct Thickness (#18300)

2025-01-24 17:17:41 -06:00

ProfileViewModel.idl

Let folks disable OSC 52 (#18449)

2025-01-23 18:28:02 -06:00

Rendering.cpp

Implement MVVM for the Rendering page (#13391)

2022-07-08 22:50:38 +00:00

Rendering.h

Replace usages of TYPED_EVENT with til::event (#16837)

2024-03-20 11:02:26 -05:00

Rendering.idl

Implement MVVM for the Rendering page (#13391)

2022-07-08 22:50:38 +00:00

Rendering.xaml

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

RenderingViewModel.cpp

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

RenderingViewModel.h

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

RenderingViewModel.idl

Add a Compatibility and Terminal page to the Settings UI (#17895)

2024-10-10 23:54:31 +00:00

SegoeFluentIconList.h

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

SettingContainer.cpp

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

SettingContainer.h

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

SettingContainer.idl

Make SUI previews readable by screen readers (#18418)

2025-01-21 18:21:30 -08:00

SettingContainerStyle.xaml

Remove startOnUserLogin from the settings; use OS APIs only (#18530)

2025-03-26 15:20:29 -05:00

TerminalColorConverters.cpp

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

TerminalColorConverters.h

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

TerminalColorConverters.idl

Add nullable colors and improve Profile.Icon in settings UI (#17870)

2024-12-12 20:30:54 +00:00

Utils.cpp

wint_t is not wchar_t (#17653)

2024-08-02 14:43:41 -05:00

Utils.h

Minor grammar fix (#14614)

2023-01-09 19:25:03 +00:00

ViewModelHelpers.h

Add New Tab Menu Customization to Settings UI (#18015)

2024-12-03 15:07:13 -08:00

ViewModelHelpers.idl.h

Upgrade clang-format to 15.0.7 (#15110)

2023-04-05 10:03:20 -05:00