mirror of
https://github.com/microsoft/terminal.git
synced 2025-12-10 00:48:23 -06:00
00fe2b02bf
This commit serves two purposes: * Simplify construction of hashes for non-trivial structs This is especially helpful for ActionArgs * Improve hash quality by not needlessly throwing away entropy `til::hasher` is modeled after Rust's `std:#️⃣:Hasher` and works similar. The idea is simple: A stateful hash function can hash multiple unrelated fields, without loosing entropy by running a finalizer after hashing each interim field. This is especially useful for modern hash functions, which often have a wider internal state than the output width. Additionally this improves performance for hash functions with complex finalizers. Most of this is of course a bit moot right now, considering that `til::hasher` is still based on STL's FNV1a algorithm, which offers a very poor hash quality. But counterintuitively, FNV1a actually benefits most from this PR: Since it lacks a finalizer entirely, this commit greatly improves hash quality as it encodes more data into FNV's state and thus improves randomness. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * No unusual behavior ✅