mirror of
https://github.com/microsoft/terminal.git
synced 2025-12-10 00:48:23 -06:00
218c9fbe3e
Adds logic to display a warning popup if the settings.json is marked as read-only and we try to write to the settings.json file. Previously, this scenario would crash, which definitely isn't right. However, a simple fix of "not-crashing" wouldn't feel right either. This leverages the existing infrastructure to display a warning dialog when we failed to write to the settings file. The main annoyance here is that that popup dialog is located in `TerminalWindow` and is normally triggered from a failed `SettingsLoadEventArgs`. To get around this, `CascadiaSettings::WriteSettingsToDisk()` now returns a boolean to signal if the write was successful; whereas if it fails, a warning is added to the settings object. If we fail to write to disk, the function will return false and we'll raise an event with the settings' warnings to `TerminalPage` which passes it along to `TerminalWindow`. Additionally, this uses `IVectorView<SettingsLoadWarnings>` as opposed to `IVector<SettingsLoadWarnings>` throughout the relevant code. It's more correct as the list of warnings shouldn't be mutable and the warnings from the `CascadiaSettings` object are retrieved in that format. ## Validation Steps Performed - ✅ Using SUI, save settings when the settings.json is set to read-only Closes #18913
95 lines
4.7 KiB
C++
95 lines
4.7 KiB
C++
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
|
|
#pragma once
|
|
|
|
#include "MainPage.g.h"
|
|
#include "Breadcrumb.g.h"
|
|
#include "Utils.h"
|
|
|
|
namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
|
|
{
|
|
struct Breadcrumb : BreadcrumbT<Breadcrumb>
|
|
{
|
|
Breadcrumb(IInspectable tag, winrt::hstring label, BreadcrumbSubPage subPage) :
|
|
_Tag{ tag },
|
|
_Label{ label },
|
|
_SubPage{ subPage } {}
|
|
|
|
hstring ToString() { return _Label; }
|
|
|
|
WINRT_PROPERTY(IInspectable, Tag);
|
|
WINRT_PROPERTY(winrt::hstring, Label);
|
|
WINRT_PROPERTY(BreadcrumbSubPage, SubPage);
|
|
};
|
|
|
|
struct MainPage : MainPageT<MainPage>
|
|
{
|
|
MainPage() = delete;
|
|
MainPage(const Model::CascadiaSettings& settings);
|
|
|
|
void UpdateSettings(const Model::CascadiaSettings& settings);
|
|
|
|
void SettingsNav_Loaded(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
|
|
void SettingsNav_ItemInvoked(const Microsoft::UI::Xaml::Controls::NavigationView& sender, const Microsoft::UI::Xaml::Controls::NavigationViewItemInvokedEventArgs& args);
|
|
void SaveButton_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
|
|
void ResetButton_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
|
|
void BreadcrumbBar_ItemClicked(const Microsoft::UI::Xaml::Controls::BreadcrumbBar& sender, const Microsoft::UI::Xaml::Controls::BreadcrumbBarItemClickedEventArgs& args);
|
|
|
|
void SetHostingWindow(uint64_t hostingWindow) noexcept;
|
|
bool TryPropagateHostingWindow(IInspectable object) noexcept;
|
|
uint64_t GetHostingWindow() const noexcept;
|
|
|
|
winrt::Windows::UI::Xaml::Media::Brush BackgroundBrush();
|
|
|
|
Windows::Foundation::Collections::IObservableVector<IInspectable> Breadcrumbs() noexcept;
|
|
Editor::ExtensionsViewModel ExtensionsVM() const noexcept { return _extensionsVM; }
|
|
|
|
til::typed_event<Windows::Foundation::IInspectable, Model::SettingsTarget> OpenJson;
|
|
til::typed_event<Windows::Foundation::IInspectable, Windows::Foundation::Collections::IVectorView<Model::SettingsLoadWarnings>> ShowLoadWarningsDialog;
|
|
|
|
private:
|
|
Windows::Foundation::Collections::IObservableVector<IInspectable> _breadcrumbs;
|
|
Windows::Foundation::Collections::IObservableVector<IInspectable> _menuItemSource;
|
|
size_t _originalNumItems = 0u;
|
|
|
|
Model::CascadiaSettings _settingsSource;
|
|
Model::CascadiaSettings _settingsClone;
|
|
|
|
std::optional<HWND> _hostingHwnd;
|
|
|
|
void _InitializeProfilesList();
|
|
void _CreateAndNavigateToNewProfile(const uint32_t index, const Model::Profile& profile);
|
|
winrt::Microsoft::UI::Xaml::Controls::NavigationViewItem _CreateProfileNavViewItem(const Editor::ProfileViewModel& profile);
|
|
void _DeleteProfile(const Windows::Foundation::IInspectable sender, const Editor::DeleteProfileEventArgs& args);
|
|
void _AddProfileHandler(const winrt::guid profileGuid);
|
|
|
|
void _SetupProfileEventHandling(const winrt::Microsoft::Terminal::Settings::Editor::ProfileViewModel profile);
|
|
|
|
void _PreNavigateHelper();
|
|
void _Navigate(hstring clickedItemTag, BreadcrumbSubPage subPage);
|
|
void _Navigate(const Editor::ProfileViewModel& profile, BreadcrumbSubPage subPage);
|
|
void _Navigate(const Editor::NewTabMenuEntryViewModel& ntmEntryVM, BreadcrumbSubPage subPage);
|
|
void _Navigate(const Editor::ExtensionPackageViewModel& extPkgVM, BreadcrumbSubPage subPage);
|
|
void _NavigateToProfileHandler(const IInspectable& sender, winrt::guid profileGuid);
|
|
void _NavigateToColorSchemeHandler(const IInspectable& sender, const IInspectable& args);
|
|
|
|
void _UpdateBackgroundForMica();
|
|
void _MoveXamlParsedNavItemsIntoItemSource();
|
|
|
|
winrt::Microsoft::Terminal::Settings::Editor::ColorSchemesPageViewModel _colorSchemesPageVM{ nullptr };
|
|
winrt::Microsoft::Terminal::Settings::Editor::NewTabMenuViewModel _newTabMenuPageVM{ nullptr };
|
|
winrt::Microsoft::Terminal::Settings::Editor::ExtensionsViewModel _extensionsVM{ nullptr };
|
|
|
|
Windows::UI::Xaml::Data::INotifyPropertyChanged::PropertyChanged_revoker _profileViewModelChangedRevoker;
|
|
Windows::UI::Xaml::Data::INotifyPropertyChanged::PropertyChanged_revoker _colorSchemesPageViewModelChangedRevoker;
|
|
Windows::UI::Xaml::Data::INotifyPropertyChanged::PropertyChanged_revoker _ntmViewModelChangedRevoker;
|
|
Windows::UI::Xaml::Data::INotifyPropertyChanged::PropertyChanged_revoker _extensionsViewModelChangedRevoker;
|
|
};
|
|
}
|
|
|
|
namespace winrt::Microsoft::Terminal::Settings::Editor::factory_implementation
|
|
{
|
|
BASIC_FACTORY(MainPage);
|
|
}
|