Remove outdated or implied build conditions and parameters (#15842)

We no longer multiplex PGO through the test runner. We also removed the
compliance build.

build/pipelines/release.yml

@@ -60,10 +60,6 @@ parameters:
     type: string
     default: '0.0.8'
 
-  - name: runCompliance
-    displayName: "Run Compliance and Security Build"
-    type: boolean
-    default: true
   - name: publishSymbolsToPublic
     displayName: "Publish Symbols to MSDL"
     type: boolean

build/pipelines/templates-v2/job-run-pgo-tests.yml

@@ -65,7 +65,6 @@ jobs:
         -LogPath '${{ parameters.testLogPath }}'
         -Root "$(Terminal.BinDir)"
         -AdditionalTaefArguments '/select:(@IsPGO=true)','/p:WTTestContent=$(TerminalTestContentPath)'
-    condition: and(succeeded(), ne(variables['PGOBuildMode'], 'Instrument'))
 
   - task: CopyFiles@2
     displayName: 'Copy PGO outputs to Artifacts'

build/pipelines/templates-v2/job-test-project.yml

@@ -46,7 +46,6 @@ jobs:
       targetType: filePath
       filePath: build\scripts\Run-Tests.ps1
       arguments: -MatchPattern '*unit.test*.dll' -Platform '$(OutputBuildPlatform)' -Configuration '$(BuildConfiguration)' -LogPath '${{ parameters.testLogPath }}' -Root "$(Terminal.BinDir)"
-    condition: and(succeeded(), ne(variables['PGOBuildMode'], 'Instrument'))
 
   - ${{ if or(eq(parameters.platform, 'x64'), eq(parameters.platform, 'arm64')) }}:
     - task: PowerShell@2
@@ -55,27 +54,26 @@ jobs:
         targetType: filePath
         filePath: build\scripts\Run-Tests.ps1
         arguments: -MatchPattern '*feature.test*.dll' -Platform '$(OutputBuildPlatform)' -Configuration '$(BuildConfiguration)' -LogPath '${{ parameters.testLogPath }}' -Root "$(Terminal.BinDir)"
-      condition: and(succeeded(), ne(variables['PGOBuildMode'], 'Instrument'))
 
   - task: PowerShell@2
     displayName: 'Convert Test Logs from WTL to xUnit format'
+    condition: always()
     inputs:
       targetType: filePath
       filePath: build\Helix\ConvertWttLogToXUnit.ps1
       arguments: -WttInputPath '${{ parameters.testLogPath }}' -WttSingleRerunInputPath 'unused.wtl' -WttMultipleRerunInputPath 'unused2.wtl' -XUnitOutputPath 'onBuildMachineResults.xml' -TestNamePrefix '$(BuildConfiguration).$(BuildPlatform)'
-    condition: ne(variables['PGOBuildMode'], 'Instrument')
 
   - task: PowerShell@2
     displayName: 'Manually log test failures'
+    condition: always()
     inputs:
       targetType: filePath
       filePath: build\Helix\OutputTestErrorsForAzureDevops.ps1
       arguments: -XUnitOutputPath 'onBuildMachineResults.xml'
-    condition: ne(variables['PGOBuildMode'], 'Instrument')
 
   - task: PublishTestResults@2
     displayName: 'Upload converted test logs'
-    condition: ne(variables['PGOBuildMode'], 'Instrument')
+    condition: always()
     inputs:
       testResultsFormat: 'xUnit' # Options: JUnit, NUnit, VSTest, xUnit, cTest
       testResultsFiles: '**/onBuildMachineResults.xml'
@@ -85,6 +83,7 @@ jobs:
 
   - task: CopyFiles@2
     displayName: 'Copy result logs to Artifacts'
+    condition: always()
     inputs:
       Contents: |
        **/*.wtl
@@ -96,3 +95,4 @@ jobs:
 
   - publish: '$(Build.ArtifactStagingDirectory)/$(BuildConfiguration)/$(BuildPlatform)/test-logs'
     artifact: test-logs-$(BuildPlatform)-$(BuildConfiguration)${{ parameters.artifactStem }}
+    condition: always()