microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-10 18:43:54 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Fix a misdiagnosis in MSVC 17.11 (#17723)

Browse Source 
Mo' compiler, mo' problems.
This commit is contained in:
Leonard Hecker 2024-08-15 18:33:43 +02:00 committed by GitHub
parent 1511d2c2ad
commit bf44b6c360
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/buffer/out/OutputCell.cpp
View File

@ -9,6 +9,10 @@
#include "../../types/inc/convert.hpp" #include "../../types/inc/convert.hpp"
#include "../../inc/conattrs.hpp" #include "../../inc/conattrs.hpp"
// BODGY: Misdiagnosis in MSVC 17.11: Referencing global constants in the member
// initializer list leads to this warning. Can probably be removed in the future.
#pragma warning(disable : 26493) // Don't use C-style casts (type.4).)
static constexpr TextAttribute InvalidTextAttribute{ INVALID_COLOR, INVALID_COLOR }; static constexpr TextAttribute InvalidTextAttribute{ INVALID_COLOR, INVALID_COLOR };
OutputCell::OutputCell() noexcept : OutputCell::OutputCell() noexcept :

4
src/buffer/out/OutputCellIterator.cpp
View File

@ -11,6 +11,10 @@
#include "../../types/inc/GlyphWidth.hpp" #include "../../types/inc/GlyphWidth.hpp"
#include "../../inc/conattrs.hpp" #include "../../inc/conattrs.hpp"
// BODGY: Misdiagnosis in MSVC 17.11: Referencing global constants in the member
// initializer list leads to this warning. Can probably be removed in the future.
#pragma warning(disable : 26493) // Don't use C-style casts (type.4).)
static constexpr TextAttribute InvalidTextAttribute{ INVALID_COLOR, INVALID_COLOR, INVALID_COLOR }; static constexpr TextAttribute InvalidTextAttribute{ INVALID_COLOR, INVALID_COLOR, INVALID_COLOR };
// Routine Description: // Routine Description:

4
src/buffer/out/OutputCellView.cpp
View File

@ -5,6 +5,10 @@
#include "OutputCellView.hpp" #include "OutputCellView.hpp"
// BODGY: Misdiagnosis in MSVC 17.11: Referencing global constants in the member
// initializer list leads to this warning. Can probably be removed in the future.
#pragma warning(disable : 26493) // Don't use C-style casts (type.4).)
// Routine Description: // Routine Description:
// - Constructs a read-only view of data formatted as a single output buffer cell // - Constructs a read-only view of data formatted as a single output buffer cell
// Arguments: // Arguments:

4
src/buffer/out/textBuffer.cpp
View File

@ -12,6 +12,10 @@
#include "../types/inc/utils.hpp" #include "../types/inc/utils.hpp"
#include "search.h" #include "search.h"
// BODGY: Misdiagnosis in MSVC 17.11: Referencing global constants in the member
// initializer list leads to this warning. Can probably be removed in the future.
#pragma warning(disable : 26493) // Don't use C-style casts (type.4).)
using namespace Microsoft::Console; using namespace Microsoft::Console;
using namespace Microsoft::Console::Types; using namespace Microsoft::Console::Types;