microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-11 04:38:24 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Reduce malloc churn for console calls <=128KiB (#18287)

Browse Source 
This increases the console IO buffer size to retain at least 128KiB as
this matches the default buffer size of `cat`. This avoids allocator
churn due to constantly freeing and reallocating buffers. In the future
this should ideally use a better suited, cheap allocator.

Closes #18286
This commit is contained in:
Leonard Hecker 2024-12-05 09:34:00 -08:00 committed by GitHub
parent ca8c3bbb90
commit aa5459df4a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/server/ApiMessage.cpp
View File

@ -108,7 +108,7 @@ try
// If we were previously called with a huge buffer we have an equally large _inputBuffer. // If we were previously called with a huge buffer we have an equally large _inputBuffer.
// We shouldn't just keep this huge buffer around, if no one needs it anymore. // We shouldn't just keep this huge buffer around, if no one needs it anymore.
if (_inputBuffer.capacity() > 16 * 1024 && (_inputBuffer.capacity() >> 1) > cbReadSize) if (_inputBuffer.capacity() > 128 * 1024 && (_inputBuffer.capacity() >> 1) > cbReadSize)
{ {
_inputBuffer.shrink_to_fit(); _inputBuffer.shrink_to_fit();
} }
@ -151,7 +151,7 @@ try
// If we were previously called with a huge buffer we have an equally large _outputBuffer. // If we were previously called with a huge buffer we have an equally large _outputBuffer.
// We shouldn't just keep this huge buffer around, if no one needs it anymore. // We shouldn't just keep this huge buffer around, if no one needs it anymore.
if (_outputBuffer.capacity() > 16 * 1024 && (_outputBuffer.capacity() >> 1) > cbWriteSize) if (_outputBuffer.capacity() > 128 * 1024 && (_outputBuffer.capacity() >> 1) > cbWriteSize)
{ {
_outputBuffer.shrink_to_fit(); _outputBuffer.shrink_to_fit();
} }