microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 18:17:40 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Close the TermControl when closing a TerminalPaneContent (#19657)

Browse Source 
This fixes an issue where calling close on a tab/pane won't
raise a StateChange notification on the connection.
This commit is contained in:
Leonard Hecker 2025-12-17 19:19:15 +01:00 committed by GitHub
parent f321c30cc1
commit a79078924a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cascadia/TerminalApp/TerminalPaneContent.cpp
View File

@ -66,8 +66,12 @@ namespace winrt::TerminalApp::implementation
}
void TerminalPaneContent::Close()
{
// We deliberately remove the event handlers before closing the control.
// This is to prevent reentrancy issues, pointless callbacks, etc.
_removeControlEvents();
_control.Close();
// Clear out our media player callbacks, and stop any playing media. This
// will prevent the callback from being triggered after we've closed, and
// also make sure that our sound stops when we're closed.