mirror of
https://github.com/microsoft/terminal.git
synced 2025-12-10 18:43:54 -06:00
Fix TerminalPage not being released on window close (#17107)
Because this holds onto the root element, `TerminalPage` gets "leaked"
on Windows 10 when a window is closed until another is opened.
## Validation Steps Performed
* Set a breakpoint in `Renderer::~Renderer`
* Open and close a window
* Breakpoint used to not get hit and now it does ✅
This commit is contained in:
parent
19c24aced9
commit
a590a1bff0
@ -405,8 +405,6 @@ bool NonClientIslandWindow::Initialize()
|
||||
// - <none>
|
||||
void NonClientIslandWindow::SetContent(winrt::Windows::UI::Xaml::UIElement content)
|
||||
{
|
||||
_clientContent = content;
|
||||
|
||||
_rootGrid.Children().Append(content);
|
||||
|
||||
// SetRow only works on FrameworkElement's, so cast it to a FWE before
|
||||
|
||||
@ -58,7 +58,6 @@ private:
|
||||
std::optional<til::point> _oldIslandPos;
|
||||
|
||||
winrt::TerminalApp::TitlebarControl _titlebar{ nullptr };
|
||||
winrt::Windows::UI::Xaml::UIElement _clientContent{ nullptr };
|
||||
|
||||
wil::unique_hbrush _backgroundBrush;
|
||||
til::color _backgroundBrushColor;
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user