From 981a01e74d73334051813c81d957e95cf1e76d52 Mon Sep 17 00:00:00 2001 From: Pankaj Bhojwani Date: Fri, 15 Aug 2025 13:55:20 -0700 Subject: [PATCH] don't need this anymore --- .../TerminalSettingsModel/ActionArgs.h | 30 ------------------- .../TerminalSettingsModel/ActionArgs.idl | 1 - .../TerminalSettingsModel/ActionArgsMagic.h | 8 ----- 3 files changed, 39 deletions(-) diff --git a/src/cascadia/TerminalSettingsModel/ActionArgs.h b/src/cascadia/TerminalSettingsModel/ActionArgs.h index 929a4cfaab..de35fe1f0c 100644 --- a/src/cascadia/TerminalSettingsModel/ActionArgs.h +++ b/src/cascadia/TerminalSettingsModel/ActionArgs.h @@ -636,17 +636,6 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation h.write(ContentArgs()); return h.finalize(); } - uint32_t GetArgCount() - { - if (_ContentArgs) - { - if (const auto newTermArgs = _ContentArgs.try_as()) - { - return newTermArgs->GetArgCount(); - } - } - return 0; - } winrt::Windows::Foundation::Collections::IVectorView GetArgDescriptors() { if (_ContentArgs) @@ -766,10 +755,6 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation h.write(SplitSize()); return h.finalize(); } - uint32_t GetArgCount() - { - return gsl::narrow(GetArgDescriptors().Size()); - } winrt::Windows::Foundation::Collections::IVectorView GetArgDescriptors() { static const auto thisArgs = INIT_ARG_DESCRIPTORS(SPLIT_PANE_ARGS); @@ -874,17 +859,6 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation h.write(ContentArgs()); return h.finalize(); } - uint32_t GetArgCount() - { - if (_ContentArgs) - { - if (const auto newTermArgs = _ContentArgs.try_as()) - { - return newTermArgs->GetArgCount(); - } - } - return 0; - } winrt::Windows::Foundation::Collections::IVectorView GetArgDescriptors() { return _ContentArgs.as()->GetArgDescriptors(); @@ -1037,10 +1011,6 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation h.write(winrt::get_abi(_Actions)); return h.finalize(); } - uint32_t GetArgCount() - { - return _Actions.Size(); - } winrt::Windows::Foundation::Collections::IVectorView GetArgDescriptors() { return {}; diff --git a/src/cascadia/TerminalSettingsModel/ActionArgs.idl b/src/cascadia/TerminalSettingsModel/ActionArgs.idl index 7012343199..a58e95c6cb 100644 --- a/src/cascadia/TerminalSettingsModel/ActionArgs.idl +++ b/src/cascadia/TerminalSettingsModel/ActionArgs.idl @@ -23,7 +23,6 @@ namespace Microsoft.Terminal.Settings.Model interface IActionArgsDescriptorAccess { - UInt32 GetArgCount(); Windows.Foundation.Collections.IVectorView GetArgDescriptors(); IInspectable GetArgAt(UInt32 index); void SetArgAt(UInt32 index, Object value); diff --git a/src/cascadia/TerminalSettingsModel/ActionArgsMagic.h b/src/cascadia/TerminalSettingsModel/ActionArgsMagic.h index 0f99729a50..5fad7eb286 100644 --- a/src/cascadia/TerminalSettingsModel/ActionArgsMagic.h +++ b/src/cascadia/TerminalSettingsModel/ActionArgsMagic.h @@ -217,10 +217,6 @@ public: argsMacro(HASH_ARGS); \ return h.finalize(); \ } \ - uint32_t GetArgCount() \ - { \ - return gsl::narrow(GetArgDescriptors().Size()); \ - } \ winrt::Windows::Foundation::Collections::IVectorView GetArgDescriptors() \ { \ static const auto descriptors = INIT_ARG_DESCRIPTORS(argsMacro); \ @@ -249,10 +245,6 @@ private: InitListPlaceholder _placeholder; \ \ public: \ - uint32_t GetArgCount() \ - { \ - return gsl::narrow(GetArgDescriptors().Size()); \ - } \ winrt::Windows::Foundation::Collections::IVectorView GetArgDescriptors() \ { \ static const auto descriptors = INIT_ARG_DESCRIPTORS(argsMacro); \